View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18298 | Bug reports | Question editor | public | 2022-08-01 17:03 | 2022-08-08 09:16 |
Reporter | ollehar | Assigned To | gabrieljenik | ||
Priority | none | Severity | block | ||
Status | closed | Resolution | fixed | ||
Summary | 18298: Saving in question organizer always prompts | ||||
Description | "Do you want to leave this page" kind of browser prompt when saving in question organizer. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | master | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | - | ||||
Database type & version | - | ||||
Server OS (if known) | - | ||||
Webserver software & version (if known) | - | ||||
PHP Version | - | ||||
Can you try to confirm this, Gabriel? If yes, please fix and also write a functional test to make sure it never happens again, thank you. ^^ |
|
The problem is that a "beforeunload" is registered on that page to avoid exiting the page without saving. That doesn't work in most cases (because many things are loaded by ajax, so you lose changes anyway), and at the same time the message is displayed. We can make an "off" to the event, so that the message is not shown when saving. |
|
Yeah, good point, maybe just delete that prompt all together for now. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33701 |
|
Fixed in Release 5.3.30+220808 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2022-08-01 17:03 | ollehar | New Issue | |
2022-08-01 17:05 | ollehar | Assigned To | => gabrieljenik |
2022-08-01 17:05 | ollehar | Status | new => assigned |
2022-08-01 17:06 | ollehar | Note Added: 71273 | |
2022-08-01 17:06 | ollehar | Bug heat | 0 => 2 |
2022-08-01 19:46 | gabrieljenik | Note Added: 71281 | |
2022-08-01 19:46 | gabrieljenik | Bug heat | 2 => 4 |
2022-08-01 19:46 | gabrieljenik | Assigned To | gabrieljenik => ollehar |
2022-08-01 19:46 | gabrieljenik | Status | assigned => feedback |
2022-08-02 10:22 | ollehar | Note Added: 71289 | |
2022-08-02 15:59 | gabrieljenik | Status | feedback => ready for code review |
2022-08-02 15:59 | gabrieljenik | Note Added: 71299 | |
2022-08-02 18:23 | gabrieljenik | Changeset attached | => LimeSurvey master d52ec832 |
2022-08-02 18:23 | gabrieljenik | Note Added: 71302 | |
2022-08-02 18:23 | gabrieljenik | Assigned To | ollehar => gabrieljenik |
2022-08-02 18:23 | gabrieljenik | Resolution | open => fixed |
2022-08-03 12:06 | ollehar | Status | ready for code review => resolved |
2022-08-08 09:16 | LimeBot | Note Added: 71357 | |
2022-08-08 09:16 | LimeBot | Status | resolved => closed |
2022-08-08 09:16 | LimeBot | Bug heat | 4 => 6 |