View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18298Bug reportsQuestion editorpublic2022-08-08 09:16
Reporterollehar Assigned Togabrieljenik  
PrioritynoneSeverityblock 
Status closedResolutionfixed 
Summary18298: Saving in question organizer always prompts
Description

"Do you want to leave this page" kind of browser prompt when saving in question organizer.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)master
I will donate to the project if issue is resolvedNo
Browser-
Database type & version-
Server OS (if known)-
Webserver software & version (if known)-
PHP Version-

Users monitoring this issue

There are no users monitoring this issue.

Activities

ollehar

ollehar

2022-08-01 17:06

administrator   ~71273

Can you try to confirm this, Gabriel? If yes, please fix and also write a functional test to make sure it never happens again, thank you. ^^

gabrieljenik

gabrieljenik

2022-08-01 19:46

manager   ~71281

The problem is that a "beforeunload" is registered on that page to avoid exiting the page without saving.

That doesn't work in most cases (because many things are loaded by ajax, so you lose changes anyway), and at the same time the message is displayed.

We can make an "off" to the event, so that the message is not shown when saving.
But the best would be to define if the functionality must be present or not. If you have to have it, you have to make sure that it works also when browsing PJAX (difficult). If it's not needed, it's better to directly remove the "beforeunload" handler.

ollehar

ollehar

2022-08-02 10:22

administrator   ~71289

Yeah, good point, maybe just delete that prompt all together for now.

gabrieljenik

gabrieljenik

2022-08-02 15:59

manager   ~71299

https://github.com/LimeSurvey/LimeSurvey/pull/2559

gabrieljenik

gabrieljenik

2022-08-02 18:23

manager   ~71302

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33701

LimeBot

LimeBot

2022-08-08 09:16

administrator   ~71357

Fixed in Release 5.3.30+220808

Related Changesets

LimeSurvey: master d52ec832

2022-08-02 20:23

gabrieljenik

Committer: GitHub


Details Diff
Fixed issue 18298: Saving in question organizer always prompts (#2559)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
18298
mod - assets/scripts/admin/organize.js Diff File

Issue History

Date Modified Username Field Change
2022-08-01 17:03 ollehar New Issue
2022-08-01 17:05 ollehar Assigned To => gabrieljenik
2022-08-01 17:05 ollehar Status new => assigned
2022-08-01 17:06 ollehar Note Added: 71273
2022-08-01 17:06 ollehar Bug heat 0 => 2
2022-08-01 19:46 gabrieljenik Note Added: 71281
2022-08-01 19:46 gabrieljenik Bug heat 2 => 4
2022-08-01 19:46 gabrieljenik Assigned To gabrieljenik => ollehar
2022-08-01 19:46 gabrieljenik Status assigned => feedback
2022-08-02 10:22 ollehar Note Added: 71289
2022-08-02 15:59 gabrieljenik Status feedback => ready for code review
2022-08-02 15:59 gabrieljenik Note Added: 71299
2022-08-02 18:23 gabrieljenik Changeset attached => LimeSurvey master d52ec832
2022-08-02 18:23 gabrieljenik Note Added: 71302
2022-08-02 18:23 gabrieljenik Assigned To ollehar => gabrieljenik
2022-08-02 18:23 gabrieljenik Resolution open => fixed
2022-08-03 12:06 ollehar Status ready for code review => resolved
2022-08-08 09:16 LimeBot Note Added: 71357
2022-08-08 09:16 LimeBot Status resolved => closed
2022-08-08 09:16 LimeBot Bug heat 4 => 6