View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
18175Bug reportsErgonomypublic2022-06-06 10:232022-06-20 11:20
ReporterDenisChenu Assigned Togabrieljenik  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18175: html editor iframe did not take whole available place
Description

The html editor iframe don't take whole width

Steps To Reproduce

Steps to reproduce

Set user preferences

  • inline editor
  • Show edit mode in question editor (Yes)
    Go to group of any survey
    Go to question in same group

Expected result

The html iframe take whole width

Actual result

html iframe is limited to 650px (

.cke_contents {
    width: 650px;
}
TagsNo tags attached.
Attached Files
Capture d’écran du 2022-06-06 10-08-34.png (166,188 bytes)
Bug heat6
Complete LimeSurvey version number (& build)5.3.18
I will donate to the project if issue is resolvedNo
Browserfirefox
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
related to 17976 closedgabrieljenik Bad place for pencil in edit question 

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-06-06 14:33

manager   ~70229

I take it!
DenisChenu

DenisChenu

2022-06-06 16:00

developer   ~70242

With Show edit mode in question editor to NO

cke_reset seems disable this behaviour

Capture d’écran du 2022-06-06 15-59-09.png (89,495 bytes)   
Capture d’écran du 2022-06-06 15-59-09.png (89,495 bytes)   
DenisChenu

DenisChenu

2022-06-06 16:03

developer   ~70243

Remind : need to check 6 options ;)

HTML inline + direct edit YES
HTML inline + direct edit NO
HTML popup + direct edit YES
HTML popup + direct edit NO
no HTML (show as source code in select) + direct edit YES
no HTML (show as source code in select) + direct edit NO

Else : each part fixed can break another one …

Capture d’écran du 2022-06-06 16-02-41.png (19,491 bytes)   
Capture d’écran du 2022-06-06 16-02-41.png (19,491 bytes)   
gabrieljenik

gabrieljenik

2022-06-09 16:27

manager   ~70316

Last edited: 2022-06-10 15:51

This is strange.
On Chrome this is not reproducible, as cke_reset rule overrides cke_content. (expected)

<div id="cke_1_contents" class="cke_contents cke_reset" ...

On FF cke_reset definition is not overuling.
Should we just remove the cke_content definition? (This is on adminbasics)

Thanks!
DenisChenu

DenisChenu

2022-06-09 17:11

developer   ~70317

I think it's order ?

I don't know why there are this fixed width in adminbasics: seems great to remove it !
Or set it as min-width: 10em, with:100% ;)
gabrieljenik

gabrieljenik

2022-06-13 18:46

manager   ~70347

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2463
gabrieljenik

gabrieljenik

2022-06-15 11:23

manager   ~70376

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33579
LimeBot

LimeBot

2022-06-20 11:20

administrator   ~70416

Fixed in Release 5.3.21+220620

Related Changesets

LimeSurvey: master 59dc1f04

2022-06-15 13:21

gabrieljenik

Committer: GitHub


Details Diff		 Fixed issue 18175: html editor iframe did not take whole available place (#2463) Affected Issues
18175
mod - assets/packages/adminbasics/build/adminbasics.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.min.css Diff File
mod - assets/packages/adminbasics/scss/000-lime-admin-common.scss Diff File

Issue History

Date Modified Username Field Change
2022-06-06 10:23 DenisChenu New Issue
2022-06-06 10:23 DenisChenu File Added: Capture d’écran du 2022-06-06 10-08-34.png
2022-06-06 10:24 DenisChenu Relationship added related to 17976
2022-06-06 12:04 DenisChenu Summary html editor iframe disn't take whole available place => html editor iframe did't take whole available place
2022-06-06 12:04 DenisChenu Summary html editor iframe did't take whole available place => html editor iframe did not take whole available place
2022-06-06 14:33 gabrieljenik Assigned To => gabrieljenik
2022-06-06 14:33 gabrieljenik Status new => assigned
2022-06-06 14:33 gabrieljenik Note Added: 70229
2022-06-06 14:33 gabrieljenik Bug heat 0 => 2
2022-06-06 16:00 DenisChenu Note Added: 70242
2022-06-06 16:00 DenisChenu File Added: Capture d’écran du 2022-06-06 15-59-09.png
2022-06-06 16:00 DenisChenu Bug heat 2 => 4
2022-06-06 16:03 DenisChenu Note Added: 70243
2022-06-06 16:03 DenisChenu File Added: Capture d’écran du 2022-06-06 16-02-41.png
2022-06-09 16:27 gabrieljenik Note Added: 70316
2022-06-09 17:11 DenisChenu Note Added: 70317
2022-06-10 15:51 gabrieljenik Note Edited: 70316
2022-06-13 18:46 gabrieljenik Status assigned => ready for code review
2022-06-13 18:46 gabrieljenik Note Added: 70347
2022-06-15 11:23 gabrieljenik Changeset attached => LimeSurvey master 59dc1f04
2022-06-15 11:23 gabrieljenik Note Added: 70376
2022-06-15 11:23 gabrieljenik Resolution open => fixed
2022-06-20 11:20 LimeBot Note Added: 70416
2022-06-20 11:20 LimeBot Status ready for code review => closed
2022-06-20 11:20 LimeBot Bug heat 4 => 6