View Issue Details

This bug affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
18168Bug reportsOtherpublic2022-08-18 10:55
Reporterjschleus Assigned Toc_schmitz  
PrioritynoneSeveritytext 
Status closedResolutionfixed 
Product Version5.3.x 
Summary18168: Codespell report for "LimeSurvey" Community Editiion (on fossies.org)
Description

The FOSS server [[https://fossies.org|fossies.org]] - supporting also the [[https://fossies.org/linux/limesurvey|LimeSurvey]] project - offers among others a feature named "[[https://fossies.org/features.html#codespell|Source code misspelling reports]]". Such reports are normally only generated on request, but as Fossies administrator I have created for testing purposes such a [[https://github.com/codespell-project/codespell|codespell]] based analysis for the LimeSurvey GitHub "master" version:

https://fossies.org/linux/test/limesurvey-master.tar.gz/codespell.html

That version-independent URL should redirect always to the report for the latest "master" version identified by the short GitHub commit ID and a year-month-day string (YYMMDD) representing the according git pull date (mostly = commit date). The data are residing within a special restricted "test" folder that isn't really integrated into the standard Fossies services and should also not be accessible to search engines. The report should be available at least for some weeks and is continuously updated (currently with a half-hourly refresh rate).

By the way, the context type of the spelling errors and typos are marked by a single character (within the sortable column "T"): The less interesting, probably not user visible ones (in "comments") are greyed, while the probably more interesting ones are black-colored. Especially interesting may be unassigned errors marked by a "?" since they may be contained in the source code itself. Some more according information is offered by a tooltip if the mouse is over the string "error context type character" above the table, over the "T" in the table header or over such a context character itself within the table. If JavaScript is enabled all table columns are sortable.

Although after a first review some obviously wrong matches ("False Positives" = FPs) are already filtered out (ignored) please inform me if you find more of them so that I can exclude them if applicable.

Just for information there are also three supplemental pages showing some used "codespell" [[https://fossies.org/linux/wwwlimesurvey/codespell_conf.html|configuration details]], all obvious [[https://fossies.org/linux/www/limesurvey/codespell_fps.html|false positives]] and a [[https://fossies.org/linux/www/limesurvey/codespell_hist.html|misspelling history]] (log).

OK, spelling corrections certainly have a low priority, but they may also contribute to the overall quality of a software project. So I hope that the report can nevertheless be a little bit useful.

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)GitHub master
I will donate to the project if issue is resolvedNo
Browser
Database type & version(all)
Server OS (if known)
Webserver software & version (if known)
PHP Version(all)

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2022-06-01 11:43

administrator   ~70182

Thank you for letting us know!
We fixed this now in the dev branch as far as it concerns our own code (some of them are in third-party libraries).

c_schmitz

c_schmitz

2022-08-18 10:55

administrator   ~71476

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33774

Related Changesets

LimeSurvey: master 64b2f3f8

2022-06-01 11:41:20

c_schmitz

Details Diff
Fixed issue 18168: Big number of spelling errors Affected Issues
18168
mod - application/commands/TwigCommand.php Diff File
mod - application/config/config-defaults.php Diff File
mod - application/config/internal.php Diff File
mod - application/config/ldap.php Diff File
mod - application/controllers/AdminController.php Diff File
mod - application/controllers/QuestionAdministrationController.php Diff File
mod - application/controllers/RegisterController.php Diff File
mod - application/controllers/ResponsesController.php Diff File
mod - application/controllers/ThemeOptionsController.php Diff File
mod - application/controllers/UploaderController.php Diff File
mod - application/controllers/admin/Authentication.php Diff File
mod - application/controllers/admin/CheckIntegrity.php Diff File
mod - application/controllers/admin/ConditionsAction.php Diff File
mod - application/controllers/admin/DataEntry.php Diff File
mod - application/controllers/admin/ExpressionValidate.php Diff File
mod - application/controllers/admin/Labels.php Diff File
mod - application/controllers/admin/Saved.php Diff File
mod - application/controllers/admin/Themes.php Diff File
mod - application/controllers/admin/Tokens.php Diff File
mod - application/controllers/admin/Translate.php Diff File
mod - application/controllers/admin/Update.php Diff File
mod - application/core/LSETwigViewRenderer.php Diff File
mod - application/core/LSYii_ClientScript.php Diff File
mod - application/core/LSYii_CompareInsensitiveValidator.php Diff File
mod - application/core/LS_Twig_Extension.php Diff File
mod - application/core/LimeMailer.php Diff File
mod - application/core/QuestionTypes/ArrayMultiscale/RenderArrayMultiscale.php Diff File
mod - application/core/QuestionTypes/Language/RenderLanguageSelector.php Diff File
mod - application/core/SurveyCommonAction.php Diff File
mod - application/core/plugins/AuthLDAP/AuthLDAP.php Diff File
mod - application/core/plugins/ExportSPSSsav/SPSSWriter.php Diff File
mod - application/core/plugins/ExportSTATAxml/STATAxmlWriter.php Diff File
mod - application/core/plugins/TwoFactorAdminLogin/views/index.php Diff File
mod - application/core/plugins/statFunctions/countFunctions.php Diff File
mod - application/extensions/yiiwheels/widgets/grid/WhGroupGridView.php Diff File
mod - application/helpers/SurveyRuntimeHelper.php Diff File
mod - application/helpers/Zend/Http/Client.php Diff File
mod - application/helpers/Zend/Http/UserAgent/AbstractDevice.php Diff File
mod - application/helpers/admin/export/FormattingOptions.php Diff File
mod - application/helpers/admin/export/JsonWriter.php Diff File
mod - application/helpers/admin/export/SurveyDao.php Diff File
mod - application/helpers/admin/import_helper.php Diff File
mod - application/helpers/admin/label_helper.php Diff File
mod - application/helpers/admin/statistics_helper.php Diff File
mod - application/helpers/common_helper.php Diff File
mod - application/helpers/expressions/em_core_helper.php Diff File
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - application/helpers/frontend_helper.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - application/helpers/update/updatedb_helper.php Diff File
mod - application/helpers/update/updates/Update_325.php Diff File
mod - application/helpers/userstatistics_helper.php Diff File
mod - application/helpers/viewHelper.php Diff File
mod - application/libraries/ExtensionInstaller/QuestionThemeInstaller.php Diff File
mod - application/libraries/admin/quexmlpdf.php Diff File
mod - application/models/ArchivedTableSettings.php Diff File
mod - application/models/Box.php Diff File
mod - application/models/MapTutorialUsers.php Diff File
mod - application/models/Notification.php Diff File
mod - application/models/Participant.php Diff File
mod - application/models/ParticipantAttributeName.php Diff File
mod - application/models/ParticipantAttributeNameLang.php Diff File
mod - application/models/ParticipantShare.php Diff File
mod - application/models/Permission.php Diff File
mod - application/models/Permissiontemplates.php Diff File
mod - application/models/Question.php Diff File
mod - application/models/QuestionAttribute.php Diff File
mod - application/models/QuestionTheme.php Diff File
mod - application/models/SettingGlobal.php Diff File
mod - application/models/SettingsUser.php Diff File
mod - application/models/Survey.php Diff File
mod - application/models/SurveyDynamic.php Diff File
mod - application/models/Surveymenu.php Diff File
mod - application/models/SurveymenuEntries.php Diff File
mod - application/models/SurveysGroups.php Diff File
mod - application/models/SurveysGroupsettings.php Diff File
mod - application/models/SurveysInGroup.php Diff File
mod - application/models/Template.php Diff File
mod - application/models/TemplateConfig.php Diff File
mod - application/models/TemplateConfiguration.php Diff File
mod - application/models/TemplateManifest.php Diff File
mod - application/models/Tutorial.php Diff File
mod - application/models/TutorialEntry.php Diff File
mod - application/models/TutorialEntryRelation.php Diff File
mod - application/models/UpdateForm.php Diff File
mod - application/models/UserInPermissionrole.php Diff File
mod - application/third_party/pclzip/pclzip.lib.php Diff File
mod - application/third_party/pear/OLE/PPS/Root.php Diff File
mod - application/third_party/tcpdf/include/tcpdf_static.php Diff File
mod - application/third_party/tcpdf/tcpdf.php Diff File
mod - application/views/admin/export/generatestats/_statisticsoutput_answer.php Diff File
mod - application/views/admin/export/generatestats/_statisticsoutput_gross_total.php Diff File
mod - application/views/admin/export/generatestats/simplestats/_statisticsoutput_answer.php Diff File
mod - application/views/admin/survey/subview/accordion/_plugins_panel.php Diff File
mod - application/views/admin/survey/subview/accordion/_resources_panel.php Diff File
mod - application/views/admin/survey/subview/import_ressources_modal.php Diff File
mod - application/views/admin/update/_updateContainer.php Diff File
mod - application/views/admin/update/check_updates/update_buttons/_updatesavailable.php Diff File
mod - application/views/admin/update/check_updates/update_buttons/_updatesavailable_error.php Diff File
mod - application/views/admin/update/updater/_error.php Diff File
mod - application/views/admin/update/updater/steps/textaeras/_existingfiles.php Diff File
mod - application/views/admin/update/updater/steps/textaeras/_modifiedfiles.php Diff File
mod - application/views/admin/update/updater/steps/textaeras/_readonlyfiles.php Diff File
mod - application/views/admin/update/updater/welcome/_welcome.php Diff File
mod - application/views/admin/user/editusers.php Diff File
mod - application/views/admin/user/personalsettings.php Diff File
mod - application/views/responses/listResponses_view.php Diff File
mod - application/views/survey/questions/answer/hugefreetext/config.xml Diff File
mod - application/views/survey/questions/answer/longfreetext/config.xml Diff File
mod - application/views/survey/questions/answer/multipleshorttext/config.xml Diff File
mod - application/views/survey/questions/answer/shortfreetext/config.xml Diff File
mod - application/views/survey/system/errorAlert.php Diff File
mod - application/views/survey/system/errorWarning.php Diff File
mod - application/views/surveyAdministration/activateSurvey_view.php Diff File
mod - application/views/surveyAdministration/editLocalSettings_main_view.php Diff File
mod - application/views/surveyAdministration/survey_topbar.php Diff File
mod - application/views/surveyAdministration/tabCreate_view.php Diff File
mod - assets/packages/limesurvey/survey.js Diff File
mod - docs/release_notes.txt Diff File
mod - framework/db/schema/cubrid/CCubridSchema.php Diff File
mod - framework/vendors/htmlpurifier/HTMLPurifier.standalone.php Diff File
mod - framework/web/CBaseController.php Diff File
mod - framework/web/helpers/CJSON.php Diff File
mod - framework/web/widgets/CAutoComplete.php Diff File
mod - modules/admin/globalsettings/controller/globalsettings.php Diff File
mod - tests/functional/backend/SaveEditedReponseTest.php Diff File
mod - upload/twig/extensions/HelloWorld_Twig_Extension/HelloWorld_Twig_Extension.php Diff File

LimeSurvey: master 9bfb1c04

2022-08-12 08:59:35

twilllig

Details Diff
Fixed issue 18168: Big number of spelling errors (Fix for 2FA gridview) Affected Issues
18168
mod - application/core/plugins/TwoFactorAdminLogin/models/TFAUser.php Diff File

Issue History

Date Modified Username Field Change
2022-06-01 10:43 jschleus New Issue
2022-06-01 11:40 c_schmitz Assigned To => c_schmitz
2022-06-01 11:40 c_schmitz Status new => assigned
2022-06-01 11:43 c_schmitz Status assigned => resolved
2022-06-01 11:43 c_schmitz Resolution open => fixed
2022-06-01 11:43 c_schmitz Note Added: 70182
2022-06-01 11:43 c_schmitz Bug heat 0 => 2
2022-06-01 11:44 c_schmitz Status resolved => closed
2022-08-18 10:55 twilllig Changeset attached => LimeSurvey master 9bfb1c04
2022-08-18 10:55 c_schmitz Changeset attached => LimeSurvey master 64b2f3f8
2022-08-18 10:55 c_schmitz Note Added: 71476