Seems parent question still have other == 'Y'
https://github.com/LimeSurvey/LimeSurvey/blob/a529a3d1a2c553cbd2494b2ea6d801ca87478c4f/application/models/Question.php#L171

You can try to save as array before try again ?

Hmm, we have switched this question from a single choice question into an array questions. Could this be some kind of left-over?

Surely a single choice with other …

But : i think other='N' must be resetted when you save
Else : we have this error in 3.X

Maybe you can check with 3.X

1. Create a single choice Other == 'Y'
2. Save it
3. Update to array
4. Add other for subquestions

Then : dev can check how it's done in 3.X

At LS3 the error does NOT show up. I did the steps you described and could use "other" there.

image-2.png (11,518 bytes)   

image-2.png (11,518 bytes)   

Thank you !

Pull request : https://github.com/LimeSurvey/LimeSurvey/pull/2443

Improved pull request : https://github.com/LimeSurvey/LimeSurvey/pull/2443

Strange. I wasn't able to reproduce the issue on latest master (no patch applied).
@DenisChenu @Mazi Am I missing something?

image-3.png (37,694 bytes)   

image-3.png (37,694 bytes)   

You must

Create a single choice Other == 'Y'
Save and close it
Update to array
Save and close it
Add other for subquestions
Save and close it

Other are not resetted if question type didn't allow other

Capture d’écran du 2022-06-10 08-20-58.png (32,858 bytes)   

Capture d’écran du 2022-06-10 08-20-58.png (32,858 bytes)   

Tested OK. Haven't done regression testing.
Still considering the strange reproduction steps needed and the code updated, as to avoid regressions, I would send it to DEV as to have the code be sinked and lived for a while.

I don't understand what you want it in DEV, there are no major recoding here. Just create some var in place of fixed test

Fixed test :

                ($oQuestion->type == Question::QT_L_LIST)
                || ($oQuestion->type == Question::QT_EXCLAMATION_LIST_DROPDOWN)
                || ($oQuestion->type == Question::QT_P_MULTIPLE_CHOICE_WITH_COMMENTS)
                || ($oQuestion->type == Question::QT_M_MULTIPLE_CHOICE)

Moving to a clean function

And add this rule :

        $aRules[] = array('other', 'filter', 'filter' => function ($value) {
            if ($this->getAllowOther()) {
                return $value;
            }
            return 'N';
        });

Already say : i prefer a good complete fix than create 4 bugs for the same file part …

First of all, we had problems tying to reproduce it.
If you look at the steps for reproducing, they are not the usual path a user would do.
Also, I believe I tried couple of times, mixing "save" with "save and close" and wasn't able to reproduce it.
So, that's why I say it is not a very common issue.

Also, the PR is not just 2 blocks of changes, you are updating the definition for every question, re organizing how the title validations is done for all questions, .... Nevertheless the test is only a unit test about this fix.

At last as per "Already say : i prefer a good complete fix than create 4 bugs for the same file part …", I don't agree.
Doing bigger changes make issues harder to back-track, harder to test, more error prone, riskier to release, ...
We need to balance scope of fixing vs de-stabilization of the platform.
We are not perfect coders neither have the complete full view of the different situations that could arise.
So the least we update on a fix, sometimes is the better.

Also, the PR is not just 2 blocks of changes, you are updating the definition for every question, re organizing how the title validations is done for all questions, .... Nevertheless the test is only a unit test about this fix.

See :
It's really 2 update … moving hardcoded definition to place where it need to be …

Well.. sometimes it is OK if we disagree :)

You have some linefeed too , and moving

       /* Don't save empty or 'core' question theme name */
        $aRules[] = ['question_theme_name', 'questionThemeNameValidator'];

before if (!$this->isNewRecord) {

There are a related issue

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33613

Fixed in Release 5.3.23+220705