Hi,

The issue remains in version 5.3.4+220309

@ollehar what do you think about the following.

How about adding a parameter to the newLoginForm event? The new parameter would indicate the name of the authentication method. If it is left empty, it is taken from the same place as now.

Hm, how would that solve the translation issue?

Each auth plugin can set their own translation of their plugin name

Yes, but it can only be translated if the text is wrapped in gT(), which I believe is the problem here?

Each plugin would send the text already translated... not sure if talking about the same.

protected static $name = 'LimeSurvey internal database';  // Missing gT or eT

Hm. Maybe we also need getName() in PluginBase, so that gT is applied.

This is how the dropdown is formed. (see attachment)

If we use a method, it will have to be a static method.
Probably i would separate it from the name, as to allow a friendly label to be shown and not the technical name.
So I wouldn't choose the method name to be "getPluginName()", but "getAuthenticationName()", and that could be on the AuthPluginBase.

I prefer the new parameter on the event as it is a bit cleaner as all the exchange in between the plugin and the core would be via event.

What do you think?

As for setting the new parameter, we will not be able to use event->set() as that is not multidimensional and we need to allow all plugins to set a different value each. So I would create a new event method event->setForPlugin($plugin, $key, $value).

That would be very usefull for avoiding workarounds like this (https://github.com/LimeSurvey/LimeSurvey/blob/master/application/core/plugins/ExportR/ExportR.php#L57) where one plugin can easily mess something set by another plugin. (not talking about security, but about overwriting by accident, for example)

Thoughts?

image.png (98,133 bytes)   

image.png (98,133 bytes)   

Hm. Maybe we also need getName() in PluginBase, so that gT is applied.

I already done like this before :)
(i stop : i keep the name unchanged now)

Alternative solution : Plugin event can get name for drop-down with another function ?

Then : name of plugin can stay AuthCas for but shown as «Authentification with your CAS account» in this dropdow.

Easy solution

    public function getPublicName()
    {
        return $this->getName();
    }

Hmmm, if there's a config.xml, it will read name from there instead. ExtensionConfig::getName(). Would it make sense to put gT() in there? But it should be $plugin->gT() so it would read from plugin translation files first. :d

But yeah, maybe you're right, it should be a separate label, and plugin name should never really be translated anyway...?

You can already translate name in own plugin :
https://github.com/LimeSurvey/LimeSurvey/blob/e871bea897585edf28de26d0723bf02d746210f7/application/libraries/PluginManager/PluginBase.php#L188

No need to add gT globally … just do it for needed part inside needed plugin.

The question about $this->gT is already open somewhere …
Improving translation in core plugin is not improving translation for all other plugin.

Same for SurveyTheme and QuestionTheme : and here : no way …

I prefer the new parameter on the event as it is a bit cleaner as all the exchange in between the plugin and the core would be via event.

Thoughts on this?

all the exchange in between the plugin and the core would be via event.

No … since it extend a existing Class : for me it's clear it can replace public function of this class.

I really prefer to use getName(); than a new event …
( but prefer to have a dedicated function since i use Class name for name now).

Vote :
Event value : 1
Function call : 1

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2637

@samarta Not sure about your technical background, but maybe you can help on testing the PR?

Thanks!

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33932

Fixed in Release 5.4.5+221010

Updated https://manual.limesurvey.org/Authentication_plugin_development#The_authentication_method_name