View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 14
IDProjectCategoryView StatusDate SubmittedLast Update
17560Bug reportsUser / Groups / Rolespublic2021-09-01 12:462023-05-09 15:05
ReporterMazi Assigned Totibor.pacalat  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version5.x 
Summary17560: Layout issue when setting user rights
Description

When adding a new admin user and setting rights the screen looks broken. Tested on my Laptop with ~1600px screen width.

Steps To Reproduce

Add a new admin user and set the rights.

TagsNo tags attached.
Attached Files
image.png (112,695 bytes)
Bug heat14
Complete LimeSurvey version number (& build)Version 5.1.5+210830
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version?

Users monitoring this issue

There are no users monitoring this issue.

Activities

galads

galads

2021-09-01 15:07

reporter   ~66259

I saw this some time back but when I tried to reproduce it again, it disappeared. I think this is due to the screen size
galads

galads

2021-09-01 15:11

reporter   ~66260

It happens for small screens.
ollehar

ollehar

2021-09-01 17:04

administrator   ~66269

I've seen this too, happens on my screen. Not too small. :)
Mazi

Mazi

2023-04-11 12:24

updater   ~74460

@ollehar, I think galads has left. Can you assign this to someone else?
gabrieljenik

gabrieljenik

2023-04-24 17:52

manager   ~74615

This seems solved on v6. Does it worth fixing on v5?
tibor.pacalat

tibor.pacalat

2023-04-24 17:55

administrator   ~74616

I would say yes.
Mazi

Mazi

2023-04-24 22:26

updater   ~74623

Yes :-)
gabrieljenik

gabrieljenik

2023-04-26 20:24

manager   ~74663

https://github.com/LimeSurvey/LimeSurvey/pull/3074

Seems hard to reproduce as modal was already large.
Added scrollable behaviour. just in case.
DenisChenu

DenisChenu

2023-04-27 07:34

developer   ~74667

Seems hard to reproduce as modal was already large.

Can be with zoom too
DenisChenu

DenisChenu

2023-04-27 07:44

developer   ~74668

The fix is worth than issue for UX

Seem best solutiin is to create a new css class for max-with of dialog in little screen ?

See screencast with zoom at 150%

Bad-UX.gif (880,324 bytes)
Dialog-100%width.gif (376,406 bytes)
gabrieljenik

gabrieljenik

2023-04-27 14:35

manager   ~74687

What size of screen do you have?
v5 specifically is not responsive, so it is not worth applying lot of effort focused on small screens.

Also, the issue was with bigger screens, that's why it is hard to reproduce.
I added the responsive just in case. It shouldn't impact 99% of the users.

The fix is worth than issue for UX

I guess you mean The fix is worst than issue for UX.
I don't agree with the comment.

PS: You could have said something like I don't like the solution instead.
gabrieljenik

gabrieljenik

2023-04-27 14:36

manager   ~74688

@Mazi, can you try reproducing the issue again?
That will probably give us better directions.
DenisChenu

DenisChenu

2023-04-27 15:00

developer   ~74689

PS: You could have said something like I don't like the solution instead.

No : before you can click on any checkbox with zoom at 150% without complex action.
With the «fix» you need to move down, move up if you have to click on a checkbox.
The patch is worse than the bug for the user experience
gabrieljenik

gabrieljenik

2023-04-27 15:30

manager   ~74700

I think major changes are not worth it as the system itself on the backend is not responsive.
Look forward to @mazi directions
gabrieljenik

gabrieljenik

2023-04-27 15:51

manager   ~74705

Seem best solutiin is to create a new css class for max-with of dialog in little screen ?

I will do this.
tibor.pacalat

tibor.pacalat

2023-05-09 14:48

administrator   ~74895

Merged
guest

guest

2023-05-09 15:05

viewer   ~74896

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34637
guest

guest

2023-05-09 15:05

viewer   ~74897

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34638

Related Changesets

LimeSurvey: 5.x 2e18fa69

2023-05-09 16:47

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 17560: Layout issue when setting user rights. (#3074)

* Fixed issue 17560: Layout issue when setting user rights.

Scroll added to table using Bootstrap 3 classes.

* Fixed issue 17560: Layout issue when setting user rights

* Fixed issue 17560: Layout issue when setting user rights.

Css styles added to class modal-lg to show modal wider.

* Fixed issue 17560: Layout issue when setting user rights.

Css class to make dialogs wider added.

* Fixed issue 17560: Layout issue when setting user rights.

Assets rebuilt after merge.

---------

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
17560
mod - application/models/User.php Diff File
mod - application/views/userManagement/partial/editpermissions.php Diff File
mod - assets/packages/adminbasics/build/adminbasics.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.min.css Diff File
mod - assets/packages/adminbasics/scss/000-lime-admin-common.scss Diff File

LimeSurvey: 5.x 2e18fa69

2023-05-09 16:47

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 17560: Layout issue when setting user rights. (#3074)

* Fixed issue 17560: Layout issue when setting user rights.

Scroll added to table using Bootstrap 3 classes.

* Fixed issue 17560: Layout issue when setting user rights

* Fixed issue 17560: Layout issue when setting user rights.

Css styles added to class modal-lg to show modal wider.

* Fixed issue 17560: Layout issue when setting user rights.

Css class to make dialogs wider added.

* Fixed issue 17560: Layout issue when setting user rights.

Assets rebuilt after merge.

---------

Co-authored-by: Lapiu Dev <devgit@lapiu.biz>		 Affected Issues
17560
mod - application/models/User.php Diff File
mod - application/views/userManagement/partial/editpermissions.php Diff File
mod - assets/packages/adminbasics/build/adminbasics.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.min.css Diff File
mod - assets/packages/adminbasics/scss/000-lime-admin-common.scss Diff File

Issue History

Date Modified Username Field Change
2021-09-01 12:46 Mazi New Issue
2021-09-01 12:46 Mazi File Added: image.png
2021-09-01 15:07 galads Note Added: 66259
2021-09-01 15:07 galads Bug heat 0 => 2
2021-09-01 15:11 galads Note Added: 66260
2021-09-01 15:11 galads Assigned To => galads
2021-09-01 15:11 galads Status new => confirmed
2021-09-01 17:04 ollehar Note Added: 66269
2021-09-01 17:04 ollehar Bug heat 2 => 4
2023-04-11 12:24 Mazi Note Added: 74460
2023-04-11 12:24 Mazi Bug heat 4 => 6
2023-04-11 13:10 ollehar Assigned To galads => gabrieljenik
2023-04-11 13:10 ollehar Priority none => normal
2023-04-24 17:52 gabrieljenik Note Added: 74615
2023-04-24 17:52 gabrieljenik Bug heat 6 => 8
2023-04-24 17:55 tibor.pacalat Note Added: 74616
2023-04-24 17:55 tibor.pacalat Bug heat 8 => 10
2023-04-24 22:26 Mazi Note Added: 74623
2023-04-26 20:24 gabrieljenik Note Added: 74663
2023-04-26 20:24 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-04-26 20:24 gabrieljenik Status confirmed => ready for code review
2023-04-27 07:34 DenisChenu Note Added: 74667
2023-04-27 07:34 DenisChenu Bug heat 10 => 12
2023-04-27 07:44 DenisChenu Note Added: 74668
2023-04-27 07:44 DenisChenu File Added: Bad-UX.gif
2023-04-27 07:44 DenisChenu File Added: Dialog-100%width.gif
2023-04-27 07:44 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-04-27 07:44 DenisChenu Status ready for code review => in code review
2023-04-27 14:35 gabrieljenik Note Added: 74687
2023-04-27 14:36 gabrieljenik Note Added: 74688
2023-04-27 15:00 DenisChenu Note Added: 74689
2023-04-27 15:30 gabrieljenik Note Added: 74700
2023-04-27 15:51 gabrieljenik Note Added: 74705
2023-05-05 22:14 gabrieljenik Status in code review => in testing
2023-05-09 14:38 gabrieljenik Assigned To gabrieljenik => tibor.pacalat
2023-05-09 14:38 gabrieljenik Status in testing => ready for merge
2023-05-09 14:48 tibor.pacalat Status ready for merge => closed
2023-05-09 14:48 tibor.pacalat Resolution open => fixed
2023-05-09 14:48 tibor.pacalat Note Added: 74895
2023-05-09 15:05 Changeset attached => LimeSurvey 5.x 2e18fa69
2023-05-09 15:05 Changeset attached => LimeSurvey 5.x 2e18fa69
2023-05-09 15:05 guest Note Added: 74896
2023-05-09 15:05 guest Note Added: 74897
2023-05-09 15:05 guest Bug heat 12 => 14
2023-05-09 15:05 guest Bug heat 12 => 14