View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 2 person(s).
 20
IDProjectCategoryView StatusDate SubmittedLast Update
17486Bug reportsSurvey takingpublic2021-07-30 22:132023-02-14 10:49
Reportergabrieljenik Assigned Toc_schmitz  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version3.22.25 
Summary17486: Current Page Values not saved if saving pressing Enter
Description

1) You complete the third page and press "Resume later"
2) The answers from that page are saved.
3) The form to enter username and password appears. You fill them out and send them pressing ENTER.
4) The responses on that page, that were previously saved, are ERASED.
Only the vaues on the last page are erased, not all of the prior pages.

Additional Information

We thisnk this is because the movenext value is sent empty in the post.

TagsNo tags attached.
Bug heat20
Complete LimeSurvey version number (& build)Version 3.22.25+200706
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMysql
Server OS (if known)Linux
Webserver software & version (if known)
PHP Version7.0.33

Relationships

Relationship GraphDependency Graph
related to 17285 closedgabrieljenik "Resume later" not working after "Load unfinished survey" 

Users monitoring this issue

DenisChenu, Haris.Pap

Activities

Haris.Pap

Haris.Pap

2023-01-26 08:56

reporter   ~73570

Confirmed also for LimeSurvey 5. The saving succeeds if the user presses the button "save now", whereas the answers on the last page get erased if ENTER is pressed
DenisChenu

DenisChenu

2023-01-26 08:59

developer   ~73571

Severity is major here !
gabrieljenik

gabrieljenik

2023-01-31 20:27

manager   ~73625

https://github.com/LimeSurvey/LimeSurvey/pull/2882
DenisChenu

DenisChenu

2023-02-01 09:28

developer   ~73629

The fix must not be a JS fix only …

Adding an hidden move input can fix the issue maybe ?
DenisChenu

DenisChenu

2023-02-01 09:32

developer   ~73630

We check the default move action : https://github.com/LimeSurvey/LimeSurvey/blob/e8716d9e6e734510340c9f96573684401a0f4f15/themes/survey/vanilla/views/subviews/header/start_form.twig#L71
DenisChenu

DenisChenu

2023-02-01 09:32

developer   ~73631

I can take it, have some idea.
gabrieljenik

gabrieljenik

2023-02-01 13:32

manager   ~73633

The fix must not be a JS fix only …

Why not?

We are applying the same mechanism already present in the survey taking process.
Why is that bad?

I can take it, have some idea.

We put effort on the solution.
Why don't you share your idea?
gabrieljenik

gabrieljenik

2023-02-01 13:39

manager   ~73634

And more : save.twig is a lot replaced by template manager

What do you mean? Can you expand a bit more?
DenisChenu

DenisChenu

2023-02-01 14:32

developer   ~73635

The fix must not be a JS fix only …
Why not?

Because there are a lot of good reason for user to deactivate JS …

We are applying the same mechanism already present in the survey taking process.

Because if you use ENTER without JS in survey : you don't loose data. It's totally different.

Here : you loose current data

Why don't you share your idea?

Adding an hidden input https://github.com/LimeSurvey/LimeSurvey/blob/e8716d9e6e734510340c9f96573684401a0f4f15/themes/survey/vanilla/views/subviews/content/save.twig#L41
To replace the default one : https://github.com/LimeSurvey/LimeSurvey/blob/e8716d9e6e734510340c9f96573684401a0f4f15/themes/survey/vanilla/views/subviews/header/start_form.twig#L71

And more : save.twig is a lot replaced by template manager
What do you mean? Can you expand a bit more?

If an issue is fixed by updating twig file, then : any extended template can still have the issue. But here : i think we don't have solution …

We move more than needed in twig file : https://github.com/LimeSurvey/LimeSurvey/blob/e8716d9e6e734510340c9f96573684401a0f4f15/themes/survey/vanilla/views/subviews/header/start_form.twig need to have more ouit of twig …
gabrieljenik

gabrieljenik

2023-02-01 20:38

manager   ~73639

Will work on it.
Nice Idea :)
gabrieljenik

gabrieljenik

2023-02-03 20:20

manager   ~73667

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34280
gabrieljenik

gabrieljenik

2023-02-03 20:20

manager   ~73668

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34281
LimeBot

LimeBot

2023-02-06 10:38

administrator   ~73692

Fixed in Release 5.6.4+230206
gabrieljenik

gabrieljenik

2023-02-06 15:48

manager   ~73697

New PR: https://github.com/LimeSurvey/LimeSurvey/pull/2889
DenisChenu

DenisChenu

2023-02-06 16:02

developer   ~73701

Great !
Fix is OK even if save.twig file was updated !

Really great !

Not necessary : but i think default action can be saveall ?
gabrieljenik

gabrieljenik

2023-02-06 16:45

manager   ~73704

Not necessary : but i think default action can be saveall ?

I wouldn't update it now. The less we update, the better when bug fixing.
If there is a related bug we can test and fix, then yes. But if not, we wouldn't be seeing what's the effect of the code added and we could be braking other stuff
DenisChenu

DenisChenu

2023-02-08 13:44

developer   ~73730

If there is a related bug we can test and fix, then yes

I can report a ergonomy bug after this was fixed …
gabrieljenik

gabrieljenik

2023-02-08 15:15

manager   ~73731

I think thats the best

Thanks
guest

guest

2023-02-09 13:43

viewer   ~73774

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34299
LimeBot

LimeBot

2023-02-14 10:49

administrator   ~73818

Fixed in Release 5.6.5+230214

Related Changesets

LimeSurvey: master a78a5a54

2023-02-03 21:18

gabrieljenik


Details Diff		 Fixed issue 17486: Current Page Values not saved if saving pressing Enter Affected Issues
17486
mod - application/helpers/SurveyRuntimeHelper.php Diff File

LimeSurvey: master 1d7c10e9

2023-02-03 21:20

gabrieljenik


Details Diff		 Revert "Fixed issue 17486: Current Page Values not saved if saving pressing Enter"

This reverts commit a78a5a5466f8c1d71b7e59ff03099147b2460365.		 Affected Issues
17486
mod - application/helpers/SurveyRuntimeHelper.php Diff File

LimeSurvey: master 096476f6

2023-02-09 14:43

Gabriel Jenik

Committer: GitHub


Details Diff		 Fixed issue 17486: Current Page Values not saved if saving pressing Enter (#2889) Affected Issues
17486
mod - application/helpers/SurveyRuntimeHelper.php Diff File

Issue History

Date Modified Username Field Change
2021-07-30 22:13 gabrieljenik New Issue
2021-07-30 22:13 gabrieljenik Status new => assigned
2021-07-30 22:13 gabrieljenik Assigned To => gabrieljenik
2021-07-30 22:13 gabrieljenik Issue generated from: 17285
2021-07-30 22:13 gabrieljenik Relationship added related to 17285
2023-01-26 08:54 Haris.Pap Issue Monitored: Haris.Pap
2023-01-26 08:54 Haris.Pap Bug heat 0 => 8
2023-01-26 08:56 Haris.Pap Note Added: 73570
2023-01-26 08:56 Haris.Pap Bug heat 8 => 10
2023-01-26 08:58 DenisChenu Issue Monitored: DenisChenu
2023-01-26 08:58 DenisChenu Bug heat 10 => 12
2023-01-26 08:59 DenisChenu Note Added: 73571
2023-01-26 08:59 DenisChenu Bug heat 12 => 14
2023-01-26 08:59 DenisChenu Severity minor => partial_block
2023-01-31 20:27 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-01-31 20:27 gabrieljenik Status assigned => ready for code review
2023-01-31 20:27 gabrieljenik Note Added: 73625
2023-01-31 20:27 gabrieljenik Bug heat 14 => 16
2023-02-01 09:28 DenisChenu Note Added: 73629
2023-02-01 09:32 DenisChenu Note Added: 73630
2023-02-01 09:32 DenisChenu Note Added: 73631
2023-02-01 13:32 gabrieljenik Note Added: 73633
2023-02-01 13:39 gabrieljenik Note Added: 73634
2023-02-01 14:32 DenisChenu Note Added: 73635
2023-02-01 20:38 gabrieljenik Note Added: 73639
2023-02-03 20:20 gabrieljenik Changeset attached => LimeSurvey master a78a5a54
2023-02-03 20:20 gabrieljenik Note Added: 73667
2023-02-03 20:20 gabrieljenik Assigned To DenisChenu => gabrieljenik
2023-02-03 20:20 gabrieljenik Resolution open => fixed
2023-02-03 20:20 gabrieljenik Changeset attached => LimeSurvey master 1d7c10e9
2023-02-03 20:20 gabrieljenik Note Added: 73668
2023-02-06 10:38 LimeBot Note Added: 73692
2023-02-06 10:38 LimeBot Status ready for code review => closed
2023-02-06 10:38 LimeBot Bug heat 16 => 18
2023-02-06 15:48 gabrieljenik Note Added: 73697
2023-02-06 15:52 gabrieljenik Assigned To gabrieljenik => DenisChenu
2023-02-06 15:52 gabrieljenik Status closed => ready for code review
2023-02-06 16:02 DenisChenu Assigned To DenisChenu =>
2023-02-06 16:02 DenisChenu Status ready for code review => ready for testing
2023-02-06 16:02 DenisChenu Note Added: 73701
2023-02-06 16:45 gabrieljenik Note Added: 73704
2023-02-08 13:44 DenisChenu Note Added: 73730
2023-02-08 15:15 gabrieljenik Note Added: 73731
2023-02-09 13:43 Changeset attached => LimeSurvey master 096476f6
2023-02-09 13:43 guest Note Added: 73774
2023-02-09 13:43 guest Bug heat 18 => 20
2023-02-09 13:43 c_schmitz Assigned To => c_schmitz
2023-02-09 13:43 c_schmitz Status ready for testing => resolved
2023-02-14 10:49 LimeBot Note Added: 73818
2023-02-14 10:49 LimeBot Status resolved => closed