View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
17330 | Bug reports | Question editor | public | 2021-05-27 18:35 | 2021-08-12 08:46 |
Reporter | marcgold | Assigned To | gabrieljenik | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.25.20 | ||||
Summary | 17330: Ranking Question Issue | ||||
Description | When setting max number of answers on a Ranking questions and setting the question to mandatory you cannot proceed. Error, You have to rank all options. | ||||
Steps To Reproduce | Create a Mandatory Ranking Question | ||||
Tags | No tags attached. | ||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | Version 3.27.0+210525 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | any | ||||
Database type & version | n/a | ||||
Server OS (if known) | Centos 8 | ||||
Webserver software & version (if known) | |||||
PHP Version | 7.3 | ||||
How should the Ranking question behave? Then that number of options to be ranked can be updated using max? Am I right? |
|
Hi Gabriel Thanks for picking this up. IMHO a mandatory question is one that "Must" receive a response in order to proceed. However I believe that any conditions / sub options that are also set need to be respected. For the purposes of the example it is assumed there are 4+ SubQuestions in the Ranking Question: So for instance, in the ranking question that is mandatory and has the MIN (blank) AND MAX 3 answers then the behaviour should be:
However in the event that MIN == 3 & MAX == 3 then user must rank 3 SQ's to continue. To me this is logical. However currently if you set a MAX value less than the total number of SQ's and Mandatory is on then it is not possible to complete the ranking question. Hence you have to turn Mandatory off which means you risk a question being skipped. I hope that all makes sense, but reply if anything is not clear. Thanks Marc |
|
Yes, I think the issue here is that mandatory is making all SQ to be ranked, while it should be, at least 1. So, I would do, |
|
That would work assuming it didn't interfere with the options. |
|
Let me rephrase that last comment. That would work assuming it didn't interfere with the options. But I suppose, if Mandatory was set and that condition was satisfied by selecting one choice, if the option Min 3 was set then it would trigger the error condition around the option. |
|
@c_schmitz, what do you think about this? |
|
I agree to the concept of making a smaller change, to not break BC. |
|
Maybe Fredrik has an opinion too? Will ping him. |
|
@f_funke ? |
|
Fredrik is on vacation this week. |
|
I could reproduce the issue with 5.0.4. The behavior illustrates a general flaw of LimeSurvey, which also affects other question types like multiple choice. Currently, logical rules implicitly make a question mandatory. So if minimum or maximum answers are set in the logic section a question has to be answered to proceed in the questionnaire. But sometimes a survey researcher just wants to communicate how answers should be ideally answered while allowing the respondent not to comply with these instructions (in paper and pencil questionnaires respondents can neglect instructions, too). I'd prefer to disentangle the option for making a question mandatory and the question logic and suggest the following general behavior:
The independent combination of mandatory and logic gives researchers most flexibility: Currently, only cases 1 and 2 are implemented in LimeSurvey. Case 3 and case 4 most probably mean a bigger change without backward compatibility. But in my eyes, this would make LimeSurvey more versatile. |
|
Additional remark on min and max answers: I think that it would be better to update the wording for case 4: "Please select exactly n answers" |
|
So @f_funke, we can apply the change suggested here? I would apply it and then review how the system reacts and compare it to your notes. |
|
Sounds good to me. Also to @c_schmitz? |
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1941 Finally, we made changes for this behaviour: Mandatory Validation
It is not exactly how Fredrik wanted as mandatory validations and max/min validations are separate processes. Still, there is a case in which redundant messages appear. When
In this case, two messages will appear:
|
|
I still didn't understand : it's a conceptual logical issue … I can report an issue on numeric question type where i put min to 10 and max to 5 ? |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32185 |
|
PR for Master: https://github.com/LimeSurvey/LimeSurvey/pull/1966 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32304 |
|
LimeSurvey: 3.x-LTS 50d949a4 2021-07-13 18:09 Committer: GitHub Details Diff |
Fixed issue 17330: Ranking Question issue with mandatory setting (#1941) |
Affected Issues 17330 |
|
mod - application/helpers/expressions/em_manager_helper.php | Diff File | ||
LimeSurvey: master 203ea3ed 2021-07-14 23:55 Committer: GitHub Details Diff |
Fixed issue 17330: Ranking question mandatory validation is confusing (#1966) |
Affected Issues 17330 |
|
mod - application/helpers/expressions/em_manager_helper.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2021-05-27 18:35 | marcgold | New Issue | |
2021-05-28 15:36 | gabrieljenik | Assigned To | => gabrieljenik |
2021-05-28 15:36 | gabrieljenik | Status | new => assigned |
2021-05-28 15:38 | gabrieljenik | Assigned To | gabrieljenik => |
2021-05-28 15:38 | gabrieljenik | Assigned To | => gabrieljenik |
2021-05-31 15:46 | gabrieljenik | Note Added: 64678 | |
2021-06-01 10:11 | marcgold | Note Added: 64683 | |
2021-06-01 14:53 | gabrieljenik | Note Added: 64688 | |
2021-06-01 20:02 | marcgold | Note Added: 64697 | |
2021-06-01 20:35 | marcgold | Note Added: 64699 | |
2021-06-07 20:49 | gabrieljenik | Note Added: 64774 | |
2021-06-08 23:07 | gabrieljenik | Sync to Zoho Project | => |Yes| |
2021-06-09 11:54 | ollehar | Note Added: 64792 | |
2021-06-09 11:55 | ollehar | Note Added: 64793 | |
2021-06-14 17:03 | gabrieljenik | Note Added: 64896 | |
2021-06-14 17:03 | ollehar | Note Added: 64897 | |
2021-06-23 13:28 | f_funke | Note Added: 65008 | |
2021-06-23 13:28 | f_funke | Note Added: 65009 | |
2021-06-23 16:21 | gabrieljenik | Note Added: 65019 | |
2021-06-24 11:43 | f_funke | Note Added: 65039 | |
2021-06-24 11:44 | f_funke | Note Edited: 65039 | |
2021-07-01 17:45 | gabrieljenik | Note Added: 65191 | |
2021-07-01 18:25 | DenisChenu | Note Added: 65192 | |
2021-07-05 18:14 | gabrieljenik | Status | assigned => ready for testing |
2021-07-13 16:38 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS 50d949a4 |
2021-07-13 16:38 | gabrieljenik | Note Added: 65429 | |
2021-07-13 16:38 | gabrieljenik | Resolution | open => fixed |
2021-07-14 20:24 | gabrieljenik | Note Added: 65444 | |
2021-07-14 21:55 | gabrieljenik | Changeset attached | => LimeSurvey master 203ea3ed |
2021-07-14 21:55 | gabrieljenik | Note Added: 65447 | |
2021-07-14 21:56 | c_schmitz | Status | ready for testing => resolved |
2021-08-12 08:46 | c_schmitz | Status | resolved => closed |