17084: DB upgrade from 3 to 4 fails when DB is PostgreSQL - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

17084	Bug reports	ComfortUpdate	public	2021-02-11 15:43	2021-02-15 22:40

Reporter	zufolo441	Assigned To	ollehar
Priority	high	Severity	block
Status	closed	Resolution	fixed
Product Version	4.4.4

Summary	17084: DB upgrade from 3 to 4 fails when DB is PostgreSQL
Description	application/helpers/update/updatedb_helper.php line 3244 need to be changed from "`name`='{$name}'" to "name='{$name}'"
Tags	No tags attached.

Bug heat	10
Complete LimeSurvey version number (& build)	4.4.6
I will donate to the project if issue is resolved	No
Browser
Database type & version	PostgreSQL 11.9
Server OS (if known)	BSD 12.2
Webserver software & version (if known)
PHP Version	7.1.33

User List	There are no users monitoring this issue.

DenisChenu 2021-02-11 15:48 developer ~62171 Last edited: 2021-02-11 15:48	Yep, Clearly an issue here … Can you make a pull request ?

gabrieljenik 2021-02-11 16:10 manager ~62174	Backslashes are creating trouble on Postgre?

zufolo441 2021-02-11 16:16 reporter ~62176	Backslashes are not supported in PGSQL. If the field name needs to be escaped, it has to be surrounded with: "

DenisChenu 2021-02-11 17:10 developer ~62179	backslsh broke in MSSQL too (escape with [ ] if i don't make error) `App()->getDb()->quoteColumnName` is the only way to do if needed

ollehar1 2021-02-11 19:32 reporter ~62193	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31064

lime_release_bot 2021-02-15 22:40 administrator ~62268	Fixed in Release 4.4.7+210215

Date Modified	Username	Field	Change
2021-02-11 15:43	zufolo441	New Issue
2021-02-11 15:48	DenisChenu	Note Added: 62171
2021-02-11 15:48	cdorin	Priority	none => high
2021-02-11 15:48	cdorin	Status	new => confirmed
2021-02-11 15:48	cdorin	Sync to Zoho Project	=> \|Yes\|
2021-02-11 15:48	DenisChenu	Note Edited: 62171
2021-02-11 16:10	gabrieljenik	Note Added: 62174
2021-02-11 16:16	zufolo441	Note Added: 62176
2021-02-11 17:10	DenisChenu	Note Added: 62179
2021-02-11 19:22	ollehar	Severity	minor => block
2021-02-11 19:22	ollehar	Sync to Zoho Project	Yes => \|Yes\|
2021-02-11 19:32	ollehar1	Changeset attached	=> LimeSurvey master b652208a
2021-02-11 19:32	ollehar1	Note Added: 62193
2021-02-11 19:32	ollehar	Assigned To	=> ollehar
2021-02-11 19:32	ollehar	Status	confirmed => resolved
2021-02-11 19:32	ollehar	Resolution	open => fixed
2021-02-15 22:40	lime_release_bot	Sync to Zoho Project	Yes => \|Yes\|
2021-02-15 22:40	lime_release_bot	Note Added: 62268
2021-02-15 22:40	lime_release_bot	Status	resolved => closed

LimeSurvey: master b652208a 2021-02-11 20:32 ollehar1 Details Diff	Fixed issue 17084: DB upgrade from 3 to 4 fails when DB is PostgreSQL		Affected Issues 17084
	mod - application/helpers/update/updatedb_helper.php		Diff File