Strange

I can not reproduce on 4.4.4

Capture d’écran du 2021-02-09 17-57-13.png (53,942 bytes)   

Capture d’écran du 2021-02-09 17-57-13.png (53,942 bytes)   

The check is done here :
https://github.com/LimeSurvey/LimeSurvey/blob/a108ed96640126efd4b9388ffdc409b21646704c/application/core/Survey_Common_Action.php#L166

But !empty($params['iGroupId']) : must return false if gid === "" (empty string)

You have a space in the link ?

Thanks for your (very :-) ) fast processing.

Yes strange as looking to the release notes I haven't seen any line about this.
Although I did not check at the file level.

I plan a (clone + 4.4.3 to 4.4.4 upgrade) tomorrow morning and I'll keep this ticket updated.

Would you suggest any other operation that could help identify where could the problem be on this 4.4.3 version ?

Just before launch popup :

die('«'.$params['iGroupId'].'»');
at line 166 https://github.com/LimeSurvey/LimeSurvey/blob/a108ed96640126efd4b9388ffdc409b21646704c/application/core/Survey_Common_Action.php#L166

Toi check what is gif at this time …

As you may see there's no spaces in the URL, below is a plain cut/paste of the opened URL.
Both GID and QID are empty.

https://hub.imt-atlantique.fr/limesurvey/index.php/admin/htmleditor_pop/sa/index/name/subquestions[16134][0][subquestionl10n][fr]/text/[Answer:](fr)/type/editanswer/action/editanswer/sid/475812/gid//qid//lang/fr

Yes : don't understand …

I've cloned the entire platform and applied the 4.4.4 version.
No changes : the problem is still there.
I'm currently hacking to see wether if the information is missing in the TWIG or is forgottent further in the process.

Debug mode : https://manual.limesurvey.org/Debug_mode

then we know exactly where it happen

I've hacked the /application/views/questionAdministration/subquestionRow.twig
Screenshot #1
Result on screenshot #2

It appears there's at least 1 error in the original subquestionRow.twig as the gid parm should be replaced by question.gid (mark #1 on screenshot #1).
the regexp check (mark #2) seems to be OK.

But it still does not make the trick : the parms are present at the twig level and get erased during the processing

Selection_964.png (76,133 bytes)   

Selection_964.png (76,133 bytes)   

Please : debug mode …

Hacking application//helpers/admin/htmleditor_helper.php as in screen shot #1
I've discovered that the change in the javascript:start_popup_editor call intervenes AFTER the PHP generation in htmleditor_helper.php
Displaying the href parms in an HTML comment shows unaffected gID en qID parameters (mark #1) but the actual parameters (mark #2) are empty.
Very strange.

=> is there somewhere a routine rewriting "A HREF='javascript..." either on $htmlcode at the PHP level of after in the DOM at a JS level ?

Unfortunately I'm totally limesurvey-dev-model blind and I think I can't go further debugging this...

Please : debug mode … …
Activate : and show the new html-editor-popup-403.png …

https://manual.limesurvey.org/Debug_mode

Hi,
attached the 403 screenshot in 2 parts with debug=1
Also attached the corresponding URL

Selection_972.png (90,339 bytes)   

Selection_972.png (90,339 bytes)   

OK … !empty($params['iGroupId']) return false confirmed …

But HOW this can happen !!!

Is set here : https://github.com/LimeSurvey/LimeSurvey/blob/a108ed96640126efd4b9388ffdc409b21646704c/application/core/Survey_Common_Action.php#L161

But only if qid is set (and not the case here)

Can you check in DB if you have some empty gid ? Some question with gid === null ?

As you may see on https://bugs.limesurvey.org/file_download.php?file_id=14383&type=bug sid, gid qns qid are set, it's the calling link javascript:call_popup_editor(... for subquestion.qid=16138 on the question editor form index.php/questionAdministration/view/surveyid/978456/gid/58/qid/16136 that misses the correct parms

This link is apparently rewritten somewhere as it seems to be correct from the PHP generation function

Anyway, DB coherence check is fine and I could no find any question see screenshot ttached

Selection_974.png (47,502 bytes)   

Selection_974.png (47,502 bytes)   

Are set to an empty string then empty($params['iGroupId']) == empty($params['iQuestionId']) == true

See https://www.php.net/manual/en/function.empty.php

Don't care aboit gid//qid// …

Found the rewrite origin, my guess is : this is done in javascript.

There's somewhere a rewrite based on <A class=editorLink which erase the gid and qid parameters to the popup.
Disabling the editorLink class (actually renaming it to VOIDeditorLink) ensure the call_editor_popup gets the correct parameters
This can't be a clean solution.

I suppose the rewrite function to be updateRowProperties() in ./assets/scripts/admin/questionEditor.js ScreenShot #1

It can't find the input[name=gid] and the input[name=qid] (returns undefined Screenshot #2) and simply clear both parameters in the URL

=>from my point of view both required input[name=gid] and input[name=qid] should be made available to this function updateRowProperties for the popup to work properly.

Selection_975.png (79,607 bytes)   

Selection_975.png (79,607 bytes)   

Selection_976.png (62,330 bytes)   

Selection_976.png (62,330 bytes)   

Any solution for this?

Gabriel didn't fix it some day ago ?

You tell me. xD

I can confirm that this bug is still present in the latest release. Are there any news on this?

We can test some more.

Couldn't reproduce it in master neither in 4.4.3

We have a server that was running an older version of Limesurvey (4.3.15+200907). I turned it back on to check if the error existed in that version and in fact it didn't. But the server running the latest release still has that error. It started with one of the later 4.x versions and still persists with 5.x.

I enabled debug mode and saved the html file containing the error message and stack trace. Does it contain any sensitive information? If not I would just upload the whole html file instead of creating a series of screenshots :)

I enabled debug mode and saved the html file containing the error message and stack trace. Does it contain any sensitive information? If not I would just upload the whole html file instead of creating a series of screenshots :)

I wouldn't know. Sorry, I would say that more than just a path and maybe some names, shouldn't be any password on it.

We did found about some parameters not being sent to the html editor.
Will fix it.

Still that only impact the replacement feature. Sholdn't cause a 403.
Have you tried clearing the assets?

Thanks

GID and QID were not sent to editor on subquestions, imapcting on replacement fields.
Issue detected while reviewing.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1949

Yes I tried it again after clearing the assets via the button in the global settings menu. The error still persists. I will wait until your branch was merged and then test again.

It is merged, now.

I just installed the update and the error is (almost) fixed. When I add a question (5 point array for example) and try to open the html editor on a subquestion BEFORE clicking on the save button once, I still get the error. Plus, the inline text field next to the button that says sth. like "Example subquestion" turns grey and uneditable afterwards.

But after saving the question at least once, I am not able to reproduce the error anymore.

We couldn't reproduce it.

I tried this:
1) Created an empty survey
2) Added a group
3) Clicked "Add question"
4) Changed the type to "Array (5 point choice)" (I had "Short free text" by default)
5) Clicked on the first subquestion's editor button => It worked
6) Added a new subquestion
7) Clicked on the new subquestion's editor button => It worked too

Can I ask you to send some kind of screenshots (showing the full screen) or screenrecording (showing the steps?)

As per the comments, will be closing the ticket.
Please add any comments in case it should be reopened.
Thanks