View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
16909Bug reportsSurvey takingpublic2021-02-01 14:36
Reporterliumingjun Assigned To 
PrioritynoneSeveritytweak 
Status closedResolutionfixed 
Product Version4.3.31 
Summary16909: Slow loading when the questionnaire has a large quota(500+)
Description

Slow loading when the questionnaire has a large quota
ex:quotas 500+

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)4.3.31
I will donate to the project if issue is resolvedNo
Browser
Database type & versionmysql 5.6
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

liumingjun

liumingjun

2020-12-15 11:18

reporter   ~60952

https://github.com/LimeSurvey/LimeSurvey/pull/1692

DenisChenu

DenisChenu

2020-12-16 08:18

developer   ~60974

Last edited: 2020-12-16 08:18

In the Pull request : i understand imiting by language : 500 quota X 4 languages : 2000 quota tested.

But i don't understand $bAllHidden : the purpose is to apply quota only of all questions are hidden. Here it's done if one questio are hidden.

We have a feature request somewhere about a new settings in quota Forced quota : No (never check without POST value) | auto (only if all questios are hidden) | force (Always check quota).

liumingjun

liumingjun

2020-12-24 04:44

reporter   ~61153

eg:
q1:1
q2:1
q5:a

not quota

@DenisChenu

DenisChenu

DenisChenu

2020-12-24 09:43

developer   ~61154

Seems to be an issue : q5 must be in bPostedField .

  1. In my opinion : it's another issue
  2. I like to check in 3.X if we have same issue
DenisChenu

DenisChenu

2020-12-24 13:11

developer   ~61158

Last edited: 2020-12-24 13:11

No issue : when q5 is in $_POST value hq4 is not set.

The 2 question can be hidden, quota is checked if all question are hidden or when one question is in submitted page.

Update this can broken existing survey

See discussion about such feature (quota enforced even if no $_POST) here : https://bugs.limesurvey.org/view.php?id=11597#c40585

Maybe just
0 => disable
1 => default ($_POST or all hidden)
2 => forced : do it at each page even if not post or hidden

liumingjun

liumingjun

2020-12-25 03:12

reporter   ~61162

But on 4.3, I did not find the setting you mentioned

DenisChenu

DenisChenu

2020-12-26 14:32

developer   ~61167

It not exist : it a new feature candidate.

DenisChenu

DenisChenu

2020-12-27 13:05

developer   ~61170

https://bugs.limesurvey.org/view.php?id=16925

guest

guest

2021-02-01 11:09

viewer   ~61835

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30975

lime_release_bot

lime_release_bot

2021-02-01 14:36

administrator   ~61841

Fixed in Release 4.4.1+210201

Related Changesets

LimeSurvey: master 60874864

2021-02-01 12:09

liumingjun

Committer: GitHub


Details Diff
Fixed issue 16909: Slow loading when the questionnaire has a large number of quotas (500+) (#1692)

Dev Co-authored-by: liumingjun <liumingjun@data100.com.cn>
Affected Issues
16909
mod - application/helpers/frontend_helper.php Diff File

Issue History

Date Modified Username Field Change
2020-12-15 11:14 liumingjun New Issue
2020-12-15 11:18 liumingjun Note Added: 60952
2020-12-16 08:18 DenisChenu Note Added: 60974
2020-12-16 08:18 DenisChenu Note Edited: 60974
2020-12-24 04:44 liumingjun Note Added: 61153
2020-12-24 04:44 liumingjun File Added: limesurvey_survey_682653.lss
2020-12-24 09:43 DenisChenu Note Added: 61154
2020-12-24 13:11 DenisChenu Note Added: 61158
2020-12-24 13:11 DenisChenu Note Edited: 61158
2020-12-25 03:12 liumingjun Note Added: 61162
2020-12-26 14:32 DenisChenu Note Added: 61167
2020-12-27 13:05 DenisChenu Note Added: 61170
2021-02-01 11:09 liumingjun Changeset attached => LimeSurvey master 60874864
2021-02-01 11:09 guest Note Added: 61835
2021-02-01 14:36 lime_release_bot Note Added: 61841
2021-02-01 14:36 lime_release_bot Status new => closed
2021-02-01 14:36 lime_release_bot Resolution open => fixed