Hello Denis - I am not sure if I understand how to reproduce it - could you please provide more info about it?

You have to update your config.php file

        'debug'=>2,
        'debugsql'=>0, // Set this to 1 to enanble sql logging, only active when debug = 2
        'publicurl' => 'https://limesurvey.org/limesurvey',

https://manual.limesurvey.org/Optional_settings#Advanced_path_settings

This settings is available in config.php and it is used when LimeSurvey need an absolute url (for example when token emails are sent).

You can use the real url or a false.

It's used a lot when there are proxy between internet and limesurvey.

This param muts be used only for sending absoluteurl.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1707

For master this also applied?
What do you think @DenisChenu?

For develop, I believe we should have a central method for resolving the url base.
What do you think @ollehar?

Yes, issue surely in master.

I don't understand why we need to save aboslute URL here ? And how we get the absolute url : seems we don't use same system on both system :

In GUI : we seem to use a methode, but when load another method : we need to use same method.

PS : why don't save path (relative to rootdir) and not url ?

Fixed in master only? (LS4)

Fixed in master only? (LS4)

reported for 3.X

PS : my diff with the fix for windows :

diff --git a/application/controllers/admin/emailtemplates.php b/application/controllers/admin/emailtemplates.php
old mode 100644
new mode 100755
index 21e8b52ad7771b9ed088f3f67e368b216f765c87..06973e94bb9db81247f86532616a347f1750f446
--- a/application/controllers/admin/emailtemplates.php
+++ b/application/controllers/admin/emailtemplates.php
@@ -99,7 +99,7 @@ class emailtemplates extends Survey_Common_Action
      */
     function update($iSurveyId)
     {
-        $uploadUrl = Yii::app()->getBaseUrl(true).substr(Yii::app()->getConfig('uploadurl'), strlen(Yii::app()->getConfig('publicurl')) - 1);
+        $uploadUrl = Yii::app()->getBaseUrl(true).substr(Yii::app()->getConfig('uploadurl'), strlen(rtrim(Yii::app()->getBaseUrl(false))));
         // We need the real path since we check that the resolved file name starts with this path.
         $uploadDir = realpath(Yii::app()->getConfig('uploaddir'));
         $sSaveMethod = Yii::app()->request->getPost('save', '');
@@ -112,7 +112,8 @@ class emailtemplates extends Survey_Common_Action
                     foreach ($_POST['attachments'][$langname] as $template => &$attachments) {
                         foreach ($attachments as  $index => &$attachment) {
                             // We again take the real path.
-                            $localName = realpath(urldecode(str_replace($uploadUrl, $uploadDir, $attachment['url'])));
+                           $check = str_replace("/",DIRECTORY_SEPARATOR, urldecode(str_replace($uploadUrl, $uploadDir, $attachment['url'])));
+                            $localName = realpath($check);
                             if ($localName !== false) {
                                 if (strpos($localName, $uploadDir) === 0) {
                                     $attachment['url'] = $localName;
diff --git a/application/views/admin/emailtemplates/email_language_template_tab.php b/application/views/admin/emailtemplates/email_language_template_tab.php
old mode 100644
new mode 100755
index 48f5c42169b11e67dc6165d66c836ad32f26732c..430873ce7bd6f55628dc65b5330164ca6d4c92d8
--- a/application/views/admin/emailtemplates/email_language_template_tab.php
+++ b/application/views/admin/emailtemplates/email_language_template_tab.php
@@ -64,7 +64,7 @@ $script = array();
     $hideAttacehemtTable = true;
     if (isset($esrow->attachments[$tab])) {
         foreach ($esrow->attachments[$tab] as $attachment) {
-            $script[] = sprintf("prepEmailTemplates.addAttachment($('#attachments-%s-%s'), %s, %s, %s );", $grouplang, $tab, json_encode($attachment['url']), json_encode($attachment['relevance']), json_encode($attachment['size']));
+            $script[] = sprintf("prepEmailTemplates.addAttachment($('#attachments-%s-%s'), %s, %s, %s );", $grouplang, $tab, '"'.addslashes(addslashes($attachment['url'])).'"', json_encode($attachment['relevance']), json_encode($attachment['size']));
         }
         $hideAttacehemtTable = false;
     }

Better instructions needed on how to reproduce.

1. Set 'publicurl' => 'http://limesurvey.example.org/', in config.php
2. Go to edit email template
3. Click on Add file in Invitation attachments:
4. choose or upload a file
5. Save
6. Check if file is still there.

Maybe next time i make directly the fix … :/

Even if you do the fix yourself we still have to test it.

Remember: We have non-technical people doing QA as well. Instructions need to be clear.

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31316

Fixed in Release 3.25.18+210316