View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
16863Bug reportsSurvey takingpublic2020-12-16 17:19
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version3.25.1 
Summary16863: Multi Numeric Slider custom Font Awesome icons
Description

The custom and Triangle icons do not work for slider type multi numeric type K questions

Steps To Reproduce

Multinumeric number slider
anything other than circle doesn't work.
using Fruty theme (extended)

Additional Information

Not sure if it has to do with spectrum.css and spectrum.js 404 not found errors.

This is a clone from 16308.
That was from LSv4. This ticket is for LSv3

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)Version 3.25
I will donate to the project if issue is resolvedNo
BrowserBrave
Database type & versionMySQL
Server OS (if known)Linux
Webserver software & version (if known)
PHP Version7.x

Relationships

related to 16308 closedgabrieljenik Multi Numeric Slider custom Font Awesome icons 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2020-11-27 08:00

developer   ~60773

It work on SkelVanilla currently … hope fix don't break it ;)

gabrieljenik

gabrieljenik

2020-11-28 17:41

manager   ~60791

Are you sure? Can you show me how you configured it to make it work?
We have tested with Skel and doesn;t work

DenisChenu

DenisChenu

2020-11-29 11:43

developer   ~60793

Sorry : you'r right : f004 (hearth) didn't work, even with \ or \ …

Only star work because was the default set via CSS file …

gabrieljenik

gabrieljenik

2020-12-03 20:14

manager   ~60833

https://github.com/LimeSurvey/LimeSurvey/pull/1680

gabrieljenik

gabrieljenik

2020-12-12 15:07

manager   ~60937

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30793

lime_release_bot

lime_release_bot

2020-12-16 17:19

administrator   ~60990

Fixed in Release 3.25.4+201215

Related Changesets

LimeSurvey: 3.x-LTS b43652b3

2020-12-12 16:07

gabrieljenik

Committer: GitHub


Details Diff
Fixed issue 16863: Multi Numeric Slider custom Font Awesome icons (#1680)

There were several problems:
- numeric-slider.js set the CSS for the custom slider handle, but it used a wrong selector.
- numeric-slider.js set the content to the unicode value directly, without using backslash.
- In the case of Fruity, it was setting the slider handle's background color, which works for 'round' and 'square' but not for 'triangle' and 'custom'. Fixed by adding this rule to all variations: .fruity .slider-handle.custom,.fruity .slider-handle.triangle{background-color:transparent}
Affected Issues
16863
mod - application/views/survey/questions/answer/multiplenumeric/rows/sliders/answer_row.twig Diff File
mod - assets/packages/questions/numeric-slider/scripts/numeric-slider.js Diff File
mod - themes/survey/bootswatch/css/theme.css Diff File
mod - themes/survey/fruity/css/theme.css Diff File
mod - themes/survey/fruity/css/variations/apple_blossom.css Diff File
mod - themes/survey/fruity/css/variations/bay_of_many.css Diff File
mod - themes/survey/fruity/css/variations/black_pearl.css Diff File
mod - themes/survey/fruity/css/variations/free_magenta.css Diff File
mod - themes/survey/fruity/css/variations/purple_tentacle.css Diff File
mod - themes/survey/fruity/css/variations/sea_green.css Diff File
mod - themes/survey/fruity/css/variations/skyline_blue.css Diff File
mod - themes/survey/fruity/css/variations/sunset_orange.css Diff File
mod - themes/survey/vanilla/css/theme.css Diff File

Issue History

Date Modified Username Field Change
2020-11-26 20:25 gabrieljenik New Issue
2020-11-26 20:25 gabrieljenik Status new => assigned
2020-11-26 20:25 gabrieljenik Assigned To => gabrieljenik
2020-11-26 20:25 gabrieljenik Issue generated from: 16308
2020-11-26 20:25 gabrieljenik Relationship added related to 16308
2020-11-27 08:00 DenisChenu Note Added: 60773
2020-11-28 17:41 gabrieljenik Note Added: 60791
2020-11-29 11:43 DenisChenu Note Added: 60793
2020-12-03 20:14 gabrieljenik Note Added: 60833
2020-12-12 15:07 gabrieljenik Changeset attached => LimeSurvey 3.x-LTS b43652b3
2020-12-12 15:07 gabrieljenik Note Added: 60937
2020-12-12 15:07 gabrieljenik Resolution open => fixed
2020-12-16 17:19 lime_release_bot Note Added: 60990
2020-12-16 17:19 lime_release_bot Status assigned => closed