View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 16760 | Bug reports | Other | public | 2020-10-20 09:32 | 2026-11-19 22:21 |
| Reporter | JHoeck | Assigned To | JHoeck | ||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Summary | 16760: Qanda Refactoring | ||||
| Description | At the moment we are thinking about refactoring the qanda helper. We noticed following issues:
| ||||
| Tags | No tags attached. | ||||
| Bug heat | 6 | ||||
| Complete LimeSurvey version number (& build) | - | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | |||||
| Database type & version | - | ||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | - | ||||
| Git branch / Pull Request URL | |||||
| related to | 16772 | closed | gabrieljenik | Allow plugin to add question attributes |
|
Some qanda_helper function was already replaced by core/QuestionType … Then : in my opinion : no need to rewrite qanda_helper : just create all core questiontype … Some coire question type just load current qanda function, some other have been rewritten |
|
|
PS : since it's not «really» a bug, can we move it to Devlopment section ? |
|
|
Moved to dev. |
|
|
We can move do_render() to question types, but later we should really create a proper module structure for each question. |
|
The current one is not OK ? |
|
|
It's not OK, no. 1) Missing config. Ask yourself this: Is it possible to add a new question type without touching old code? When yes, we have a good structure. :D Then we can also allow question types as a zip file upload, as with plugins. |
|
|
lol … Then do a lot of thing for … nothing … ? I ask to have REAL way to do something by external system since years now … |
|
|
I started some work on this my first year (on my free time), but it got shut down. Eventually we'll have to return to it, together. https://manual.limesurvey.org/Question_object_types
Hopefully it's a step in the right direction. :) |
|
|
Mission 1: Move do_<question> to renderer object. Example: RenderArray10ChoiceQuestion calls do_array_10point from qanda, but qanda should be moved to this class instead. And the same for all question types. If we want to make $ia more descriptive, we can create a wrapper class for it and |
|
|
Yes, some do_ are deprecated, i add the @deprecated when i see it But : this issue is about moving do_… part to the Render… part or it's another things ? |
|
Mainly this, right now. Maybe we'll create subtasks later. |
|
|
OK :) Great (need DB definition better than current one) |
|
|
The agreed first step of this task (moving the do_<question> functions out of qanda_helper into the renderer classes in application/core/QuestionTypes) is done in LimeSurvey 7, and qanda_helper now only holds a few shared helpers. Closing as fixed. |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2020-10-20 09:32 | JHoeck | New Issue | |
| 2020-10-20 09:32 | JHoeck | Status | new => assigned |
| 2020-10-20 09:32 | JHoeck | Assigned To | => JHoeck |
| 2020-10-20 09:50 | DenisChenu | Note Added: 60285 | |
| 2020-10-20 09:51 | DenisChenu | Note Added: 60286 | |
| 2020-10-20 10:08 | ollehar | Project | Bug reports => @10@ |
| 2020-10-20 10:08 | ollehar | Note Added: 60287 | |
| 2020-10-20 10:09 | ollehar | Note Added: 60288 | |
| 2020-10-20 10:20 | DenisChenu | Note Added: 60291 | |
| 2020-10-20 10:25 | ollehar | Note Added: 60293 | |
| 2020-10-20 10:25 | ollehar | Note Edited: 60293 | |
| 2020-10-20 10:26 | ollehar | Note Edited: 60293 | |
| 2020-10-20 10:26 | DenisChenu | Note Added: 60294 | |
| 2020-10-20 10:26 | ollehar | Note Edited: 60293 | |
| 2020-10-20 10:28 | ollehar | Note Added: 60295 | |
| 2020-10-21 11:29 | ollehar | Note Added: 60330 | |
| 2020-10-21 11:30 | ollehar | Note Edited: 60330 | |
| 2020-10-21 12:42 | DenisChenu | Note Added: 60331 | |
| 2020-10-21 14:25 | ollehar | Note Added: 60333 | |
| 2020-10-21 14:42 | DenisChenu | Note Added: 60334 | |
| 2020-10-21 19:04 | DenisChenu | Relationship added | related to 16772 |
| 2026-11-19 22:21 | c_schmitz | Note Added: 87661 | |
| 2026-11-19 22:21 | c_schmitz | Bug heat | 4 => 6 |
| 2026-11-19 22:21 | c_schmitz | Status | assigned => closed |
| 2026-11-19 22:21 | c_schmitz | Resolution | open => fixed |