16635: Timer not working when survey is active (when executing the survey multiple times in the same browser/tab)

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16635	Bug reports	Other	public	2020-09-02 18:09	2020-10-05 08:34

Reporter	MeirOverferst	Assigned To	gabrieljenik
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	4.3.14

Summary	16635: Timer not working when survey is active (when executing the survey multiple times in the same browser/tab)
Description	Timer not working when survey is active (when executing the survey multiple times in the same browser/tab)
Steps To Reproduce	Please import the survey and check it
Tags	No tags attached.
Attached Files	limesurvey_survey_336813.lss (15,713 bytes)

Bug heat	4
Complete LimeSurvey version number (& build)	irrelevant
I will donate to the project if issue is resolved	No
Browser
Database type & version	irrelevant
Server OS (if known)
Webserver software & version (if known)
PHP Version	irrelevant

User List	There are no users monitoring this issue.

gabrieljenik 2020-09-15 01:48 manager ~59801	PR: https://github.com/LimeSurvey/LimeSurvey/pull/1592 Each timer registers itself in a local storage item identified by the Survey ID. This is used by the reset function to know which timers belong to the survey and are to be reset. The reset method was replaced by a function (in survey.js instead of timer.js) that reset all timers for a given survey. Also reviewed the reset method for preview mode.

gabrieljenik 2020-09-29 08:25 manager ~59975	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30524

lime_release_bot 2020-10-05 08:34 administrator ~60064	Fixed in Release 4.3.19+201005

LimeSurvey: master 89f54caf 2020-09-29 10:25 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16635: Timer not working when survey is active (when executing the survey multiple times in the same browser/tab) (#1592) Each timer registers itself in a local storage item identified by the Survey ID. This is used by the reset function to know which timers belong to the survey and are to be reset. The reset method was replaced by a function (in survey.js instead of timer.js) that reset all timers for a given survey. Also reviewed the reset method for preview mode.	Affected Issues 16635
	mod - application/controllers/survey/index.php	Diff File
	mod - application/helpers/frontend_helper.php	Diff File
	mod - application/helpers/qanda_helper.php	Diff File
	mod - application/models/QuestionBaseRenderer.php	Diff File
	mod - application/views/survey/questions/question_timer/timer_footer.php	Diff File
	mod - assets/packages/limesurvey/survey.js	Diff File
	mod - assets/packages/questions/timer/package-lock.json	Diff File
	mod - assets/packages/questions/timer/src/main.js	Diff File
	mod - assets/packages/questions/timer/src/timeclass.js	Diff File
	mod - assets/packages/questions/timer/timer.js	Diff File
	mod - assets/packages/questions/timer/timer.min.js	Diff File

Date Modified	Username	Field	Change
2020-09-02 18:09	MeirOverferst	New Issue
2020-09-02 18:09	MeirOverferst	File Added: limesurvey_survey_336813.lss
2020-09-02 18:10	cdorin	Relationship added	related to 16634
2020-09-02 18:11	cdorin	Assigned To	=> gabrieljenik
2020-09-02 18:11	cdorin	Status	new => assigned
2020-09-02 18:11	cdorin	Steps to Reproduce Updated
2020-09-02 18:11	cdorin	Zoho Sprints	=> \|Yes\|
2020-09-15 01:48	gabrieljenik	Note Added: 59801
2020-09-29 08:25	gabrieljenik	Changeset attached	=> LimeSurvey master 89f54caf
2020-09-29 08:25	gabrieljenik	Note Added: 59975
2020-09-29 08:25	gabrieljenik	Resolution	open => fixed
2020-10-05 08:34	lime_release_bot	Zoho Sprints	Yes => \|Yes\|
2020-10-05 08:34	lime_release_bot	Note Added: 60064
2020-10-05 08:34	lime_release_bot	Status	assigned => closed