View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16507 | Bug reports | Security | public | 2020-07-20 23:08 | 2020-08-20 10:56 |
Reporter | gabrieljenik | Assigned To | gabrieljenik | ||
Priority | normal | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.3.4 | ||||
Summary | 16507: Mass permissions are not being saved | ||||
Description | When setting permissions for multiple users using the mass users, permissions don't get saved. | ||||
Tags | No tags attached. | ||||
Bug heat | 258 | ||||
Complete LimeSurvey version number (& build) | 4.3.4 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | Mysql | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 7 | ||||
This was discovered while reviewing 15749 |
|
If updating permissions for 2 different users, after applying mass permissions:
|
|
|
|
Reworked how custom-data is posted to the controller. Specially on checkboxes (which were always sent as TRUE) The file listActions.js was updated and that could affect other massive action modals as well. |
|
Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, below are my findings: |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30382 |
|
Fixed in Release 4.3.12+200820 |
|
LimeSurvey: master 2819688c 2020-08-18 18:14 Committer: GitHub Details Diff |
Fixed issue 16507: Mass permissions are not being saved (#1546) Dev: Reworked how custom-data is posted to the controller. Specially on checkboxes (which were always sent as TRUE) Dev: Reviewed how checkbox are linked: "general" permission for an activity with the "read"/"update"/"delete"/.... checkboxes. Dev: Reviewed results view |
Affected Issues 16507 |
|
mod - application/controllers/UserManagementController.php | Diff File | ||
mod - application/extensions/admin/grid/MassiveActionsWidget/assets/listActions.js | Diff File | ||
mod - application/views/userManagement/massiveAction/_updatepermissions.php | Diff File | ||
mod - assets/packages/usermanagement/js/usermanagement.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-07-20 23:08 | gabrieljenik | New Issue | |
2020-07-20 23:08 | gabrieljenik | Relationship added | related to 15749 |
2020-07-20 23:08 | gabrieljenik | Note Added: 59002 | |
2020-07-29 22:58 | cdorin | Zoho Sprints | => |Yes| |
2020-07-29 22:58 |
|
Zoho Sprints ID | => 14469000000201049 |
2020-07-29 22:59 | cdorin | Status | new => confirmed |
2020-08-10 19:09 | gabrieljenik | Note Added: 59400 | |
2020-08-10 19:14 | cdorin | Note Added: 59401 | |
2020-08-10 19:16 | cdorin | Priority | none => normal |
2020-08-10 19:16 | cdorin | Zoho Sprints | Yes => |Yes| |
2020-08-11 22:08 | gabrieljenik | Note Added: 59415 | |
2020-08-11 22:08 | gabrieljenik | Note Edited: 59415 | |
2020-08-18 15:57 |
|
Note Added: 59504 | |
2020-08-18 15:57 |
|
File Added: 16507_EditMasspermissions.png | |
2020-08-18 16:14 | gabrieljenik | Changeset attached | => LimeSurvey master 2819688c |
2020-08-18 16:14 | gabrieljenik | Note Added: 59505 | |
2020-08-18 16:14 | gabrieljenik | Assigned To | => gabrieljenik |
2020-08-18 16:14 | gabrieljenik | Resolution | open => fixed |
2020-08-18 16:29 | ollehar | Status | confirmed => resolved |
2020-08-19 09:49 |
|
Zoho Sprints | Yes => |Yes| |
2020-08-20 10:56 | lime_release_bot | Zoho Sprints | Yes => |Yes| |
2020-08-20 10:56 | lime_release_bot | Note Added: 59550 | |
2020-08-20 10:56 | lime_release_bot | Status | resolved => closed |