BeforeTokenImport

@cdorin, @ollehar: This is a detailed documentation of the plugin event needed for our project. Please review and let us know if we can implement this as outlined.

@DenisChenu Comments?

Can not be done in beforeTokenSave ?
https://manual.limesurvey.org/BeforeModelSave

In my opinion : if we add event and event and event again without global solution …

Or allow update of rules ?

And here : when adding a csv : it already take a lot time … adding an event for each lines ?

In onBeforeSave
Since we have model ,

Find good way to set isValid to false and check if we can addError https://www.yiiframework.com/doc/api/1.1/CModel#addError-detail

Hi Denis,

I thought about onBeforeSave.
I really like this event to be more powerfull. I agree with you.

The downside of that event is that on its current status:

• The isValid is not being considered on the plugin post processing.
• It could be hard to make the validations to only apply for the import process.
  We could use the "scenario", but still, that is somehow already used and we would need some reorganization.

On the other side, the new event could receive other parameters related to the import process specifically, as type of import, record count, import process params, ..

At last, this event shall be included on LSv3 LTS. As that we don't persuit a major feature or a code reorganization, but more an intervention oriented towards adding a validation point within a controlled scope as to minimize errors and regressions. onBeforeSave is very wide for that situation.

What do you think?

@ollehar @cdorin, What do you think about it?

Unless Denis has any principle counter arguments, I'd say go for it. :)

The isValid is not being considered on the plugin post processing.

We must add this :)

We must add this :)

Sure we do. I have already some code I did as PoC.
Let's create a new tcketI will open a new ticket for that, if it is ok.

We must add this :)
Sure we do. I have already some code I did as PoC.
Let's create a new tcketI will open a new ticket for that, if it is ok.

Sorry, not good with mantis formatting

I have created a new ticket for the before**Save plugin event.
https://bugs.limesurvey.org/view.php?id=16391

Please, let me know if it is OK then to work on a new beforeTokenImport plugin event.

Thanks!

About beforeTokenImport : yes, right, hard to see how to create a plugin with current system.

But remind : if you can generalise and not create one plugin for each system …

Before starting any work, please make sure that the same feature can be added to LS4. So the same place of the event exists.

PR for LTS: https://github.com/LimeSurvey/LimeSurvey/pull/1485

If ok, will create a different ticket for master

Looks good!
Please make sure to also update the manual once this gets merged.

Added the ImportDone parameter as @DenisChenu suggested.
Now the plugin allows to do custom importing as well.

:+1: thank you

I don't see the update on pull request ?

Oups … don't see it ate 1st option …

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30655

Found a bug.
Corrected here: https://github.com/LimeSurvey/LimeSurvey/pull/1643