@cdorin, this also seems to break all our templates which are based on vanilla. Please fix soon!

it is in our to-do for this sprint

Thanks for the feedback!

Tested in latest version. When i click on Save it is redirected to the attached screen

@cdorin, this should have been included at a sprint last month. Sushmanadendla has tested but it looks like this is still not working as expected, did I get that right?

@mazi Yeah well it was included in the last sprint but there is lot of workaround required to fix the issue it is taking time,hopefully it will be available in next sprint.
Thanks

Vanilla is not using the core options page, and the custom one is not properly triggering the form submit. So there are two options:
1) Make Vanilla's option page trigger the submit properly.
2) Make Vanilla use the core option page

I think option 2 is the best one as to have vanilla to resemble fruity.
In that case, I thinkoptions.twig file would be left orphan and could be removed.

What do you think?

With option 2 : you broke all theme (again and again and again …)

In that case, I thinkoptions.twig file would be left orphan and could be removed.

NO ! because there are system that can NOT BE DONE WITH CURENT OPTION.

Option #1 implemented:
https://github.com/LimeSurvey/LimeSurvey/pull/1457/files

BTW, I have tried option 2 twice and haven't had any problems.
What do you mean about breaking?

I understand themes which inherited from Vanilla maybe imepacted (not sure, I am doubting about that) .
Is that what you meant?

OK : if it comes by vanilla/options/options.js it can be fixed in theme

I think you replace core part, not template part
https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla

Tested issue by pulling the PR. Able to save the changes successfully. Please refer the screenshot for more details

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30239

Fixed in Release 4.3.3+200707

I also did some testing. If I didn't miss anything, everyone using a custom theme with adjusted theme options also has to update the theme's options.js file with the updated one of the vanilla theme?!

I also did some testing. If I didn't miss anything, everyone using a custom theme with adjusted theme options also has to update the theme's options.js file with the updated one of the vanilla theme?!

Seem yes : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/commit/209da6bd270d0a118efffba7afcd37079f45a97f

With option 2 : you broke all theme (again and again and again …)

@denis: what do you mean about this?