View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16235 | Bug reports | Survey taking | public | 2020-05-06 15:27 | 2020-08-12 10:10 |
Reporter | DenisChenu | Assigned To | gabrieljenik | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.2.2 | ||||
Summary | 16235: Welcome page show again if cookies are enable and survey is already done | ||||
Description | If « Set cookie to prevent repeated participation: » is on, after survey was completed, laucnh again the survey show the welcome page. | ||||
Steps To Reproduce | Import included survey | ||||
Additional Information | 3.X have same issue | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 10 | ||||
Complete LimeSurvey version number (& build) | 3.22.15 AND 4.2.2 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | ff | ||||
Database type & version | not relevant? | ||||
Server OS (if known) | not relevant ? | ||||
Webserver software & version (if known) | not relevant ? | ||||
PHP Version | not relevant ? | ||||
related to | 16219 | closed | Testing a question will not be possible if admin participated in the survey. | |
related to | 16569 | closed | gabrieljenik | Welcome page show again if cookies are enable and survey is already done |
A lss in all in one with cookie enable |
|
Faulty lines : https://github.com/LimeSurvey/LimeSurvey/blob/79683baa01edbec5ae2dfde4af82fc0b86a0da58/application/controllers/survey/index.php#L349 But if newtest=Y allow to do survey again : must remove cookie … |
|
hmm, wasn't this one recently solved? Or Gabriel made a PR recently? |
|
There are a related fix or PR, but clerly : must remove |
|
Issue exist in the latest version(4.3.4) also |
|
@cdorin There was an issue related to it. I think it was about cookies and admin previews. |
|
newTest param shouldn't be considered for this validation |
|
Tested the issue before pulling the PR, Issue exist. Tested the issue after pulling the PR, below are my findings: |
|
Before PR: https://screencast-o-matic.com/watch/cYji6iGlVB |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30363 |
|
Fixed in Release 4.3.10+200812 |
|
LimeSurvey: master a380df5e 2020-08-10 17:41 Committer: GitHub Details Diff |
Fixed issue 16235: Welcome page show again if cookies are enable and survey is already done (#1538) newTest param shouldn't be considered for this validation |
Affected Issues 16235 |
|
mod - application/controllers/survey/index.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-05-06 15:27 | DenisChenu | New Issue | |
2020-05-06 15:27 | DenisChenu | File Added: Peek 06-05-2020 15-22.gif | |
2020-05-06 15:28 | DenisChenu | Note Added: 57588 | |
2020-05-06 15:28 | DenisChenu | Note Added: 57589 | |
2020-05-06 15:28 | DenisChenu | File Added: limesurvey_survey_cookiesAllinone3X.lss | |
2020-05-06 15:28 | DenisChenu | Relationship added | related to 16219 |
2020-05-06 15:37 | DenisChenu | Note Added: 57592 | |
2020-05-11 09:51 | ollehar | Priority | none => normal |
2020-07-09 17:09 | cdorin | Note Added: 58876 | |
2020-07-09 17:36 | DenisChenu | Note Added: 58877 | |
2020-07-14 14:42 |
|
Note Added: 58944 | |
2020-07-14 14:43 |
|
Status | new => confirmed |
2020-07-29 23:08 | cdorin | Zoho Sprints | => |Yes| |
2020-07-29 23:08 |
|
Zoho Sprints ID | => 14469000000197133 |
2020-08-05 00:49 | gabrieljenik | Note Added: 59315 | |
2020-08-05 00:50 | gabrieljenik | Issue cloned: 16569 | |
2020-08-05 00:50 | gabrieljenik | Relationship added | related to 16569 |
2020-08-06 22:22 | gabrieljenik | Note Added: 59357 | |
2020-08-07 10:41 |
|
Note Added: 59365 | |
2020-08-07 10:41 |
|
File Added: 16235_ErrorMessage.png | |
2020-08-07 12:20 |
|
Note Added: 59367 | |
2020-08-10 15:52 | gabrieljenik | Changeset attached | => LimeSurvey master a380df5e |
2020-08-10 15:52 | gabrieljenik | Note Added: 59389 | |
2020-08-10 15:52 | gabrieljenik | Assigned To | => gabrieljenik |
2020-08-10 15:52 | gabrieljenik | Resolution | open => fixed |
2020-08-10 16:31 |
|
Zoho Sprints | Yes => |Yes| |
2020-08-10 16:31 |
|
Status | confirmed => resolved |
2020-08-10 16:31 |
|
Zoho Sprints | Yes => |Yes| |
2020-08-12 10:10 | lime_release_bot | Zoho Sprints | Yes => |Yes| |
2020-08-12 10:10 | lime_release_bot | Note Added: 59430 | |
2020-08-12 10:10 | lime_release_bot | Status | resolved => closed |