… PHP function return 0 … WTF

Issue in https://github.com/LimeSurvey/LimeSurvey/commit/a83531f716f4584272dc3aaf5d214880c6579de4

$result = $result ? $result : false; then no way to return 0 or "" etc … can send only false …

https://github.com/LimeSurvey/LimeSurvey/pull/1409

Can someone check if return null or 0 or "" can broke something in JS ?

My opinion : no … only NAN can broke something

Can @Jmantysalo test this, please? I don't have time.

@ollehar : it's not this issue,

I update something done before, but don't know why …

This issue is fixed with my fix, but touch to Expression core …

I tested, this works.

@cdorin : i know it's the good fix, but i update a line by Markus.
I don't understand wht Markus add it, maybe there are specific JS where a value returned by a function can throw error in JS ?

If some of other dev have an idea : tell me. Else : i merge it tomorrow.

Thanks @JHoeck to review :)

Do you know what (false) value can broke JS ? empty array maybe ? But if a function return an array : i can be an error to use it in JS like this.

My opinion on this fix : only NAN return must be updated $result = $result ? $result : false; not.

Else : alternative option

if(is_null($result) || (is_array($result) && count($result) === 0)) {
    $result = false;
}

I don't like to add a test if it's not needed

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29957

fixed in 4.4.0 rc1