View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
16042 | Bug reports | RemoteControl | public | 2020-03-25 15:49 | 2020-11-23 14:57 |
Reporter | jayce | Assigned To | gabrieljenik | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.1.0 | ||||
Summary | 16042: Generated token length is too short with add_participants() | ||||
Description | Hello, | ||||
Tags | No tags attached. | ||||
Bug heat | 14 | ||||
Complete LimeSurvey version number (& build) | Version 4.1.0+200128 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | MariaDB 10.4.11 | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 7.2.26 | ||||
Please update to the latest version and try again. Thank you. |
|
Same problem with the latest Version 4.1.13+200325 |
|
@jayce : inherited for group are not 3 ? Right or not ? |
|
Same problem with Version 4.3.5+200721 The problem seems to be in "models/Token.php" in the generateToken function. public function generateToken($tokenlength = NULL) And in the generateTokens function (which works fine, even when Inherit is on), it has this code:
If I change the code for setting $iTokenLength in generateToken to match the code in generateTokens, the JSON RPC-call works fine. |
|
@gabrieljenik, could you please take a look at this one? |
|
PR: https://github.com/LimeSurvey/LimeSurvey/pull/1654 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30740 |
|
Fixed in Release 4.3.28+201123 |
|
LimeSurvey: master 4341214e 2020-11-23 11:23 Committer: GitHub Details Diff |
Fixed issue 16042 generated token length is too short with add participants() (#1654) * Fixed issue 16042: Generated token length is too short with add_participants() Updated code from generateTokens() * Fixed issue 16042: Generated token length is too short with add_participants() Code reorg * Fixed issue 16042: Generated token length is too short with add_participants() Code reorg * Fixed issue 16042: Generated token length is too short with add_participants() Dummy change to trigger travis |
Affected Issues 16042 |
|
mod - application/models/Token.php | Diff File | ||
mod - tests/README.md | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-03-25 15:49 | jayce | New Issue | |
2020-03-27 11:31 | ollehar | Note Added: 56806 | |
2020-03-27 11:31 | ollehar | Status | new => feedback |
2020-03-27 16:11 | jayce | Note Added: 56813 | |
2020-03-27 16:11 | jayce | Status | feedback => new |
2020-05-26 16:32 | DenisChenu | Note Added: 58048 | |
2020-07-26 00:31 | sverker84 | Note Added: 59088 | |
2020-11-10 20:24 | cdorin | Note Added: 60607 | |
2020-11-10 20:24 | cdorin | Status | new => feedback |
2020-11-13 14:01 | gabrieljenik | Note Added: 60634 | |
2020-11-13 14:03 | gabrieljenik | Note Edited: 60634 | |
2020-11-23 10:23 | gabrieljenik | Changeset attached | => LimeSurvey master 4341214e |
2020-11-23 10:23 | gabrieljenik | Note Added: 60735 | |
2020-11-23 10:23 | gabrieljenik | Assigned To | => gabrieljenik |
2020-11-23 10:23 | gabrieljenik | Resolution | open => fixed |
2020-11-23 14:57 | lime_release_bot | Note Added: 60742 | |
2020-11-23 14:57 | lime_release_bot | Status | feedback => closed |