View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
15890 | Bug reports | Theme editor | public | 2020-02-18 14:44 | 2020-07-06 13:20 |
Reporter | Mazi | Assigned To | |||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.22.5 | ||||
Summary | 15890: Overview of un-installed themes shows incorrectly parsed theme description | ||||
Description | When uninstalling some default themes at a fresh 3.22.5 Limesurvey, the theme description is not parsed correctly, see screenshot. | ||||
Steps To Reproduce | Uninstall a few of the shipped themes and have a look at the list at the bottom of the theme list afterwards. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | Version 3.22.5 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MySQL 5 | ||||
Server OS (if known) | Ubuntu 18 | ||||
Webserver software & version (if known) | Apache 2 | ||||
PHP Version | 7.2.26 | ||||
Seems to have the issue only with the shipped themes. Thanks! |
|
@cdorin, same issue at LS 4, see screenshot. |
|
Is this allowed on config.xml? I don;t think so, right? |
|
For uninstalled themes, the description was taken directly from the config metadata directly. No parsing done. Added templateManifest::getDescription() method for parsing descriptions on XML file. |
|
Tested the issue by pulling the PR. The description of uninstalled themes is properly displayed. |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30247 |
|
Fixed in Release 3.22.25+200706 |
|
LimeSurvey: 3.x-LTS b5e43ff8 2020-07-03 12:59 Committer: GitHub Details Diff |
Fixed issue 15890: Overview of uninstalled themes shows incorrectly parsed theme description (#1464) Dev: New templateManifest::getDescription() method for parsing descriptions on XML file. This is now used on the view. |
Affected Issues 15890 |
|
mod - application/models/TemplateManifest.php | Diff File | ||
mod - application/views/admin/themeoptions/index.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-02-18 14:44 | Mazi | New Issue | |
2020-02-18 14:44 | Mazi | File Added: theme_overview.png | |
2020-02-21 00:22 | cdorin | Note Added: 56123 | |
2020-02-21 00:22 | cdorin | Priority | none => normal |
2020-02-21 00:22 | cdorin | Status | new => confirmed |
2020-02-21 11:08 | Mazi | File Added: image.png | |
2020-02-21 11:08 | Mazi | Note Added: 56134 | |
2020-03-30 22:28 | cdorin | Zoho Sprints | => |Yes| |
2020-03-30 22:28 |
|
Zoho Sprints ID | => 14469000000018061 |
2020-06-29 22:23 | gabrieljenik | Note Added: 58566 | |
2020-06-29 22:23 | gabrieljenik | File Added: image-2.png | |
2020-07-02 00:17 | gabrieljenik | Note Added: 58624 | |
2020-07-02 00:22 | gabrieljenik | Note Edited: 58624 | |
2020-07-02 14:17 |
|
Note Added: 58647 | |
2020-07-02 14:17 |
|
File Added: 15890_Uninstalledthemes_parseddesription.png | |
2020-07-03 10:59 | gabrieljenik | Changeset attached | => LimeSurvey 3.x-LTS b5e43ff8 |
2020-07-03 10:59 | guest | Note Added: 58674 | |
2020-07-03 11:02 |
|
Zoho Sprints | Yes => |Yes| |
2020-07-03 11:02 |
|
Status | confirmed => resolved |
2020-07-06 13:20 | lime_release_bot | Zoho Sprints | Yes => |Yes| |
2020-07-06 13:20 | lime_release_bot | Note Added: 58706 | |
2020-07-06 13:20 | lime_release_bot | Status | resolved => closed |
2020-07-06 13:20 | lime_release_bot | Resolution | open => fixed |