View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
15861 | Bug reports | _ Unknown | public | 2020-02-13 11:57 | 2020-02-17 11:22 |
Reporter | ollehar | Assigned To | DenisChenu | ||
Priority | normal | Severity | crash | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.1.2 | ||||
Target Version | 4.0.x | ||||
Summary | 15861: Stat function tests break on postgres | ||||
Description | Title. Run test on postgres. See discussion on github: https://github.com/LimeSurvey/LimeSurvey/commit/ee4f06983913e5b4af2f6d8d6d9d6d7e4d2efbaf | ||||
Steps To Reproduce | Run funcional test suite on postgres. | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | latest master | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | - | ||||
Database type & version | postgres 12 | ||||
Server OS (if known) | - | ||||
Webserver software & version (if known) | - | ||||
PHP Version | - | ||||
@ollehar : i don't have my destop currently, then for testing in PG : more complex I think i use
But alternat is checking DB coluln type. What is your opinion on the best choice ? |
|
I still think the best option is to compare with 0 or use |
|
Btw, fixing this bug is part of putting postgres into Travis. Just have to make sure the test suite works first. :) |
|
No docker? Booo. |
|
Docker on my desktop ... not on my 8 years old laptop ... |
|
non, no and again no .... Compare with Expression Manager count :
|
|
OK, then switch on question type, I guess, since different question types encode "not answered" or "empty answer" differently. But numerical question cannot store "empty answer", right? |
|
numerical and date : set to null if not answered : this is an issue in some situation. |
|
But "not answered" != "empty answer", because "not answered" can be "not seen"? |
|
Not seen : You use LimeSurvey sometimes ? |
|
No, I never use LimeSurvey. Obviously, when would I have time? :)
I was wondering about "not answered" for numerical questions. Also null? |
|
|
|
Got it. Then, just another query for numeric and date questions. |
|
Arg .... return string for decimal and datetime ... I check for dbType but hope it's not RAW type ... |
|
No free lunch... |
|
With mysql : return DB name ... int(11) for _filecount for example ... |
|
Thanks, will test later. |
|
I don't know if i set to testing ? I set to another dev ? etc ... |
|
Setting to testing is good, and also write a comment to bump it. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29559 |
|
Fixed in Release 4.1.5+200217 |
|
LimeSurvey: master 24f8b448 2020-02-14 12:16 Committer: GitHub Details Diff |
Fixed issue 15861: Stat function tests break on postgres (#1388) Dev: usage of CAST only for pgsql Dev: find DB type return RAW dbType : can change on SQL version udate |
Affected Issues 15861 |
|
mod - application/core/plugins/statFunctions/config.xml | Diff File | ||
mod - application/core/plugins/statFunctions/countFunctions.php | Diff File | ||
mod - application/core/plugins/statFunctions/statFunctions.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-02-13 11:57 | ollehar | New Issue | |
2020-02-13 11:57 | ollehar | Status | new => assigned |
2020-02-13 11:57 | ollehar | Assigned To | => DenisChenu |
2020-02-13 11:57 | ollehar | Priority | none => normal |
2020-02-13 12:02 | DenisChenu | Note Added: 55942 | |
2020-02-13 12:10 | ollehar | Note Added: 55943 | |
2020-02-13 12:11 | ollehar | Note Added: 55944 | |
2020-02-13 13:35 | ollehar | Note Added: 55945 | |
2020-02-13 13:37 | DenisChenu | Note Added: 55946 | |
2020-02-13 13:40 | DenisChenu | Note Added: 55947 | |
2020-02-13 13:47 | ollehar | Note Added: 55948 | |
2020-02-13 13:49 | DenisChenu | Note Added: 55949 | |
2020-02-13 13:52 | ollehar | Note Added: 55950 | |
2020-02-13 13:52 | ollehar | Note Edited: 55950 | |
2020-02-13 14:07 | DenisChenu | Note Added: 55951 | |
2020-02-13 14:19 | ollehar | Note Added: 55952 | |
2020-02-13 14:28 | DenisChenu | Note Added: 55953 | |
2020-02-13 14:29 | ollehar | Note Added: 55954 | |
2020-02-13 16:09 | DenisChenu | Note Added: 55970 | |
2020-02-13 16:10 | ollehar | Note Added: 55972 | |
2020-02-13 16:17 | DenisChenu | Note Added: 55975 | |
2020-02-13 17:05 | DenisChenu | Status | assigned => ready for testing |
2020-02-13 17:05 | DenisChenu | Note Added: 55976 | |
2020-02-13 17:05 | ollehar | Note Added: 55977 | |
2020-02-13 17:05 | DenisChenu | Note Added: 55978 | |
2020-02-13 17:06 | ollehar | Note Added: 55980 | |
2020-02-14 11:17 | DenisChenu | Changeset attached | => LimeSurvey master 24f8b448 |
2020-02-14 11:17 | DenisChenu | Note Added: 56008 | |
2020-02-14 11:17 | DenisChenu | Resolution | open => fixed |
2020-02-14 11:32 | ollehar | Status | ready for testing => resolved |
2020-02-17 11:22 | lime_release_bot | Note Added: 56047 | |
2020-02-17 11:22 | lime_release_bot | Status | resolved => closed |