View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
15808 | Bug reports | Survey editing | public | 2020-02-01 12:21 | 2020-02-03 11:11 |
Reporter | Waterlijn | Assigned To | DenisChenu | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 4.1.0 | ||||
Summary | 15808: Images in mailing not converted to CID | ||||
Description | When there are images in a mailing, the first mail will have a correct CID image, but the rest not. /application/controllers/admin/tokens.php
| ||||
Steps To Reproduce | Use for example {SURVEYDESCRIPTION} in the e-mail template and add an image to the description like this. <img src="/upload/surveys/663635/14016.tjp.jpg"> This won't work if there is a directory before '/upload/', but that's another (already reported) bug. | ||||
Tags | No tags attached. | ||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Versie 4.1.0+200128 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | - | ||||
Database type & version | not important | ||||
Server OS (if known) | not important | ||||
Webserver software & version (if known) | not important | ||||
PHP Version | not important | ||||
What did you change Bad idea : no need to reset completly. Must fix differently. |
|
I know, but this works for now. There must be a better solution of course. |
|
OK : issue in |
|
It seems that phpMailer's '->ContentType' is reset. I think because it's a 'multipart' instead of 'text/html' after the presend or something like that. |
|
I try to understand when/why it resetted :) We set it here Then Fix it at 100%, but i want to understand why it's needed before apply the fix :) |
|
Yep, and there are potentially some other part resetted (header …) |
|
You can check https://github.com/LimeSurvey/LimeSurvey/pull/1381 |
|
Thanks! |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29481 |
|
Thanks, Denis! |
|
Fixed in Release 4.1.1+200203 |
|
LimeSurvey: master 2dc74449 2020-02-03 11:48 Committer: GitHub Details Diff |
Fixed issue 15808: Images in mailing not converted to CID (#1381) Dev: Move ResetBase part to init Dev: reset needed (and uneeded but seem cleaner) when init |
Affected Issues 15808 |
|
mod - application/core/LimeMailer.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2020-02-01 12:21 | Waterlijn | New Issue | |
2020-02-01 18:10 | DenisChenu | Note Added: 55613 | |
2020-02-01 18:10 | DenisChenu | Assigned To | => DenisChenu |
2020-02-01 18:10 | DenisChenu | Status | new => assigned |
2020-02-01 18:27 | Waterlijn | Note Added: 55616 | |
2020-02-01 19:49 | DenisChenu | Note Added: 55618 | |
2020-02-01 20:48 | Waterlijn | Note Added: 55619 | |
2020-02-02 10:29 | DenisChenu | Note Added: 55621 | |
2020-02-02 11:25 | Waterlijn | Note Added: 55624 | |
2020-02-02 11:53 | DenisChenu | Note Added: 55625 | |
2020-02-02 12:09 | DenisChenu | Note Added: 55626 | |
2020-02-02 12:29 | Waterlijn | Note Added: 55628 | |
2020-02-03 10:48 | DenisChenu | Changeset attached | => LimeSurvey master 2dc74449 |
2020-02-03 10:48 | DenisChenu | Note Added: 55631 | |
2020-02-03 10:48 | DenisChenu | Resolution | open => fixed |
2020-02-03 11:11 | ollehar | Status | assigned => resolved |
2020-02-03 11:11 | ollehar | Note Added: 55634 | |
2020-02-03 11:11 | lime_release_bot | Note Added: 55635 | |
2020-02-03 11:11 | lime_release_bot | Status | resolved => closed |