@cdorin, this was reported by a customer who would be happy about a quick fix for the next release. Shouldn't be too trickyy to fix.

Deleted the SS and .lss file - ticket now public. Thx for report, Mazi

I see 2 problems here.

1) This is general, not ony for checkboxes.
If a certain question has a specific validation and also is mandatory, the shade will not appear.
This is because the shade related to the "mandatory" validation is cleared by the other valdation being satisfied.

2) This is not only for mandatory validation.
If a question has 2 validations. The shade will only appear if the last one is the one failing.

Suggestions:

• Review JS for shade. It is triggered now on an event for a tip. Should be triggered at the end, after all validations are done. That should solve problem #2.

• Still, it will not solve problem #1.

  • Shade show/hide is recalculated at client side.
  • Mandatory validation is recalculated at server side.
  • As to solve that, we should implement mandatory validation on client side.

Comments? @DenisChenu @ollehar

My own opinion :

1. I don't like the core system with same css class after and before submit … in 2.6 input-error are set ONLY when try to submit. In SkelVanilla : i use same system
2. mandatory are not checked with javascript, then input-error are not removed when answer is done see inputerror-butOK picture
3. You can't really compare mandatory in array and mandatory in multiple : we have a count(self) > 0 and count(self) == number of subquestion (see lss)

Then : my opinion

1. Remove the input-error update by JS. It's awfull to have it when came at a page for the 1st time for user.
2. The js update have other issue whe you disable hide-tip
3. Move mandatory to Expression Manager systyem : then have it like the other validation (tip-mandatory etc ) : this one is a bigger step (and maybe for 5.X)

Yes moving mandatory to expression manager is a great thing to do BUT : it's not a little fix ;)

inputerror-butOK.png (44,904 bytes)   

inputerror-butOK.png (44,904 bytes)   

Some other picture
The 1st one confirm the shade difference :)

Capture d’écran du 2020-07-30 09-06-25.png (48,035 bytes)   

Capture d’écran du 2020-07-30 09-06-25.png (48,035 bytes)   

Capture d’écran du 2020-07-30 09-06-39.png (54,181 bytes)   

Capture d’écran du 2020-07-30 09-06-39.png (54,181 bytes)   

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1577

Added new event handler for question-container, to evaluat status of its tips and then add/remove the error class

This will not prevent problem #1 said here.
https://bugs.limesurvey.org/view.php?id=15615#c59164

Neither it will prevent validations to be trigered at the ver begining when the form is still empty (clean).
If user hasn't inputed anything, why validations already appear?

I think both shuld be handled on separates stories.
@cdorin What do you think? @DenisChenu? @ollehar?

Code reviewed. Travis should be in green.

I think both shuld be handled on separates stories.

It's a template issue in my opinion. In fact : i leave validation BUT add the border only when submitted (PHP) …

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30714

Fixed in Release 3.25.0+201117