View Issue Details

This bug affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
14938Bug reportsOtherpublic2020-03-09 15:36
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.16.x 
Fixed in Version3.17.x 
Summary14938: Check data integrity : die with renaming a non existing table
Description

With a specific database : Check data integrity try to rename a non existing database

_No item by the name of 'lime_survey_917754' could be found in the current database 'LimeSurvey'_

Steps To Reproduce

Don't know …

  1. The survey didn't exist in Survey‘s listing
  2. I can‘t really access to DB easily (excpet with LimeSurvey)
  3. I can't update (currently) to last version.
Additional Information

In my opinion

  1. When broke : mus always use Yii Exception …
  2. Check data integrity must never broke but send an error in the list ;)
TagsNo tags attached.
Attached Files
index.php.htm (2,350 bytes)   
<html><head>
<meta http-equiv="content-type" content="text/html; charset=UTF-8"></head><body>Couldn't make backup of the survey table. Please try again. The database reported the following error:<br>CDbException:
 CDbCommand failed to execute the SQL statement: SQLSTATE[42000]: 
[Microsoft][ODBC Driver 11 for SQL Server][SQL Server]No item by the 
name of 'lime_survey_917754' could be found in the current database 
'LimeSurvey', given that @itemtype was input as '(null)'.. The SQL 
statement executed was: sp_rename 'lime_survey_917754', 
'lime_old_survey_917754_20190523145808383' in 
E:\WebSite\limesurvey\framework\db\CDbCommand.php:358
Stack trace:
#0 E:\WebSite\limesurvey\framework\db\CDbCommand.php(1364): 
CDbCommand-&amp;gt;execute()
#1 
E:\WebSite\limesurvey\application\controllers\admin\checkintegrity.php(539):
 CDbCommand-&amp;gt;renameTable('{{survey_917754...', 
'{{old_survey_91...')
#2 
E:\WebSite\limesurvey\application\controllers\admin\checkintegrity.php(40):
 CheckIntegrity-&amp;gt;_checkintegrity()
#3 [internal function]: CheckIntegrity-&amp;gt;index()
#4 E:\WebSite\limesurvey\framework\web\actions\CAction.php(109): 
ReflectionMethod-&amp;gt;invokeArgs(Object(CheckIntegrity), Array)
#5 E:\WebSite\limesurvey\application\core\Survey_Common_Action.php(83): 
CAction-&amp;gt;runWithParamsInternal(Object(CheckIntegrity), 
Object(ReflectionMethod), Array)
#6 E:\WebSite\limesurvey\framework\web\CController.php(308): 
Survey_Common_Action-&amp;gt;runWithParams(Array)
#7 E:\WebSite\limesurvey\framework\web\CController.php(286): 
CController-&amp;gt;runAction(Object(CheckIntegrity))
#8 E:\WebSite\limesurvey\framework\web\CController.php(265): 
CController-&amp;gt;runActionWithFilters(Object(CheckIntegrity), Array)
#9 
E:\WebSite\limesurvey\application\controllers\AdminController.php(158): 
CController-&amp;gt;run('checkintegrity')
#10 E:\WebSite\limesurvey\framework\web\CWebApplication.php(282): 
AdminController-&amp;gt;run('checkintegrity')
#11 E:\WebSite\limesurvey\framework\web\CWebApplication.php(141): 
CWebApplication-&amp;gt;runController('admin/checkinte...')
#12 E:\WebSite\limesurvey\framework\base\CApplication.php(185): 
CWebApplication-&amp;gt;processRequest()
#13 E:\WebSite\limesurvey\index.php(194): CApplication-&amp;gt;run()
#14 {main}<br></body></html>
index.php.htm (2,350 bytes)   
Bug heat2
Complete LimeSurvey version number (& build)3.16.0+190225
I will donate to the project if issue is resolvedNo
Browserff
Database type & versionMS SQL Server 2012
Server OS (if known)windows
Webserver software & version (if known)IIS
PHP Versionphp7.2

Relationships

related to 14939 closedDenisChenu Check data integrity with a lot of broken question : SQL error (MSSQL) 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2019-05-27 08:16

developer   ~52114

Argl …

$ grep -cow safeDie checkintegrity.php 
29
DenisChenu

DenisChenu

2019-05-29 16:12

developer   ~52163

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=28871

Related Changesets

LimeSurvey: master fc40e319

2019-05-29 15:33

DenisChenu

Committer: GitHub


Details Diff
Fixed issue 14938: Check data integrity : die with renaming a non existing table

Fixed issue 14939: Check data integrity with a lot of broken question : SQL error (MSSQL)
Fixed issue : Only one survey is find for SurveyLanguageSetting in checkintegrity
Affected Issues
14938, 14939
mod - application/controllers/admin/checkintegrity.php Diff File
mod - application/models/SurveyLanguageSetting.php Diff File
mod - application/views/admin/checkintegrity/fix_view.php Diff File

Issue History

Date Modified Username Field Change
2019-05-27 08:12 DenisChenu New Issue
2019-05-27 08:12 DenisChenu File Added: index.php.htm
2019-05-27 08:16 DenisChenu Note Added: 52114
2019-05-27 09:38 DenisChenu Description Updated
2019-05-27 09:59 DenisChenu Relationship added related to 14939
2019-05-28 09:02 DenisChenu Assigned To => DenisChenu
2019-05-28 09:02 DenisChenu Status new => assigned
2019-05-29 16:12 DenisChenu Changeset attached => LimeSurvey master fc40e319
2019-05-29 16:12 DenisChenu Note Added: 52163
2019-05-29 16:12 DenisChenu Resolution open => fixed
2019-05-31 10:19 DenisChenu Status assigned => resolved
2019-05-31 10:19 DenisChenu Fixed in Version => 3.17.x
2020-03-09 15:36 c_schmitz Status resolved => closed