View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
14738Bug reportsStatisticspublic2021-03-22 15:29
Reporterdan24 Assigned Toc_schmitz  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.16.x 
Summary14738: Percentage are not display correctly for questions multiple choice if a Sending date is selected
Description

When editing statistics, if we select Subtotals based on the questions displayed:
correctly to yes and define a Sending date (before and after).
the columm Percentge display "0.00%" for all the multiple choice questions.

If we don't select Subtotals based on the questions displayed it's OK or
if we don't select a sSending date it's OK

Steps To Reproduce

select Responses and Statistics
select Statistics
Select Subtotals based on the questions displayed: on Yes
Define a Sending date

view statistics for question type "multiple choice", all percentge display "0.00%"

Additional Information

in application/helpers/admin/statistics_helper.php line 2988 there is the code for the function.
there is a test line 3009 to compare results and multiNotDisplayed.
I think that the "Sending date" is not used to defined multiNotDisplayed

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)test on different version : v2.73; v3.15.3; vcd 3.16.0
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionmysql V5.5
Server OS (if known)
Webserver software & version (if known)
PHP Versionphp 5.4

Users monitoring this issue

There are no users monitoring this issue.

Activities

dan24

dan24

2019-04-05 14:05

reporter   ~51383

So in application/helpers/admin/statistics_helper.php line 2995 i put the following instructions :
if (!empty($sql)){
$criteria->addCondition($sql);
}

dan24

dan24

2019-04-05 14:06

reporter   ~51384

And now the percentage are display correctly

cdorin

cdorin

2021-02-08 19:22

reporter   ~62043

Hey @dan24, would you like to make a PR?

c_schmitz

c_schmitz

2021-03-22 08:49

administrator   ~63506

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31362

c_schmitz

c_schmitz

2021-03-22 08:51

administrator   ~63507

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31363

lime_release_bot

lime_release_bot

2021-03-22 15:29

administrator   ~63544

Fixed in Release 3.25.19+210323

Related Changesets

LimeSurvey: 3.x-LTS 8c4ee6af

2021-03-22 09:49

c_schmitz


Details Diff
Fixed issue 14738: Percentages are not correct for multiple choice questions if a date filter is set Affected Issues
14738
mod - application/helpers/admin/statistics_helper.php Diff File

LimeSurvey: 3.x-LTS 239b32a7

2021-03-22 09:51

c_schmitz


Details Diff
Fixed issue 14738: Percentages are not correct for multiple choice questions if a date filter is set Affected Issues
14738
mod - application/helpers/admin/statistics_helper.php Diff File

Issue History

Date Modified Username Field Change
2019-04-04 09:24 dan24 New Issue
2019-04-05 14:05 dan24 Note Added: 51383
2019-04-05 14:06 dan24 Note Added: 51384
2019-11-26 18:02 cdorin Assigned To => cdorin
2019-11-26 18:02 cdorin Status new => assigned
2021-02-08 19:22 cdorin Note Added: 62043
2021-02-08 19:22 cdorin Assigned To cdorin =>
2021-02-08 19:22 cdorin Status assigned => feedback
2021-03-22 08:48 c_schmitz Assigned To => c_schmitz
2021-03-22 08:48 c_schmitz Status feedback => assigned
2021-03-22 08:49 c_schmitz Changeset attached => LimeSurvey 3.x-LTS 8c4ee6af
2021-03-22 08:49 c_schmitz Note Added: 63506
2021-03-22 08:49 c_schmitz Resolution open => fixed
2021-03-22 08:51 c_schmitz Changeset attached => LimeSurvey 3.x-LTS 239b32a7
2021-03-22 08:51 c_schmitz Note Added: 63507
2021-03-22 08:51 c_schmitz Status assigned => resolved
2021-03-22 15:29 lime_release_bot Note Added: 63544
2021-03-22 15:29 lime_release_bot Status resolved => closed