View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
12258 | Bug reports | Survey taking | public | 2017-04-06 15:15 | 2020-03-13 18:47 |
Reporter | fvanderstarre | Assigned To | ollehar | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | reopened | ||
Product Version | 2.64.x | ||||
Summary | 12258: Incorrect date validation when using mm-yyyy dateformat | ||||
Description | I set up a survey with a date question using mm-yyyy dateformat. On Friday 31 march, if you select 02-2017, the answer is rejected because day is implicitly set to 31 - and 31-02-2017 is an invalid date. | ||||
Steps To Reproduce | See above | ||||
Additional Information | To test, you will have to set system date to 31 March, or wait until 29 April (e.g.). | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 22 | ||||
Complete LimeSurvey version number (& build) | 2.64.6+ build 170332 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Any | ||||
Database type & version | MS-SQL 2008 R2 | ||||
Server OS (if known) | Linux RHEL 7 | ||||
Webserver software & version (if known) | Apache 2.4.6 | ||||
PHP Version | 5.6.30 | ||||
Maybe we must set to 01 for day and month by default. And in 2.64 ? |
|
I'll have to test on a separate system. Working on it.... |
|
Also in 2.64, see attached screen shot |
|
Should I make a separate report for 2.64 ? Anything to get it fixed..... ;-) |
|
No, not know
|
|
I can't edit anything so will clone it and set to 2.64, thanks! |
|
Related to (= same as) 12251 |
|
NB: 31-02-2017 is an invalid date, but PHP will parse it as 2017-03-03 - pushing the date some days ahead, and then the validation fails. |
|
Seems like a bug in Date_Time_Converter. In the _date_to_timestamp() method. |
|
Thread on stackoverflow: http://stackoverflow.com/questions/43740037/datetime-converts-wrong-when-system-time-is-30-march?noredirect=1#comment74523192_43740037 Only reproducible when the snippet is put in expression manager! In its own file, the snippet works as expected. |
|
I think it was related to actual date. For example : you ask the day only, and we are on february : if you set 30 or 31 => javascript send 2017-02-31 : date is invalid. |
|
Javascript does not matter. PHP gets the value "02-2017", nothing else. The solution - from the thread - is to use "!" in front of the format. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=22687 |
|
Sorry for bad testing :) thanks to you |
|
Please pull and test. |
|
Olle, you set issue 12251 to resolved, do you still need my feedback on this one? I've been on holiday for two weeks. |
|
It seems to work OK in 2.65.1+170522 |
|
Great, I'll mark it as resolved and closed, then. |
|
This version of LimeSurvey is not longer supported. Please check so that the issue is fixed in a more recent version of LimeSurvey. If it's not, please reopen this bug report. Thank you. |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2017-04-06 15:15 | fvanderstarre | New Issue | |
2017-04-06 15:15 | fvanderstarre | Issue generated from: 12251 | |
2017-04-06 15:15 | fvanderstarre | Note Added: 43388 | |
2017-04-06 15:15 | fvanderstarre | Note Added: 43389 | |
2017-04-06 15:15 | fvanderstarre | Note Added: 43390 | |
2017-04-06 15:15 | fvanderstarre | Note Added: 43391 | |
2017-04-06 15:15 | fvanderstarre | Note Added: 43392 | |
2017-04-06 15:15 | fvanderstarre | Note Added: 43393 | |
2017-04-06 15:18 | fvanderstarre | Note Added: 43395 | |
2017-04-25 13:02 |
|
Sticky Issue | No => Yes |
2017-04-26 12:02 |
|
Sticky Issue | Yes => No |
2017-04-28 16:15 | ollehar | Assigned To | => ollehar |
2017-04-28 16:15 | ollehar | Status | new => assigned |
2017-04-28 16:21 | ollehar | Assigned To | ollehar => |
2017-04-28 16:21 | ollehar | Assigned To | => ollehar |
2017-04-28 16:21 | ollehar | Status | assigned => new |
2017-04-28 16:21 | ollehar | Assigned To | ollehar => |
2017-04-28 16:56 | ollehar | Note Added: 43501 | |
2017-04-28 16:56 | ollehar | Assigned To | => ollehar |
2017-04-28 16:56 | ollehar | Status | new => assigned |
2017-05-02 15:45 | ollehar | Note Added: 43522 | |
2017-05-02 15:53 | ollehar | Note Edited: 43522 | |
2017-05-02 16:19 | ollehar | Note Added: 43524 | |
2017-05-02 16:25 | ollehar | Note Edited: 43524 | |
2017-05-02 16:53 | DenisChenu | Note Added: 43529 | |
2017-05-02 17:08 | ollehar | Note Added: 43531 | |
2017-05-02 17:27 | ollehar | Changeset attached | => LimeSurvey master ab4c1165 |
2017-05-02 17:27 | ollehar | Note Added: 43532 | |
2017-05-02 17:27 | ollehar | Resolution | open => fixed |
2017-05-02 17:28 | DenisChenu | Note Added: 43533 | |
2017-05-03 09:45 | ollehar | Status | assigned => feedback |
2017-05-03 09:45 | ollehar | Note Added: 43537 | |
2017-05-04 10:00 | ollehar | Relationship added | has duplicate 12251 |
2017-05-04 10:00 | ollehar | Issue Monitored: fvanderstarre | |
2017-05-04 10:00 | ollehar | Issue Monitored: ollehar | |
2017-05-08 07:43 | fvanderstarre | Note Added: 43578 | |
2017-05-08 07:43 | fvanderstarre | Status | feedback => assigned |
2017-05-29 14:56 | fvanderstarre | Note Added: 43737 | |
2017-05-31 10:38 | ollehar | Note Added: 43769 | |
2017-05-31 10:38 | ollehar | Status | assigned => closed |
2017-06-07 10:44 | c_schmitz | Note Added: 43844 | |
2017-06-07 10:44 | c_schmitz | Status | closed => feedback |
2017-06-07 10:44 | c_schmitz | Resolution | fixed => reopened |
2020-03-13 18:47 | c_schmitz | Note Added: 56503 | |
2020-03-13 18:47 | c_schmitz | Status | feedback => closed |