View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 12074 | Bug reports | Other | public | 2017-01-23 08:38 | 2026-11-19 22:22 |
| Reporter | jiripavlicek | Assigned To | |||
| Priority | none | Severity | feature | ||
| Status | closed | Resolution | fixed | ||
| Summary | 12074: code readability/manageability improvement | ||||
| Description | Hi all, | ||||
| Steps To Reproduce | This isn't any bug/issue report. This is created as announce of my pull request for improve code readability/quality. It doesn't fixes any bug/issue or add new feature. This is only code development improvement. | ||||
| Tags | No tags attached. | ||||
| Bug heat | 8 | ||||
| Complete LimeSurvey version number (& build) | |||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | |||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | |||||
| Git branch / Pull Request URL | |||||
|
Really like the idea :) Maybe review contant name. Example : The idea : 1st part is ~ DB type, after put detail. |
|
|
Hi DenisChenu, where is the best place to contact you? Here in issues tracker or in pull request discussion https://github.com/LimeSurvey/LimeSurvey/pull/629 ? I created constant names like QT_A_ARRAY_5_CHOICE_QUESTIONS mainly to help me check my replacements ;) Character "A" is here for easier checking to replaced right string by right constant. Also a left the same constant values - for example QT_A_ARRAY_5_CHOICE_QUESTIONS has value "A", main reason for that was not to broke Limesurvey in case I forget somewhere replace "A" string. Let me know your idea about Question class constants names and I'll rename it and make new pull request. |
|
|
@jiripavlicek : yes pull request seems best, i'm not the only dev :). @olle think it's best to have the old code (like you do) |
|
|
Any ideas how should I change my pull request to be suitable for you? Thanks. |
|
|
your PR is a great work. If you want to port it yourself, just do it in the develop branch, it will be released with LS3 in few months (with Twig engine for templates). |
|
|
LimeSurvey 7 uses Question::QT_* constants for question types instead of bare letter strings. Closing as done. |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2017-01-23 08:38 | jiripavlicek | New Issue | |
| 2017-01-23 08:52 | DenisChenu | Severity | minor => feature |
| 2017-01-23 08:58 | DenisChenu | Note Added: 42791 | |
| 2017-01-25 08:19 | jiripavlicek | Note Added: 42825 | |
| 2017-01-25 09:02 | DenisChenu | Note Added: 42828 | |
| 2017-02-09 08:05 | jiripavlicek | Note Added: 42988 | |
| 2017-04-25 11:48 |
|
Note Added: 43440 | |
| 2026-11-19 22:22 | c_schmitz | Note Added: 87690 | |
| 2026-11-19 22:22 | c_schmitz | Bug heat | 6 => 8 |
| 2026-11-19 22:22 | c_schmitz | Status | new => closed |
| 2026-11-19 22:22 | c_schmitz | Resolution | open => fixed |