View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 11909 | Bug reports | public | 2016-11-15 09:51 | 2026-11-19 22:22 | |
| Reporter | DenisChenu | Assigned To | |||
| Priority | none | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.x | ||||
| Summary | 11909: Templates views (questions) : same method for all | ||||
| Description | I want to start a discussion about template/questions view. Preparing twig and have same method. Actual situation (2.5X or 3.0):
| ||||
| Steps To Reproduce | Working on 3.0 : i found
I think 3. solution is the best : easy to find file in only one view file (other are included here). We must/can have some rewrite to have lesser big file. | ||||
| Additional Information | renderPartial can be extended in https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/controllers/SurveysController.php : and take same logic than https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/qanda_helper.php#L6536 . Then it's not an issue to use Yii::app()->getController()->renderPartial directly for next release. (I can do the SurveysController->renderPartial function : no problem (easy). But : we need to extend twig if we use it : http://twig.sensiolabs.org/doc/advanced.html add a function to call Yii::app()->getController()->renderPartial (or another way). About 1+2+3+4 solution : when decision is take : we can rewrite partially each view one by one to use the new system. Vote | ||||
| Tags | template, twig | ||||
| Bug heat | 14 | ||||
| Complete LimeSurvey version number (& build) | |||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | |||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | |||||
| Git branch / Pull Request URL | |||||
|
Another question about some 'method'. Yesterday i do a /survey/questions/global/table/cell/head-header /survey/questions/global/table/cell/head-information . I think it's a good idea BUT must be updated like https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/views/survey/frontpage/saveForm/error.php All item must have an html view in his directory. But this view can just call another 'global' view with params. |
|
|
PS : sorry for "monitoring" but think dev decision must be whole team working on php files decision . |
|
|
Indeed, solution 3/ is very close to the existing flow in 2.50. |
|
|
About cycle of dev: it's more "when you work on questions/views : if you can take some time to move to new method". Because the real cycle of dev happen when we move to twig. BUt : we need to be sure to have a good way to have a twig->renderPartial system About twig : seems we can use ! and then But i'm unsure here :). |
|
|
yes, it's possible. So, for me, you're going the right way. |
|
|
Wait for twig decision. |
|
|
For the question view part: your choice is the good one. The waiting decision is about the PSTPL files. We need to do some testing internally to see if it's possible in a reasonable time to replace the replacement_helper and part of survey_runtime by a twig implementation. Again: The question views part doesn't depend on that. |
|
|
Question views in LimeSurvey 7 all use Twig with the same structure (answer.twig plus row/column subviews), which settles this discussion. Closing. |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2016-11-15 09:51 | DenisChenu | New Issue | |
| 2016-11-15 09:57 | DenisChenu | Note Added: 41950 | |
| 2016-11-15 09:57 | DenisChenu | Issue Monitored: LouisGac | |
| 2016-11-15 09:58 | DenisChenu | Issue Monitored: c_schmitz | |
| 2016-11-15 09:58 | DenisChenu | Issue Monitored: markusfluer | |
| 2016-11-15 09:59 | DenisChenu | Issue Monitored: ollehar | |
| 2016-11-15 10:00 | DenisChenu | Note Added: 41951 | |
| 2016-11-15 10:01 | DenisChenu | Tag Attached: template | |
| 2016-11-15 10:01 | DenisChenu | Tag Attached: twig | |
| 2016-11-15 10:34 |
|
Note Added: 41953 | |
| 2016-11-15 11:24 | DenisChenu | Note Added: 41954 | |
| 2016-11-15 11:49 |
|
Note Edited: 41953 | |
| 2016-11-15 11:50 |
|
Note Added: 41956 | |
| 2016-11-15 12:30 | DenisChenu | Additional Information Updated | |
| 2016-11-17 00:08 | DenisChenu | Note Added: 42007 | |
| 2016-11-17 10:48 |
|
Note Added: 42018 | |
| 2026-11-19 22:22 | c_schmitz | Note Added: 87689 | |
| 2026-11-19 22:22 | c_schmitz | Bug heat | 12 => 14 |
| 2026-11-19 22:22 | c_schmitz | Status | new => closed |
| 2026-11-19 22:22 | c_schmitz | Resolution | open => fixed |
| 2026-11-20 10:33 | c_schmitz | Category | Templates => (No Category) |