View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
11296Bug reportsOtherpublic2016-05-30 09:202016-06-02 19:35
Reporterc_schmitz Assigned ToLouisGac 
PriorityimmediateSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Target Version2.50.x 
Summary11296: Asset directory clearing
Description

We have many problems with people having outdated files in their asset directory after update.

The current ways of clearing assets is insufficient.

Assets needs to be cleared no matter how you update
Assets need to be cleard no matter the new asset version number (could by any string) - just a different version number should be sufficient, not only a bigger one.
*Asset clearing should apply to all assets, not only certain ones. Assets should be cleared by removing the contents from the /asset directory and touching the original folders.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)latest
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known).
Webserver software & version (if known).
PHP Version.

Relationships

Relationship GraphDependency Graph
related to 11279 closedc_schmitz the calendar icon is inactive 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2016-05-30 23:54

developer   ~39032

Now i use .v1, renamed each time (v2,v3 etc ...) on the base asset directory when update it (for FTP), i don't really like it : there are a non needed file .. and show "version" information.
But touching the base asset directory is sufficient.

" no matter how you update" i don't think we have a clean way to do this : you mean by "normal update", not hacked update ;)
LouisGac

LouisGac

2016-06-01 16:31

developer   ~39063

Last edited: 2016-06-01 16:31

First impressions :

  1. "no matter how you update" : that was all the idea of using the same version system than DB. DB is updated include for "git pull" updates, or manual updates. It's the very same for asset version. If someone pull from git, if the asset version number in version.php is superior to the one in DB : assets are forced. So I'd say : done.

  2. ok: easy

3.a "should apply to all assets, not only certain ones": It is the case now for all core scripts/css. The extensions still manage their assets by themselves. We're not suppose to edit them manually. But it can be done yes.

3.b "removing the contents from the /asset directory" ok, easy.
LouisGac

LouisGac

2016-06-01 16:59

developer   ~39064

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19284
LouisGac

LouisGac

2016-06-01 18:01

developer   ~39065

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19285
LouisGac

LouisGac

2016-06-02 11:07

developer   ~39076

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19287
LouisGac

LouisGac

2016-06-02 11:37

developer   ~39077

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19289
LouisGac

LouisGac

2016-06-02 12:01

developer   ~39078

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19291
LouisGac

LouisGac

2016-06-02 12:42

developer   ~39080

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19292
LouisGac

LouisGac

2016-06-02 13:14

developer   ~39081

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19298
LouisGac

LouisGac

2016-06-02 14:15

developer   ~39083

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19299
c_schmitz

c_schmitz

2016-06-02 19:35

administrator   ~39100

Version 2.50 Build 150602 released

Related Changesets

LimeSurvey: master c67b9692

2016-06-01 16:59

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, assets need to be cleard no matter the new asset version number just a different version number should be sufficient, not only a bigger one. Affected Issues
11296
mod - application/models/UpdateForm.php Diff File

LimeSurvey: master 1043f653

2016-06-01 18:01

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, Assets should be cleared by removing the contents from the /asset directory Affected Issues
11296
mod - application/config/version.php Diff File
mod - application/models/UpdateForm.php Diff File

LimeSurvey: master 97b2bf33

2016-06-02 11:07

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, use AdminTheme::registerScriptFile() for all the admin ui scripts registration Affected Issues
11296
mod - application/controllers/RegisterController.php Diff File
mod - application/controllers/admin/conditionsaction.php Diff File
mod - application/controllers/admin/statistics.php Diff File
mod - application/core/Survey_Common_Action.php Diff File
mod - application/models/UpdateForm.php Diff File
mod - application/views/admin/emailtemplates/emailtemplates_view.php Diff File
mod - application/views/admin/export/statistics_subviews/_statistics_view_scripts.php Diff File
mod - application/views/admin/survey/organizeGroupsAndQuestions_view.php Diff File
mod - application/views/admin/token/bounce.php Diff File
add - scripts/admin/Chart.min.js Diff File
add - scripts/admin/bootstrap-switch.min.js Diff File
add - scripts/jquery.multiselect.min.js Diff File

LimeSurvey: master 07c719ee

2016-06-02 11:37

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, use AdminTheme::registerCssFile() for all the admin ui css registration Affected Issues
11296
mod - application/controllers/admin/responses.php Diff File
mod - application/helpers/expressions/em_core_helper.php Diff File
mod - application/views/admin/dataentry/import.php Diff File
mod - application/views/admin/emailtemplates/emailtemplates_view.php Diff File
mod - application/views/admin/expressions/test/survey_logic_file.php Diff File
mod - application/views/admin/htmleditor/pop_editor_view.php Diff File
mod - application/views/admin/htmleditor/pop_nofields_view.php Diff File
mod - application/views/admin/survey/organizeGroupsAndQuestions_view.php Diff File
rm - styles/ckeditor.css Diff

LimeSurvey: master b3accd58

2016-06-02 12:01

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, few fixes Affected Issues
11296
mod - application/controllers/admin/questions.php Diff File
mod - application/core/Survey_Common_Action.php Diff File
mod - application/helpers/expressions/em_core_helper.php Diff File
mod - application/views/admin/emailtemplates/emailtemplates_view.php Diff File
mod - application/views/admin/expressions/test/survey_logic_file.php Diff File
mod - application/views/admin/htmleditor/pop_editor_view.php Diff File
mod - application/views/admin/survey/organizeGroupsAndQuestions_view.php Diff File
mod - application/views/admin/token/bounce.php Diff File

LimeSurvey: master 34b9a965

2016-06-02 12:42

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, use asset manager for third party extensions Affected Issues
11296
mod - application/config/internal.php Diff File
mod - application/config/third_party.php Diff File

LimeSurvey: master 92b8b70b

2016-06-02 13:14

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, touch all the extensions and third party subdirectories and assets. Affected Issues
11296
mod - application/models/AdminTheme.php Diff File

LimeSurvey: master f3aa106c

2016-06-02 14:15

LouisGac


Details Diff		 Fixed issue 11296: Asset directory clearing, check permission first Affected Issues
11296
mod - application/config/version.php Diff File
mod - application/models/AdminTheme.php Diff File

Issue History

Date Modified Username Field Change
2016-05-30 09:20 c_schmitz New Issue
2016-05-30 09:20 c_schmitz Priority none => immediate
2016-05-30 09:21 c_schmitz Relationship added related to 11279
2016-05-30 11:45 c_schmitz Description Updated
2016-05-30 23:54 DenisChenu Note Added: 39032
2016-06-01 16:24 LouisGac Sticky Issue No => Yes
2016-06-01 16:31 LouisGac Note Added: 39063
2016-06-01 16:31 LouisGac Note Edited: 39063
2016-06-01 16:59 LouisGac Changeset attached => LimeSurvey master c67b9692
2016-06-01 16:59 LouisGac Note Added: 39064
2016-06-01 16:59 LouisGac Assigned To => LouisGac
2016-06-01 16:59 LouisGac Resolution open => fixed
2016-06-01 18:01 LouisGac Changeset attached => LimeSurvey master 1043f653
2016-06-01 18:01 LouisGac Note Added: 39065
2016-06-01 20:58 c_schmitz Status new => assigned
2016-06-02 11:07 LouisGac Changeset attached => LimeSurvey master 97b2bf33
2016-06-02 11:07 LouisGac Note Added: 39076
2016-06-02 11:37 LouisGac Changeset attached => LimeSurvey master 07c719ee
2016-06-02 11:37 LouisGac Note Added: 39077
2016-06-02 12:01 LouisGac Changeset attached => LimeSurvey master b3accd58
2016-06-02 12:01 LouisGac Note Added: 39078
2016-06-02 12:42 LouisGac Changeset attached => LimeSurvey master 34b9a965
2016-06-02 12:42 LouisGac Note Added: 39080
2016-06-02 13:14 LouisGac Changeset attached => LimeSurvey master 92b8b70b
2016-06-02 13:14 LouisGac Note Added: 39081
2016-06-02 14:15 LouisGac Changeset attached => LimeSurvey master f3aa106c
2016-06-02 14:15 LouisGac Note Added: 39083
2016-06-02 14:18 LouisGac Sticky Issue Yes => No
2016-06-02 14:32 LouisGac Status assigned => resolved
2016-06-02 19:35 c_schmitz Note Added: 39100
2016-06-02 19:35 c_schmitz Status resolved => closed