View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
11184Bug reportsSurvey takingpublic2016-05-13 13:072016-05-25 21:15
ReporterDenisChenu Assigned ToLouisGac 
PriorityurgentSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Summary11184: Date question are not validated
Description

Date question are not validated in PHP (and not in JS too)

Steps To Reproduce

Import survey included
Activate
Set date to 2015-01-01 (minimum is 2015-06-01)
Submit : OK

Additional Information

It's better see with dropdown : but in fact text/date have same issue

See https://github.com/LimeSurvey/LimeSurvey/commit/c7fb7db30f1c7912c193caeef97f3a09faea7b0f#commitcomment-17436852

TagsNo tags attached.
Attached Files
limesurvey_survey_dateNotValidated.lss (13,019 bytes)
Capture du 2016-05-13 13-07-32.png (15,834 bytes)   
Capture du 2016-05-13 13-07-32.png (15,834 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)160513
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
child of 10500 closedLouisGac "Now" - "Tomorrow" used as min/max dates disfunction 

Users monitoring this issue

There are no users monitoring this issue.

Activities

LouisGac

LouisGac

2016-05-17 10:38

developer   ~38591

could you please provide a link to the PHP validation on github?
DenisChenu

DenisChenu

2016-05-17 10:38

developer   ~38592

https://github.com/LimeSurvey/LimeSurvey/commit/c7fb7db30f1c7912c193caeef97f3a09faea7b0f#diff-796aba4d06254b9caea9d461e4ea80c9L1611
LouisGac

LouisGac

2016-05-17 10:43

developer   ~38595

that's Javascript, not php.
DenisChenu

DenisChenu

2016-05-17 10:44

developer   ~38596

That's controil PHP ...

Uncomment this lien : and you fix the issue !
LouisGac

LouisGac

2016-05-17 10:45

developer   ~38597

wait: that's PHP?
EM is generating PHP strings into quotes?
:-|

okok
DenisChenu

DenisChenu

2016-05-17 10:47

developer   ~38599

@LouisGac : when i report bug : i have to explain how nto fix, explain why it's an issue etc ....

I send survey with just one question, in englis etc ....

But when i have a task assigned : survey can be big, in an language i don't understand ... LimeSurvey GMBH memebre ask me to help to fix it ... i do it ...

You really want i submit new bug or not ????
LouisGac

LouisGac

2016-05-17 10:55

developer   ~38600

I was just asking Denis.
Do as you wish.
DenisChenu

DenisChenu

2016-05-25 08:39

developer   ~38819

@LouisGac : do you fix this issue ?
LouisGac

LouisGac

2016-05-25 10:38

developer   ~38839

So:
https://bugs.limesurvey.org/view.php?id=10500

Also affect 2.06.
DenisChenu

DenisChenu

2016-05-25 10:46

developer   ~38840

Yes, maybe but :
We can use date("Y-m-d", strtotime( 'now' )) for workaround and have PHP control on date.
DenisChenu

DenisChenu

2016-05-25 11:26

developer   ~38842

I try to find a way to "fix" any date like we do for 2015 or 2015-06-01. But don't find a good way ....
LouisGac

LouisGac

2016-05-25 12:55

developer   ~38843

Last edited: 2016-05-25 12:59

Well, indeed, it works well: "now" is now, and makes sense only when using date-time.
When using only date, people should use the string "today".

So I let the PHP validation as it was.
LouisGac

LouisGac

2016-05-25 12:59

developer   ~38845

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=19162
c_schmitz

c_schmitz

2016-05-25 21:15

administrator   ~38906

Version 2.50+ Build 160526 released

Related Changesets

LimeSurvey: master bb059033

2016-05-25 12:59

LouisGac


Details Diff		 Fixed issue 11184: Date question are not validated Affected Issues
11184
mod - application/helpers/expressions/em_manager_helper.php Diff File
mod - templates/default/css/template.css Diff File

Issue History

Date Modified Username Field Change
2016-05-13 13:07 DenisChenu New Issue
2016-05-13 13:07 DenisChenu File Added: limesurvey_survey_dateNotValidated.lss
2016-05-13 13:07 DenisChenu File Added: Capture du 2016-05-13 13-07-32.png
2016-05-17 10:38 LouisGac Note Added: 38591
2016-05-17 10:38 DenisChenu Note Added: 38592
2016-05-17 10:43 LouisGac Note Added: 38595
2016-05-17 10:44 DenisChenu Note Added: 38596
2016-05-17 10:45 LouisGac Note Added: 38597
2016-05-17 10:47 DenisChenu Note Added: 38599
2016-05-17 10:55 LouisGac Note Added: 38600
2016-05-25 08:39 DenisChenu Note Added: 38819
2016-05-25 09:40 c_schmitz Priority none => high
2016-05-25 09:40 c_schmitz Priority high => urgent
2016-05-25 10:36 LouisGac Sticky Issue No => Yes
2016-05-25 10:37 LouisGac Relationship added child of 10500
2016-05-25 10:38 LouisGac Note Added: 38839
2016-05-25 10:46 DenisChenu Note Added: 38840
2016-05-25 11:26 DenisChenu Note Added: 38842
2016-05-25 12:55 LouisGac Note Added: 38843
2016-05-25 12:59 LouisGac Changeset attached => LimeSurvey master bb059033
2016-05-25 12:59 LouisGac Note Added: 38845
2016-05-25 12:59 LouisGac Assigned To => LouisGac
2016-05-25 12:59 LouisGac Resolution open => fixed
2016-05-25 12:59 LouisGac Note Edited: 38843
2016-05-25 13:00 LouisGac Status new => resolved
2016-05-25 13:00 LouisGac Sticky Issue Yes => No
2016-05-25 21:15 c_schmitz Note Added: 38906
2016-05-25 21:15 c_schmitz Status resolved => closed