View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
10739 | Bug reports | Theme editor | public | 2016-03-10 18:57 | 2016-04-26 17:54 |
Reporter | DenisChenu | Assigned To | |||
Priority | low | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.50.x | ||||
Summary | 10739: theme css are loaded before controller or view css | ||||
Description | Try to update some "default" css from controller : example expression.css .em-expression { in theme : it don't work | ||||
Steps To Reproduce | Look at survey logic file source: <link rel="stylesheet" type="text/css" href="http://limesurvey.sondages.pro/styles-public/font-awesome-43-debugmode.min.css" /> | ||||
Additional Information | We need some "default" css, because if core add a new page, a new system etc ... theme must not be update each time. Same for plugin (own view etc...) Must be : Same can /must be applied to js For css : move registering to footer do the job (i think). | ||||
Tags | No tags attached. | ||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 160310 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
Another question
|
|
And please : don't move expresssion.css or any other css in theme :
Some part can be moved to theme (example : surveylogicfile table color , maybe use boostrap color) but not other : iframe#dialog css is needed for all theme. |
|
why not ? |
|
By the way, the answer to the question "why do you load the CSS in the header?", is : But sure, now that I know better the LS code, I see no objection to move all that to the footer. |
|
Why not : because : we already have issue with admin template like this:
User report bug to tell : this was not fixed in mine. Admin theme can be made elsewhere than LS core, then have "default" > theme system is really the better way. |
|
well I'm using a script to generate all the admin themes from a SASS file. |
|
but sure, we could have a default common css file. |
|
Then ALL them dev must update Admin template each time we add a single line of css somewhere ? And all company who hire a dev to do an admin template must payb again when we add a litlle line of css Etc .... Same behaviour for Public template ? |
|
For now, each time I update the admin template I update all of them.
That's how are working for now the front end template. I will do it for the admin theme side in a second time. The question is : should we have a CSS core file, that end dev can't update via template ? I don't see why it would be usefull, but why not. |
|
All other css definition should be in a different file (that can be easy copied to all template) : no , because other people must want to have their own template without update it each time we add/update something. CSS : Cascading Style Sheet ;
Really CSS is Cascading . |
|
Ok Denis, I finally just understood what you want. Just add a css file in the config.xml. |
|
all the css load has been rewritten, using packages. |
|
Version 2.50+ Build 160426 released |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2016-03-10 18:57 | DenisChenu | New Issue | |
2016-03-10 19:00 | DenisChenu | Note Added: 36327 | |
2016-03-10 19:01 | DenisChenu | Relationship added | related to 10299 |
2016-03-10 19:02 | DenisChenu | Note Added: 36328 | |
2016-03-11 13:08 | c_schmitz | Priority | none => high |
2016-03-11 13:16 |
|
Note Added: 36401 | |
2016-03-11 13:21 |
|
Note Added: 36402 | |
2016-03-11 14:09 | DenisChenu | Note Added: 36408 | |
2016-03-11 14:35 |
|
Note Added: 36411 | |
2016-03-11 14:40 |
|
Note Added: 36412 | |
2016-03-11 14:46 | DenisChenu | Note Added: 36414 | |
2016-03-11 14:54 |
|
Note Added: 36420 | |
2016-03-11 14:54 |
|
Note Edited: 36420 | |
2016-03-11 15:08 |
|
Note Edited: 36420 | |
2016-03-11 15:08 |
|
Note Edited: 36420 | |
2016-03-11 15:48 | DenisChenu | Note Added: 36435 | |
2016-03-15 10:22 |
|
Note Added: 36490 | |
2016-03-15 10:55 |
|
Priority | high => low |
2016-04-25 19:44 |
|
Note Added: 37836 | |
2016-04-25 19:44 |
|
Status | new => resolved |
2016-04-25 19:44 |
|
Resolution | open => fixed |
2016-04-25 19:44 |
|
Assigned To | => LouisGac |
2016-04-26 17:54 | c_schmitz | Note Added: 37868 | |
2016-04-26 17:54 | c_schmitz | Status | resolved => closed |