View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
10372Bug reportsSurvey takingpublic2016-03-08 12:34
Reporterpmonstad Assigned ToLouisGac 
PrioritylowSeverityminor 
Status closedResolutionfixed 
Product Version2.50.x 
Fixed in Version2.50.x 
Summary10372: The two options after a survey has finished does not work
Description

Could not find the English menus right now. I have made a small survey with tokens. I try to access the survey without correct token. The warning is displayed as expected, with two option. Close survey and Load... These two options does not work, nothing happens. See screenshot.

TagsNo tags attached.
Attached Files
Bug heat10
Complete LimeSurvey version number (& build)160206
I will donate to the project if issue is resolvedNo
Browserall
Database type & versionall
Server OS (if known)all
Webserver software & version (if known)all
PHP Versionall

Relationships

related to 10087 closedLouisGac User stats page have invalid link 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2016-02-10 20:33

administrator   ~34843

These two options should not appear at all.

ollehar

ollehar

2016-02-11 10:35

administrator   ~34890

I'm thinking about adding another template file to deal with information pages like this, to replace startpage.pstpl as header. It might be better than to add yet another if-this-else-this in the controllers.

ollehar

ollehar

2016-02-11 10:35

administrator   ~34891

It would break backward compatibility with custom templates, though.

LouisGac

LouisGac

2016-02-11 19:01

developer   ~34941

sorry, forget to commit the fix. It's in this one :
https://github.com/LimeSurvey/LimeSurvey/commit/a242120e9d5db06021ba04911989ea4bad5c1d08

So this issue is fixed.

pmonstad

pmonstad

2016-02-12 08:24

updater   ~34973

Those two options still exists if I try to access a survey which require a token, without using one. Try to preview/test enclosed survey and the two options are there.

ollehar

ollehar

2016-02-12 11:17

administrator   ~34993

pmonstad, do you mean the screen where to enter the token?

pmonstad

pmonstad

2016-02-12 11:35

updater   ~34999

Yes olle,

ollehar

ollehar

2016-02-12 16:12

administrator   ~35037

Don't we need the buttons here? If there is no welcome page, this is the only place where a user can load the survey.

tpartner

tpartner

2016-03-03 20:40

partner   ~35930

My 2 cents...

I don't think we want those buttons on the token-entry screen (as in 2.06). Technically, at that point there is no survey to load, resume or exit.

This screen does not replace the welcome screen. If a valid token is entered and the welcome page is enabled they will see it.

I am all for adding a new .pstpl page for these - not being able to customize them has been an ongoing problem for users - but not if it breaks old templates. Can you put in a test? Something like:

if(token.pstpl exists) {
process it
}
else {
ignore it
}

LouisGac

LouisGac

2016-03-07 15:51

developer   ~36080

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=17805

LouisGac

LouisGac

2016-03-07 15:52

developer   ~36081

The menus are no more shown in register page.

c_schmitz

c_schmitz

2016-03-08 12:34

administrator   ~36145

Version 250+ Build 160308 released

Related Changesets

LimeSurvey: master 85c5c35c

2016-03-07 15:51

LouisGac


Details Diff
Fixed issue 10372: The two options after a survey has finished does not work Affected Issues
10372
mod - templates/default/views/register.pstpl Diff File

Issue History

Date Modified Username Field Change
2016-02-09 21:16 pmonstad New Issue
2016-02-09 21:16 pmonstad File Added: Skjermbilde 2016-02-09 kl. 21.13.20.png
2016-02-10 09:34 DenisChenu Relationship added related to 10087
2016-02-10 17:23 ollehar Assigned To => ollehar
2016-02-10 17:23 ollehar Status new => assigned
2016-02-10 20:33 c_schmitz Note Added: 34843
2016-02-11 10:35 ollehar Note Added: 34890
2016-02-11 10:35 ollehar Note Added: 34891
2016-02-11 19:01 LouisGac Note Added: 34941
2016-02-11 19:01 LouisGac Status assigned => feedback
2016-02-12 08:24 pmonstad Note Added: 34973
2016-02-12 08:24 pmonstad Status feedback => assigned
2016-02-12 08:25 pmonstad File Added: limesurvey_survey_387696.lss
2016-02-12 11:17 ollehar Note Added: 34993
2016-02-12 11:35 pmonstad Note Added: 34999
2016-02-12 16:12 ollehar Note Added: 35037
2016-03-03 19:34 LouisGac Priority normal => low
2016-03-03 20:40 tpartner Note Added: 35930
2016-03-07 15:51 LouisGac Changeset attached => LimeSurvey master 85c5c35c
2016-03-07 15:51 LouisGac Note Added: 36080
2016-03-07 15:51 LouisGac Assigned To ollehar => LouisGac
2016-03-07 15:51 LouisGac Resolution open => fixed
2016-03-07 15:52 LouisGac Note Added: 36081
2016-03-07 15:52 LouisGac Status assigned => resolved
2016-03-08 12:33 c_schmitz Fixed in Version => 2.5
2016-03-08 12:34 c_schmitz Note Added: 36145
2016-03-08 12:34 c_schmitz Status resolved => closed