View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
10142 | Bug reports | Survey editing | public | 2015-12-12 12:48 | 2016-01-08 15:36 |
Reporter | DenisChenu | Assigned To | ollehar | ||
Priority | normal | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 2.50.x | ||||
Fixed in Version | 2.50.x | ||||
Summary | 10142: We ca n add question to an active survey | ||||
Description | The "Survey quick actions/Add a new question" is shown for an active survey. | ||||
Steps To Reproduce | Go to a question with an actove survey. Click on button | ||||
Additional Information | We have 2 bug here.
The 2nd must be done in Model too (surely a bug in 2.06 too). | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 6 | ||||
Complete LimeSurvey version number (& build) | 151212 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
I must test with a simple survey : but we have surely some "BD save" issue when do the survey. |
|
What action is this? /index.php/admin/database/index |
|
Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16482 |
|
1st : button appear at : index.php/admin/questions/sa/view/surveyid/282267/gid/8/qid/35 Easy way : Add a control here : if ($oSurvey->active=="Y") .... Using if($this->isNewRecord) in a new extended function : beforeSave : http://www.yiiframework.com/doc/api/1.1/CActiveRecord#beforeSave-detail or in rules (don't know the best) This must return false and |
|
Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16484 |
|
I cannot reproduce this. What $_POST did you send? |
|
Added check in controller and disabled button in view. |
|
I looking at code for $_POST. I didn't say it can be done actually without hacking the HTML view by user (any user can update his HTML to send any value to any inout name). |
|
The Survey quick action button is still here (and clickable). Return alert is OK :) |
|
Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16617 |
|
@Denis, what quick action button exactly? Screenshot? |
|
@Denis, did you pull before re-open? |
|
Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16623 |
|
Olle : i can confirm the issue, maybe assets ? Just now: Goes to an active survey by 'Question group/question explorer' : see the button. Reload the page (maybe some JS) : button still here. Click on it : go to index.php/admin/questions/sa/view/surveyid/282267/gid/9/qid/42 with " Cannot add questions while the survey is active. " alert. HTML code of "button" : <a href="/index.php/admin/questions/sa/newquestion/surveyid/282267/gid/9"> </div> </div> PS: this panel must NOT exist. |
|
Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16630 |
|
Fix committed to 2.5 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=16632 |
|
Version 2.5RC6 released |
|
LimeSurvey: 2.5 b1dd710c 2015-12-14 15:35 Details Diff |
Fixed issue 10142: Don't allow new question when survey is active |
Affected Issues 10142 |
|
mod - application/controllers/admin/questions.php | Diff File | ||
LimeSurvey: 2.5 ba686054 2015-12-14 16:05 Details Diff |
Fixed issue 10142 (part 2): Disable add new question button when survey is active |
Affected Issues 10142 |
|
mod - application/core/Survey_Common_Action.php | Diff File | ||
mod - application/views/admin/survey/QuestionGroups/group_view.php | Diff File | ||
mod - application/views/admin/survey/QuestionGroups/nquestiongroupbar_view.php | Diff File | ||
LimeSurvey: 2.5 d988add5 2015-12-17 12:39 Details Diff |
Fixed issue 10142: Disable group list add question-button when survey is active |
Affected Issues 10142 |
|
mod - application/models/QuestionGroup.php | Diff File | ||
LimeSurvey: 2.5 5640a97e 2015-12-17 14:17 Details Diff |
Fixed issue 10142: Make sure you can't save question group while survey is active |
Affected Issues 10142 |
|
mod - application/controllers/admin/questiongroups.php | Diff File | ||
mod - application/models/QuestionGroup.php | Diff File | ||
LimeSurvey: 2.5 23cbd076 2015-12-17 15:24 Details Diff |
Fixed issue 10142: Make sure you can't save question while survey is active |
Affected Issues 10142 |
|
mod - application/controllers/admin/database.php | Diff File | ||
mod - application/models/Question.php | Diff File | ||
LimeSurvey: 2.5 ab91d574 2015-12-17 15:47 Details Diff |
Fixed issue 10142: Disable survey quick action in question summary when survey is active |
Affected Issues 10142 |
|
mod - application/controllers/admin/questions.php | Diff File | ||
mod - application/views/admin/survey/Question/question_view.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2015-12-12 12:48 | DenisChenu | New Issue | |
2015-12-12 12:48 | DenisChenu | Status | new => assigned |
2015-12-12 12:48 | DenisChenu | Assigned To | => LouisGac |
2015-12-12 12:48 | DenisChenu | Note Added: 33899 | |
2015-12-14 15:13 | ollehar | Assigned To | LouisGac => ollehar |
2015-12-14 15:38 | ollehar | Note Added: 33906 | |
2015-12-14 15:45 | ollehar | Changeset attached | => LimeSurvey 2.5 b1dd710c |
2015-12-14 15:45 | ollehar | Note Added: 33907 | |
2015-12-14 15:45 | ollehar | Resolution | open => fixed |
2015-12-14 15:53 | DenisChenu | Note Added: 33908 | |
2015-12-14 15:53 | DenisChenu | File Added: Capture du 2015-12-14 15-45-30.png | |
2015-12-14 16:05 | ollehar | Changeset attached | => LimeSurvey 2.5 ba686054 |
2015-12-14 16:05 | ollehar | Note Added: 33909 | |
2015-12-14 16:27 | ollehar | Note Added: 33910 | |
2015-12-14 16:28 | ollehar | Note Edited: 33910 | |
2015-12-14 16:40 | ollehar | Note Added: 33911 | |
2015-12-14 16:40 | ollehar | Status | assigned => resolved |
2015-12-14 16:40 | ollehar | Fixed in Version | => 2.5 |
2015-12-14 17:09 | DenisChenu | Note Added: 33915 | |
2015-12-17 09:19 | DenisChenu | Note Added: 34032 | |
2015-12-17 09:31 | c_schmitz | Status | resolved => feedback |
2015-12-17 09:31 | c_schmitz | Resolution | fixed => reopened |
2015-12-17 09:31 | c_schmitz | Status | feedback => assigned |
2015-12-17 12:40 | ollehar | Changeset attached | => LimeSurvey 2.5 d988add5 |
2015-12-17 12:40 | ollehar | Note Added: 34041 | |
2015-12-17 12:42 | ollehar | Note Added: 34042 | |
2015-12-17 12:43 | ollehar | Note Added: 34043 | |
2015-12-17 14:17 | ollehar | Changeset attached | => LimeSurvey 2.5 5640a97e |
2015-12-17 14:17 | ollehar | Note Added: 34044 | |
2015-12-17 14:29 | DenisChenu | Note Added: 34046 | |
2015-12-17 15:24 | ollehar | Changeset attached | => LimeSurvey 2.5 23cbd076 |
2015-12-17 15:24 | ollehar | Note Added: 34049 | |
2015-12-17 15:47 | ollehar | Changeset attached | => LimeSurvey 2.5 ab91d574 |
2015-12-17 15:47 | ollehar | Note Added: 34050 | |
2015-12-17 15:52 | ollehar | Status | assigned => resolved |
2015-12-17 15:52 | ollehar | Resolution | reopened => fixed |
2016-01-08 15:36 | c_schmitz | Note Added: 34205 | |
2016-01-08 15:36 | c_schmitz | Status | resolved => closed |
2019-11-01 17:25 | c_schmitz | Category | Survey design => Survey editing |