View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 09435 | Bug reports | Authentication | public | 2015-01-05 02:03 | 2015-02-11 15:57 |
| Reporter | aesteban | Assigned To | aesteban | ||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 2.05+ | ||||
| Target Version | 2.05+ | ||||
| Summary | 09435: Trying to get property of non-object with debug=2 and AuditLog enabled | ||||
| Description | beforeLogout event processed by AuditLog generates an error when session is already expired and users click on "Logout" | ||||
| Steps To Reproduce | 0.- Set debug=2 in config.php Result: PHP notice: Trying to get property of non-object (See attachment) | ||||
| Tags | No tags attached. | ||||
| Attached Files | PHP notice.html (21,034 bytes)
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<!-- saved from url=(0071)http://localhost/lsurveymaster/index.php/admin/authentication/sa/logout -->
<html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"><head><meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<title>PHP notice</title>
<style type="text/css">
/*<![CDATA[*/
html,body,div,span,applet,object,iframe,h1,h2,h3,h4,h5,h6,p,blockquote,pre,a,abbr,acronym,address,big,cite,code,del,dfn,em,font,img,ins,kbd,q,s,samp,small,strike,strong,sub,sup,tt,var,b,u,i,center,dl,dt,dd,ol,ul,li,fieldset,form,label,legend,table,caption,tbody,tfoot,thead,tr,th,td{border:0;outline:0;font-size:100%;vertical-align:baseline;background:transparent;margin:0;padding:0;}
body{line-height:1;}
ol,ul{list-style:none;}
blockquote,q{quotes:none;}
blockquote:before,blockquote:after,q:before,q:after{content:none;}
:focus{outline:0;}
ins{text-decoration:none;}
del{text-decoration:line-through;}
table{border-collapse:collapse;border-spacing:0;}
body {
font: normal 9pt "Verdana";
color: #000;
background: #fff;
}
h1 {
font: normal 18pt "Verdana";
color: #f00;
margin-bottom: .5em;
}
h2 {
font: normal 14pt "Verdana";
color: #800000;
margin-bottom: .5em;
}
h3 {
font: bold 11pt "Verdana";
}
pre {
font: normal 11pt Menlo, Consolas, "Lucida Console", Monospace;
}
pre span.error {
display: block;
background: #fce3e3;
}
pre span.ln {
color: #999;
padding-right: 0.5em;
border-right: 1px solid #ccc;
}
pre span.error-ln {
font-weight: bold;
}
.container {
margin: 1em 4em;
}
.version {
color: gray;
font-size: 8pt;
border-top: 1px solid #aaa;
padding-top: 1em;
margin-bottom: 1em;
}
.message {
color: #000;
padding: 1em;
font-size: 11pt;
background: #f3f3f3;
-webkit-border-radius: 10px;
-moz-border-radius: 10px;
border-radius: 10px;
margin-bottom: 1em;
line-height: 160%;
}
.source {
margin-bottom: 1em;
}
.code pre {
background-color: #ffe;
margin: 0.5em 0;
padding: 0.5em;
line-height: 125%;
border: 1px solid #eee;
}
.source .file {
margin-bottom: 1em;
font-weight: bold;
}
.traces {
margin: 2em 0;
}
.trace {
margin: 0.5em 0;
padding: 0.5em;
}
.trace.app {
border: 1px dashed #c00;
}
.trace .number {
text-align: right;
width: 2em;
padding: 0.5em;
}
.trace .content {
padding: 0.5em;
}
.trace .plus,
.trace .minus {
display:inline;
vertical-align:middle;
text-align:center;
border:1px solid #000;
color:#000;
font-size:10px;
line-height:10px;
margin:0;
padding:0 1px;
width:10px;
height:10px;
}
.trace.collapsed .minus,
.trace.expanded .plus,
.trace.collapsed pre {
display: none;
}
.trace-file {
cursor: pointer;
padding: 0.2em;
}
.trace-file:hover {
background: #f0ffff;
}
/*]]>*/
</style>
</head>
<body>
<div class="container">
<h1>PHP notice</h1>
<p class="message">
Trying to get property of non-object </p>
<div class="source">
<p class="file">/usr/share/nginx/html/lsurveymaster/plugins/AuditLog/AuditLog.php(31)</p>
<div class="code"><pre><span class="ln">19</span> $this->subscribe('beforeParticipantDelete');
<span class="ln">20</span> $this->subscribe('beforeLogout');
<span class="ln">21</span> $this->subscribe('afterSuccessfulLogin');
<span class="ln">22</span> $this->subscribe('afterFailedLoginAttempt');
<span class="ln">23</span> }
<span class="ln">24</span>
<span class="ln">25</span> /**
<span class="ln">26</span> * User logout to the audit log
<span class="ln">27</span> * @return unknown_type
<span class="ln">28</span> */
<span class="ln">29</span> public function beforeLogout()
<span class="ln">30</span> {
<span class="error"><span class="ln error-ln">31</span> $iUserID=$this->api->getCurrentUser()->uid;
</span><span class="ln">32</span> $oAutoLog = $this->api->newModel($this, 'log');
<span class="ln">33</span> $oAutoLog->uid=$iUserID;
<span class="ln">34</span> $oAutoLog->entity='user';
<span class="ln">35</span> $oAutoLog->entityid=$iUserID;
<span class="ln">36</span> $oAutoLog->action='beforeLogout';
<span class="ln">37</span> $oAutoLog->save();
<span class="ln">38</span> }
<span class="ln">39</span>
<span class="ln">40</span> /**
<span class="ln">41</span> * Successfull login to the audit log
<span class="ln">42</span> * @return unknown_type
<span class="ln">43</span> */
</pre></div> </div>
<div class="traces">
<h2>Stack Trace</h2>
<table style="width:100%;">
<tbody><tr class="trace core collapsed">
<td class="number">
#0 </td>
<td class="content">
<div class="trace-file">
unknown(0): <strong>AuditLog</strong>-><strong>beforeLogout</strong>() </div>
</td>
</tr>
<tr class="trace app expanded">
<td class="number">
#1 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/application/libraries/PluginManager/PluginManager.php(191): <strong>call_user_func</strong>(array(AuditLog, "beforeLogout")) </div>
<div class="code"><pre><span class="ln">186</span> {
<span class="ln">187</span> if (!$event->isStopped()
<span class="ln">188</span> && (empty($target) || in_array(get_class($subscription[0]), $target)))
<span class="ln">189</span> {
<span class="ln">190</span> $subscription[0]->setEvent($event);
<span class="error"><span class="ln error-ln">191</span> call_user_func($subscription);
</span><span class="ln">192</span> }
<span class="ln">193</span> }
<span class="ln">194</span> }
<span class="ln">195</span>
<span class="ln">196</span> return $event;
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#2 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/application/controllers/admin/authentication.php(121): <strong>PluginManager</strong>-><strong>dispatchEvent</strong>(PluginEvent) </div>
<div class="code"><pre><span class="ln">116</span> // Fetch the current user
<span class="ln">117</span> $plugin = App()->user->getState('plugin', null); // Save for afterLogout, current user will be destroyed by then
<span class="ln">118</span>
<span class="ln">119</span> /* Adding beforeLogout event */
<span class="ln">120</span> $beforeLogout = new PluginEvent('beforeLogout');
<span class="error"><span class="ln error-ln">121</span> App()->getPluginManager()->dispatchEvent($beforeLogout);
</span><span class="ln">122</span>
<span class="ln">123</span> App()->user->logout();
<span class="ln">124</span> App()->user->setFlash('loginmessage', gT('Logout successful.'));
<span class="ln">125</span>
<span class="ln">126</span> /* Adding afterLogout event */
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#3 </td>
<td class="content">
<div class="trace-file">
unknown(0): <strong>Authentication</strong>-><strong>logout</strong>() </div>
</td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#4 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/web/actions/CAction.php(108): <strong>ReflectionMethod</strong>-><strong>invokeArgs</strong>(Authentication, array()) </div>
<div class="code"><pre><span class="ln">103</span> elseif($param->isDefaultValueAvailable())
<span class="ln">104</span> $ps[]=$param->getDefaultValue();
<span class="ln">105</span> else
<span class="ln">106</span> return false;
<span class="ln">107</span> }
<span class="error"><span class="ln error-ln">108</span> $method->invokeArgs($object,$ps);
</span><span class="ln">109</span> return true;
<span class="ln">110</span> }
<span class="ln">111</span> }
</pre></div> </td>
</tr>
<tr class="trace app expanded">
<td class="number">
#5 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/application/core/Survey_Common_Action.php(99): <strong>CAction</strong>-><strong>runWithParamsInternal</strong>(Authentication, ReflectionMethod, array("q" => "/lsurveymaster/index.php/admin/authentication/sa/logout", "sa" => "logout")) </div>
<div class="code"><pre><span class="ln">094</span> $oMethod = new ReflectionMethod($this, $sDefault);
<span class="ln">095</span> }
<span class="ln">096</span>
<span class="ln">097</span> // We're all good to go, let's execute it
<span class="ln">098</span> // runWithParamsInternal would automatically get the parameters of the method and populate them as required with the params
<span class="error"><span class="ln error-ln">099</span> return parent::runWithParamsInternal($this, $oMethod, $params);
</span><span class="ln">100</span> }
<span class="ln">101</span>
<span class="ln">102</span> /**
<span class="ln">103</span> * Some functions have different parameters, which are just an alias of the
<span class="ln">104</span> * usual parameters we're getting in the url. This function just populates
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#6 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/web/CController.php(308): <strong>Survey_Common_Action</strong>-><strong>runWithParams</strong>(array("q" => "/lsurveymaster/index.php/admin/authentication/sa/logout", "sa" => "logout")) </div>
<div class="code"><pre><span class="ln">303</span> {
<span class="ln">304</span> $priorAction=$this->_action;
<span class="ln">305</span> $this->_action=$action;
<span class="ln">306</span> if($this->beforeAction($action))
<span class="ln">307</span> {
<span class="error"><span class="ln error-ln">308</span> if($action->runWithParams($this->getActionParams())===false)
</span><span class="ln">309</span> $this->invalidActionParams($action);
<span class="ln">310</span> else
<span class="ln">311</span> $this->afterAction($action);
<span class="ln">312</span> }
<span class="ln">313</span> $this->_action=$priorAction;
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#7 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/web/CController.php(286): <strong>CController</strong>-><strong>runAction</strong>(Authentication) </div>
<div class="code"><pre><span class="ln">281</span> * @see runAction
<span class="ln">282</span> */
<span class="ln">283</span> public function runActionWithFilters($action,$filters)
<span class="ln">284</span> {
<span class="ln">285</span> if(empty($filters))
<span class="error"><span class="ln error-ln">286</span> $this->runAction($action);
</span><span class="ln">287</span> else
<span class="ln">288</span> {
<span class="ln">289</span> $priorAction=$this->_action;
<span class="ln">290</span> $this->_action=$action;
<span class="ln">291</span> CFilterChain::create($this,$action,$filters)->run();
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#8 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/web/CController.php(265): <strong>CController</strong>-><strong>runActionWithFilters</strong>(Authentication, array()) </div>
<div class="code"><pre><span class="ln">260</span> {
<span class="ln">261</span> if(($parent=$this->getModule())===null)
<span class="ln">262</span> $parent=Yii::app();
<span class="ln">263</span> if($parent->beforeControllerAction($this,$action))
<span class="ln">264</span> {
<span class="error"><span class="ln error-ln">265</span> $this->runActionWithFilters($action,$this->filters());
</span><span class="ln">266</span> $parent->afterControllerAction($this,$action);
<span class="ln">267</span> }
<span class="ln">268</span> }
<span class="ln">269</span> else
<span class="ln">270</span> $this->missingAction($actionID);
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#9 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/application/controllers/AdminController.php(169): <strong>CController</strong>-><strong>run</strong>("authentication") </div>
<div class="code"><pre><span class="ln">164</span> $this->redirect(array('/admin/authentication/sa/login'));
<span class="ln">165</span> }
<span class="ln">166</span>
<span class="ln">167</span> }
<span class="ln">168</span>
<span class="error"><span class="ln error-ln">169</span> return parent::run($action);
</span><span class="ln">170</span> }
<span class="ln">171</span>
<span class="ln">172</span> /**
<span class="ln">173</span> * Routes all the actions to their respective places
<span class="ln">174</span> *
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#10 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/web/CWebApplication.php(282): <strong>AdminController</strong>-><strong>run</strong>("authentication") </div>
<div class="code"><pre><span class="ln">277</span> {
<span class="ln">278</span> list($controller,$actionID)=$ca;
<span class="ln">279</span> $oldController=$this->_controller;
<span class="ln">280</span> $this->_controller=$controller;
<span class="ln">281</span> $controller->init();
<span class="error"><span class="ln error-ln">282</span> $controller->run($actionID);
</span><span class="ln">283</span> $this->_controller=$oldController;
<span class="ln">284</span> }
<span class="ln">285</span> else
<span class="ln">286</span> throw new CHttpException(404,Yii::t('yii','Unable to resolve the request "{route}".',
<span class="ln">287</span> array('{route}'=>$route===''?$this->defaultController:$route)));
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#11 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/web/CWebApplication.php(141): <strong>CWebApplication</strong>-><strong>runController</strong>("admin/authentication/sa/logout") </div>
<div class="code"><pre><span class="ln">136</span> foreach(array_splice($this->catchAllRequest,1) as $name=>$value)
<span class="ln">137</span> $_GET[$name]=$value;
<span class="ln">138</span> }
<span class="ln">139</span> else
<span class="ln">140</span> $route=$this->getUrlManager()->parseUrl($this->getRequest());
<span class="error"><span class="ln error-ln">141</span> $this->runController($route);
</span><span class="ln">142</span> }
<span class="ln">143</span>
<span class="ln">144</span> /**
<span class="ln">145</span> * Registers the core application components.
<span class="ln">146</span> * This method overrides the parent implementation by registering additional core components.
</pre></div> </td>
</tr>
<tr class="trace core collapsed">
<td class="number">
#12 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/framework/base/CApplication.php(180): <strong>CWebApplication</strong>-><strong>processRequest</strong>() </div>
<div class="code"><pre><span class="ln">175</span> public function run()
<span class="ln">176</span> {
<span class="ln">177</span> if($this->hasEventHandler('onBeginRequest'))
<span class="ln">178</span> $this->onBeginRequest(new CEvent($this));
<span class="ln">179</span> register_shutdown_function(array($this,'end'),0,false);
<span class="error"><span class="ln error-ln">180</span> $this->processRequest();
</span><span class="ln">181</span> if($this->hasEventHandler('onEndRequest'))
<span class="ln">182</span> $this->onEndRequest(new CEvent($this));
<span class="ln">183</span> }
<span class="ln">184</span>
<span class="ln">185</span> /**
</pre></div> </td>
</tr>
<tr class="trace app collapsed">
<td class="number">
#13 </td>
<td class="content">
<div class="trace-file">
<div class="plus">+</div>
<div class="minus">–</div>
/usr/share/nginx/html/lsurveymaster/index.php(200): <strong>CApplication</strong>-><strong>run</strong>() </div>
<div class="code"><pre><span class="ln">195</span> die (sprintf('%s should be writable by the webserver (755 or 775).', $runtimePath));
<span class="ln">196</span> }
<span class="ln">197</span> }
<span class="ln">198</span>
<span class="ln">199</span>
<span class="error"><span class="ln error-ln">200</span> Yii::createApplication('LSYii_Application', $config)->run();
</span><span class="ln">201</span>
<span class="ln">202</span> /* End of file index.php */
<span class="ln">203</span> /* Location: ./index.php */
</pre></div> </td>
</tr>
</tbody></table>
</div>
<div class="version">
2015-01-05 01:54:24 nginx/1.4.6 <a href="http://www.yiiframework.com/">Yii Framework</a>/1.1.15 </div>
</div>
<script type="text/javascript">
/*<![CDATA[*/
var traceReg = new RegExp("(^|\\s)trace-file(\\s|$)");
var collapsedReg = new RegExp("(^|\\s)collapsed(\\s|$)");
var e = document.getElementsByTagName("div");
for(var j=0,len=e.length;j<len;j++){
if(traceReg.test(e[j].className)){
e[j].onclick = function(){
var trace = this.parentNode.parentNode;
if(collapsedReg.test(trace.className))
trace.className = trace.className.replace("collapsed", "expanded");
else
trace.className = trace.className.replace("expanded", "collapsed");
}
}
}
/*]]>*/
</script>
<script type="text/javascript">
/*<![CDATA[*/
if(typeof(console)=='object')
{
console.group("Application Log");
console.log("[01:54:23.967][trace][system.db.ar.CActiveRecord] Plugin.findAllByAttributes()");
console.log("[01:54:23.968][trace][system.db.CDbConnection] Opening DB connection");
console.log("[01:54:23.988][trace][system.db.CDbCommand] Querying SQL: SELECT * FROM \"lime_plugins\" \"t\" WHERE \"t\".\"active\"=:yp0. Bound with :yp0=1");
console.log("[01:54:24.003][trace][system.db.ar.CActiveRecord] SettingGlobal.findAll()");
console.log("[01:54:24.004][trace][system.db.CDbCommand] Querying SQL: SELECT * FROM \"lime_settings_global\" \"t\"");
console.log("[01:54:24.108][trace][system.db.ar.CActiveRecord] SettingGlobal.findByPk()");
console.log("[01:54:24.109][trace][system.db.CDbCommand] Querying SQL: SELECT * FROM \"lime_settings_global\" \"t\" WHERE \"t\".\"stg_name\"=\'updatelastcheck\' LIMIT 1");
console.groupEnd();
}
/*]]>*/
</script></body></html> | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | 141229 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | Firefox | ||||
| Database type & version | Postgresql 9.3 | ||||
| Server OS (if known) | Ubuntu 14.04 | ||||
| Webserver software & version (if known) | Nginx 1.4.6 | ||||
| PHP Version | 5.5.9 | ||||
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14839 |
|
|
Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14841 |
|
|
Version 2.05 Build 150211 released |
|
|
LimeSurvey: master e0fc0c88 2015-01-16 17:32 Details Diff |
Fixed issue 09435: Trying to get property of non-object with debug=2 and AuditLog enabled |
Affected Issues 09435 |
|
| mod - plugins/AuditLog/AuditLog.php | Diff File | ||
|
LimeSurvey: 2.06 4b879165 2015-01-16 18:27 Details Diff |
Fixed issue 09435: Trying to get property of non-object with debug=2 and AuditLog enabled |
Affected Issues 09435 |
|
| mod - plugins/AuditLog/AuditLog.php | Diff File | ||
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2015-01-05 02:03 | aesteban | New Issue | |
| 2015-01-05 02:03 | aesteban | Status | new => assigned |
| 2015-01-05 02:03 | aesteban | Assigned To | => aesteban |
| 2015-01-05 02:03 | aesteban | File Added: PHP notice.html | |
| 2015-01-16 17:38 | aesteban | Changeset attached | => LimeSurvey master e0fc0c88 |
| 2015-01-16 17:38 | aesteban | Note Added: 31467 | |
| 2015-01-16 17:38 | aesteban | Resolution | open => fixed |
| 2015-01-16 18:28 | aesteban | Changeset attached | => LimeSurvey 2.06 4b879165 |
| 2015-01-16 18:28 | aesteban | Note Added: 31468 | |
| 2015-01-16 18:28 | aesteban | Status | assigned => resolved |
| 2015-02-11 15:57 | c_schmitz | Note Added: 31671 | |
| 2015-02-11 15:57 | c_schmitz | Status | resolved => closed |