View Issue Details

This bug affects 1 person(s).
 10
IDProjectCategoryView StatusLast Update
08028Feature requestsSurvey takingpublic2016-04-12 10:48
ReporterMazi Assigned ToDenisChenu  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Summary08028: File upload dialogue window can't be styled
Description

When using the file upload question type, it is nearly impossible to adjust a template to style the iframe which is shown after having clicked the "Upload files" link.
Frame size as well as additional styles are hardcoded, which is bad.

Steps To Reproduce

View the source code of a file upload question type.

Additional Information
  1. To be able to also use that question type on smaller screens like smartphones, it definitely makes sense to have an additional question setting for iframe width and height. Because currently you have to scroll a lot to see the upload button etc.

  2. Please also remove the hardcoded styles and add some new classes for that frame.

TagsNo tags attached.
Attached Files
Screenshot_Uploader_iPhone.png (48,248 bytes)   
Screenshot_Uploader_iPhone.png (48,248 bytes)   
Bug heat10
Story point estimate
Users affected %

Relationships

child of 08178 closedDenisChenu Bug reports Upload file is broken in 2.05 (CRSF) 

Users monitoring this issue

DenisChenu

Activities

Mazi

Mazi

2013-08-31 13:02

updater   ~26116

Denis, can you have a look at this one? Carsten seems to be unavailable.

DenisChenu

DenisChenu

2013-08-31 13:16

developer   ~26117

Last edited: 2013-08-31 13:16

Mazi : i really think Upload Quetsion type is .... bad coded .

Don't work without JS etc ...

I take a look but just adding template.css and template.js : is this OK ?

PS:
Solution 2 is the best : remove ALL inline style

Mazi

Mazi

2013-08-31 13:20

updater   ~26118

Great, Denis. I think the core problem are the hardcoded styles, especially for the iframe size.

If we can move most of that to CSS, that would be nice. Another alterntive might be to set the size at the question attributes.

DenisChenu

DenisChenu

2013-08-31 14:33

developer   ~26119

Maybe :
Add a external

  • upload.js : a function to load the iframe+update the questionpart
  • upload.css

You can update css in template.css, and you can use your own function in template.js

But this one need a "No js ready upload system" then i put it in 2.1 system.

DenisChenu

DenisChenu

2013-09-25 14:17

developer   ~26362

Fix committed to 2.05 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13060

DenisChenu

DenisChenu

2013-09-25 15:22

developer   ~26365

Mazi: to have a real way to have your own "opup": use your own doFileUpload() js function in template.js now.

Think it's closed for 2.00.

DenisChenu

DenisChenu

2014-06-24 16:08

developer   ~30223

Bad function :i don't replace the 'modal dialog' open .....

Again : jsut a quick fix to allow to use own function in template.

DenisChenu

DenisChenu

2014-06-24 17:59

developer   ~30224

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14291

DenisChenu

DenisChenu

2014-06-24 18:12

developer   ~30225

2 fix:

  • with little screen : dialog is set to width of screen
  • Add openUploadModalDialog to allow update from template.js

Think whole system must be rewrite without a iframe but for 2.1 or Question plugin

Mazi

Mazi

2014-06-27 11:05

updater   ~30236

Re-opened on user request.

DenisChenu

DenisChenu

2014-06-27 11:21

developer   ~30237

Last edited: 2014-06-27 11:21

Yes, need more system on CSS for the upload.css. But it's a template issue. Not a core issue. Because
1: template can use own css in template.css
2: template can use own javascript too

I really don't have time on upload.css actually : move ro another, if another person have time

Mazi

Mazi

2014-06-27 11:50

updater   ~30238

Tony, what's your opinion on this?

DLange

DLange

2014-06-27 12:05

reporter   ~30239

The fixes from Denis have improved the issue (see attached screenshot from IPhone) as the dialogue is now visible (not mostly off-screen) and hence can at least be closed.
But the contents need to be made to fit horizontally and allow for scrolling (where needed) vertically.
The normal button on the bottom of the form is also still off-screen.

DenisChenu

DenisChenu

2014-06-27 12:10

developer   ~30240

With FireFox OS and Opera for mobile : the button return to survey is show.

But still the with f the page.

For scrolling : really more difficult : scrolling in phone is really a pity.
Alternative solution : open in a new window (for little screen only). Have to test.

Denis

DenisChenu

DenisChenu

2015-04-08 17:52

developer   ~31966

Have fixed some in CSS for SkeletonQuest, fix it and move ot to anyone after.

But : for a future release : upload QUestion in Plugin.

I think the bug here is to save the files in same place than Survey file. Really awfull.

DenisChenu

DenisChenu

2015-04-09 15:30

developer   ~31978

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15079

DenisChenu

DenisChenu

2015-04-10 16:01

developer   ~31983

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15084

c_schmitz

c_schmitz

2016-04-12 10:48

administrator   ~37253

Version 2.50+ Build 140413 released

Related Changesets

LimeSurvey: 2.05 41ae8c05

2013-09-25 12:17:38

DenisChenu

Details Diff
Fixed issue 08178: Upload file is broken in 2.05
Fixed issue 08028: File upload dialogue window can't be styled (partial)
Dev: can replace doFileUpload() js function by own function in template.js
Affected Issues
08028, 08178
mod - application/controllers/UploaderController.php Diff File
mod - scripts/uploader.js Diff File

LimeSurvey: master e4069b9b

2013-09-25 12:47:54

DenisChenu

Details Diff
New feature 08028: File upload system can be replaced
Dev: allow replacing doFileUpload(); js function
Dev: close it for 2.00, TODO for 2.05: seperate doFileUpload in multi simple function
Dev: for up to 2.05: new attribute in Plugin for file upload
Dev: for 2.1: rewrite file upload
Affected Issues
08028
mod - application/controllers/UploaderController.php Diff File
mod - scripts/uploader.js Diff File

LimeSurvey: master 52132007

2014-06-24 15:59:00

DenisChenu

Details Diff
Fixed issue 08028: File upload dialog function can be updated
Dev: Add openUploadModalDialog js function, only when doc ready
Dev: Fix the dialog width and heigth according to windows actual width and heigth
Dev: Quick fix: all system must be rewrite without a iframe
Affected Issues
08028
mod - scripts/modaldialog.js Diff File

LimeSurvey: master 458194ab

2015-04-09 13:29:18

DenisChenu

Details Diff
Fixed issue : Use capital on extension for file upload don't display file
Dev: some fix for 08028 file upload dialog in little screen
Dev: Fix only width set heigth, maybe have to adapat this too
Dev: fix some css for upload frame
Dev: HTML is really awfull (table with one line etc ..) fix with display:block, to do : fix it
Affected Issues
08028
mod - application/controllers/UploaderController.php Diff File
mod - scripts/modaldialog.js Diff File
mod - scripts/uploader.js Diff File
mod - styles-public/uploader.css Diff File

LimeSurvey: 2.06 de95f90b

2015-04-10 14:00:50

DenisChenu

Details Diff
Fixed issue 08028: File upload dialogue window can't be styled
Dev: except the table in "question" part all is done by css
Dev: fix some HTML and javascript
Affected Issues
08028
mod - application/controllers/UploaderController.php Diff File
mod - application/helpers/qanda_helper.php Diff File
mod - scripts/modaldialog.js Diff File
mod - scripts/uploader.js Diff File
add - styles-public/uploader-files.css Diff File
mod - styles-public/uploader.css Diff File

Issue History

Date Modified Username Field Change
2013-07-22 12:33 Mazi New Issue
2013-07-22 12:33 Mazi Status new => assigned
2013-07-22 12:33 Mazi Assigned To => sammousa
2013-07-22 14:56 sammousa Assigned To sammousa =>
2013-08-16 11:59 Mazi Assigned To => c_schmitz
2013-08-31 13:01 Mazi Issue Monitored: DenisChenu
2013-08-31 13:02 Mazi Note Added: 26116
2013-08-31 13:16 DenisChenu Note Added: 26117
2013-08-31 13:16 DenisChenu Note Edited: 26117
2013-08-31 13:20 Mazi Note Added: 26118
2013-08-31 14:33 DenisChenu Note Added: 26119
2013-09-15 18:32 c_schmitz Project Bug reports => Feature requests
2013-09-15 18:32 c_schmitz Assigned To c_schmitz =>
2013-09-16 13:15 Mazi Assigned To => DenisChenu
2013-09-20 14:48 DenisChenu Relationship added child of 08178
2013-09-25 14:17 DenisChenu Changeset attached => LimeSurvey 2.05 41ae8c05
2013-09-25 14:17 DenisChenu Note Added: 26362
2013-09-25 14:17 DenisChenu Resolution open => fixed
2013-09-25 15:21 DenisChenu Changeset attached => LimeSurvey master e4069b9b
2013-09-25 15:22 DenisChenu Note Added: 26365
2013-09-25 15:22 DenisChenu Status assigned => resolved
2013-09-25 15:22 DenisChenu Fixed in Version => 2.05+
2014-05-03 21:34 c_schmitz Status resolved => closed
2014-06-24 16:08 DenisChenu Note Added: 30223
2014-06-24 16:08 DenisChenu Status closed => feedback
2014-06-24 16:08 DenisChenu Resolution fixed => reopened
2014-06-24 16:08 DenisChenu Status feedback => new
2014-06-24 16:08 DenisChenu Severity @50@ => feature
2014-06-24 16:08 DenisChenu Status new => assigned
2014-06-24 16:08 DenisChenu Fixed in Version 2.05+ =>
2014-06-24 16:08 DenisChenu Target Version 2.05 beta =>
2014-06-24 17:59 DenisChenu Changeset attached => LimeSurvey master 52132007
2014-06-24 17:59 DenisChenu Note Added: 30224
2014-06-24 18:12 DenisChenu Note Added: 30225
2014-06-24 18:12 DenisChenu Status assigned => resolved
2014-06-24 18:12 DenisChenu Resolution reopened => fixed
2014-06-27 11:05 Mazi Note Added: 30236
2014-06-27 11:05 Mazi Status resolved => feedback
2014-06-27 11:05 Mazi Resolution fixed => reopened
2014-06-27 11:21 DenisChenu Note Added: 30237
2014-06-27 11:21 DenisChenu Note Edited: 30237
2014-06-27 11:21 DenisChenu Assigned To DenisChenu =>
2014-06-27 11:22 DenisChenu Assigned To => DenisChenu
2014-06-27 11:22 DenisChenu Status feedback => new
2014-06-27 11:22 DenisChenu Assigned To DenisChenu =>
2014-06-27 11:50 Mazi Assigned To => tpartner
2014-06-27 11:50 Mazi Status new => assigned
2014-06-27 11:50 Mazi Note Added: 30238
2014-06-27 12:01 DLange File Added: Screenshot_Uploader_iPhone.png
2014-06-27 12:05 DLange Note Added: 30239
2014-06-27 12:10 DenisChenu Note Added: 30240
2015-04-08 17:51 DenisChenu Assigned To tpartner => DenisChenu
2015-04-08 17:52 DenisChenu Note Added: 31966
2015-04-09 15:30 DenisChenu Changeset attached => LimeSurvey master 458194ab
2015-04-09 15:30 DenisChenu Note Added: 31978
2015-04-10 16:01 DenisChenu Changeset attached => LimeSurvey 2.06 de95f90b
2015-04-10 16:01 DenisChenu Note Added: 31983
2015-04-11 12:21 DenisChenu Status assigned => resolved
2015-04-11 12:21 DenisChenu Fixed in Version => 2.06+
2015-04-11 12:21 DenisChenu Resolution reopened => fixed
2016-04-12 10:48 c_schmitz Note Added: 37253
2016-04-12 10:48 c_schmitz Status resolved => closed
2021-08-02 18:22 guest Bug heat 8 => 10