Source Control Integration - LimeSurvey bugs and feature requests

3.x-LTS 54ed33fd 2020-09-29 08:24:50 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16634: Timer not getting reset after completion of the survey (running multiple surveys on the same browser) (#1590) Each timer registers itself in a local storage item identified by the Survey ID. This is used by the reset function to know which timers belong to the survey and are to be reset. The reset method was replaced by a function (in survey.js instead of timer.js) that reset all timers for a given survey. Also reviewed the reset method for preview mode.	Affected Issues 16634
	mod - application/controllers/survey/index.php	Diff File
	mod - application/helpers/frontend_helper.php	Diff File
	mod - application/helpers/qanda_helper.php	Diff File
	mod - application/views/survey/questions/question_timer/timer_footer.php	Diff File
	mod - assets/packages/limesurvey/survey.js	Diff File
	mod - assets/packages/questions/timer/package-lock.json	Diff File
	mod - assets/packages/questions/timer/src/main.js	Diff File
	mod - assets/packages/questions/timer/src/timeclass.js	Diff File
	mod - assets/packages/questions/timer/timer.js	Diff File
	mod - assets/packages/questions/timer/timer.min.js	Diff File
3.x-LTS 088239dc 2020-09-28 13:08:17 LimeBot Details Diff	Release 3.23.6+200929	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - docs/release_notes.txt	Diff File
master 3e596fbc 2020-09-28 13:02:55 LimeBot Details Diff	Release 4.3.18+200928	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - docs/release_notes.txt	Diff File
master 957332ae 2020-09-25 09:30:31 c_schmitz Details Diff	Fixed issue 16693: Export responses to SPSS button does not work	Affected Issues 16693
	mod - application/helpers/export_helper.php	Diff File
3.x-LTS ffc79040 2020-09-24 11:40:42 ollehar Committer: GitHub Details Diff	Dev: Merge pull request #1586 from gabrieljenik/dev/Edit-Question-Test	Attach Issues:
	mod - tests/controllers/ChangeQuestionTemplateTest.php	Diff File
	add - tests/controllers/EditQuestionTest.php	Diff File
	add - tests/data/surveys/limesurvey_survey_573387.lss	Diff File
3.x-LTS 0adf43a9 2020-09-23 19:22:44 gabrieljenik Details Diff	Revert "DEV: Edit Question Test" This reverts commit a1430f465e28bbbf3e8c92755c5beed29097dfec.	Attach Issues:
	mod - .travis.yml	Diff File
3.x-LTS 4b646348 2020-09-23 19:22:32 gabrieljenik Details Diff	Revert "DEV: Edit Question Test" This reverts commit 0e724d98c9655531c071e96fcc26c773c88bbe6f.	Attach Issues:
	mod - .travis.yml	Diff File
3.x-LTS f57b60b7 2020-09-23 19:20:23 gabrieljenik Details Diff	Revert "DEV: Edit Question Test" This reverts commit 4666a5896d059db5ecfcc7c1d20ed29c16c3af6a.	Attach Issues:
	mod - .travis.yml	Diff File
	mod - tests/TestBaseClass.php	Diff File
	mod - tests/controllers/AEditQuestionTest.php	Diff File
	mod - tests/controllers/ChangeQuestionTemplateTest.php	Diff File
3.x-LTS 4d35c27d 2020-09-23 19:19:59 gabrieljenik Details Diff	Revert "DEV: Edit Question Test" This reverts commit 77b229d11f18bbb2246e8c90afb9d14db9ee183e.	Attach Issues:
	mod - tests/TestBaseClass.php	Diff File
3.x-LTS 5fb6b7d7 2020-09-23 18:55:21 gabrieljenik Details Diff	DEV: Edit Question Test Debugging test collisions	Attach Issues:
	mod - tests/controllers/ChangeQuestionTemplateTest.php	Diff File
	add - tests/data/surveys/limesurvey_survey_573387.lss	Diff File
3.x-LTS 77b229d1 2020-09-23 17:56:14 gabrieljenik Details Diff	DEV: Edit Question Test Debugging test collisions	Attach Issues:
	mod - tests/TestBaseClass.php	Diff File
3.x-LTS 4666a589 2020-09-23 17:18:58 gabrieljenik Details Diff	DEV: Edit Question Test Debugging test collisions	Attach Issues:
	mod - .travis.yml	Diff File
	mod - tests/TestBaseClass.php	Diff File
	mod - tests/controllers/AEditQuestionTest.php	Diff File
	mod - tests/controllers/ChangeQuestionTemplateTest.php	Diff File
3.x-LTS 0e724d98 2020-09-23 16:06:28 gabrieljenik Details Diff	DEV: Edit Question Test Testing changing the order in which the tests run	Attach Issues:
	mod - .travis.yml	Diff File
3.x-LTS a1430f46 2020-09-23 15:49:31 gabrieljenik Details Diff	DEV: Edit Question Test Run single test	Attach Issues:
	mod - .travis.yml	Diff File
3.x-LTS 540de77e 2020-09-23 11:47:08 ollehar Committer: GitHub Details Diff	Fixed issue 16647: Can't select seperator for CPDB export - export doesn't recognise text Dev: Merge pull request #1599 from gabrieljenik/bug/16647--Can't-select-seperator-for-CPDB-export---export-doesnt-recognise-text	Affected Issues 16647
	mod - application/helpers/export_helper.php	Diff File
3.x-LTS a58ef3a4 2020-09-22 21:42:02 c_schmitz Details Diff	Fixed issue: Accidental double deactivation throws database error	Attach Issues:
	mod - application/controllers/admin/surveyadmin.php	Diff File
master d3037f91 2020-09-22 21:42:02 c_schmitz Details Diff	Fixed issue: Accidental double deactivation throws database error	Attach Issues:
	mod - application/controllers/admin/surveyadmin.php	Diff File
3.x-LTS e9b817f5 2020-09-22 21:03:15 gabrieljenik Details Diff	DEV: Edit Question Test Use another way of accesing f #cke_question_en	Attach Issues:
	mod - tests/controllers/EditQuestionTest.php	Diff File
3.x-LTS 5f58ca88 2020-09-22 16:19:59 gabrieljenik Details Diff	Fixed issue 16647: Can't select seperator for CPDB export - export doesn't recognise text Used 'fputcsv' in CPDBExport() with default args.	Affected Issues 16647
	mod - application/helpers/export_helper.php	Diff File
3.x-LTS bd96925a 2020-09-22 15:14:37 gabrieljenik Details Diff	DEV: Edit Question Test Increase sleep time to see if #cke_question_en is found	Attach Issues:
	mod - tests/controllers/EditQuestionTest.php	Diff File
3.x-LTS dec1f30e 2020-09-22 10:45:33 LimeBot Details Diff	Release 3.23.5+200923	Attach Issues:
	mod - application/config/version.php	Diff File
	mod - docs/release_notes.txt	Diff File
3.x-LTS 539e6c9f 2020-09-22 09:39:02 gabrieljenik Committer: GitHub Details Diff	Fixed issue 15994: Batch-Edit shows "lskeep" after modification of email status (#1584) Code Review. Created a checkbox for "emailstatus" edit only Don't update "email" if email is empty even if checkbox is checked (no way to set [empty string] to email with Batch edit Removed placeholder for emailstatus. It was confusing.	Affected Issues 15994
	mod - application/controllers/admin/tokens.php	Diff File
	mod - application/views/admin/token/massive_actions/_update.php	Diff File
3.x-LTS dbd8a8e4 2020-09-22 09:38:33 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16633: Error message when changing the data policy message language unless I check the box (#1574) * Fixed issue 16633: Error message when changing the data policy message language unless I check the box Making a form of its own for the language changer of the first page. This form as only have the language will not trigger server side validation of the policy. This is how it is in LS4 * Revert "Fixed issue 16633: Error message when changing the data policy message language unless I check the box" This reverts commit a48b2b5ff950d7ab2904575d8feacd072783b198. * Fixed issue 16633: Error message when changing the data policy message language unless I check the box Making a form of its own for the language changer of the first page. This form as only have the language will not trigger server side validation of the policy. This is how it is in LS4. Language changer from menu also updated.	Affected Issues 16633
	mod - application/helpers/SurveyRuntimeHelper.php	Diff File
	mod - themes/survey/vanilla/views/subviews/content/firstpage.twig	Diff File
	mod - themes/survey/vanilla/views/subviews/messages/warnings.twig	Diff File
	mod - themes/survey/vanilla/views/subviews/navigation/language_changer_first_page.twig	Diff File
3.x-LTS 3c292463 2020-09-21 16:47:00 c_schmitz Details Diff	Fixed issue: SPSS export broken for numbers > 1000	Attach Issues:
	mod - application/helpers/export_helper.php	Diff File
master 30690752 2020-09-21 16:47:00 c_schmitz Details Diff	Fixed issue: SPSS export broken for numbers > 1000	Attach Issues:
	mod - application/helpers/export_helper.php	Diff File

Changesets: LimeSurvey