Relationship Graph

View IssueDependency GraphShow Summary
Relationship Graph
related to related to child of child of duplicate of duplicate of

View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 10
IDProjectCategoryView StatusDate SubmittedLast Update
06960Bug reportsOtherpublic2012-11-26 15:552012-12-04 13:16
ReporterMexxi Assigned ToDenisChenu  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.00+ 
Fixed in Version2.00+ 
Summary06960: Unchecking of "other" option in multiple choice questions impossible if text box empty
Description

Unchecking the "other" option without text in the text box is impossible. You have to check/uncheck a different checkbox first before the checkbox of the "other"-option is updated properly. Found in Limesurvey 1.92. Still present in latest Limesurvey 2.00+ Build 121121. The error occurs repeatedly on Xampp (those of the last few weeks), but also real servers.

A one question survey that also shows this behavior has been appended.

Steps To Reproduce

check other option
uncheck other option --> check mark will flash but still remain

Additional Information

entering text in the text box allows for proper unchecking

TagsNo tags attached.
Attached Files
limesurvey_unchecking_bug.lss (16,561 bytes)
limesurvey_survey_multichecktesting.lss (18,347 bytes)
Bug heat10
Complete LimeSurvey version number (& build)121121
I will donate to the project if issue is resolvedNo
BrowserFirefox 16.02, Google Chrome 23.0.1271.64, Opera 12.02 Build 1578
Database type & versionMySQL 5.5.27, Protocol version 10
Server OS (if known)Windows 7 Ultimate x64
Webserver software & version (if known)Xampp Win32 1.8.1 VC9
PHP Version5.4.7

Relationships

Relationship GraphDependency Graph
related to 06924 closedDenisChenu Citronade template, no checkbox for multiple choice other option 

Activities

Mexxi

Mexxi

2012-11-26 18:26

reporter   ~22547

In the meantime I tested Version 1.90+ Build 9130 and Build 9642 and both versions don't have this bug.
DenisChenu

DenisChenu

2012-11-27 09:32

developer   ~22599

Still thinking we have to remove the "other checkbox" in multi question.

See http://bugs.limesurvey.org/view.php?id=6924
tpartner

tpartner

2012-11-28 12:54

partner   ~22618

Yeah, but a reason to keep the checkbox is that it allows for one-click removal of the "other" value.
DenisChenu

DenisChenu

2012-11-28 14:35

developer   ~22622

Ah, yep, you're right. Only with js activated.

Have the patch, just todo testing in IE6/7/8/9. Working great.

Maybe put it in extra js or in survey_runtime .

tpartner: you want it :

  • inline
  • extra js file
  • survey-runtime.js

Denis
tpartner

tpartner

2012-11-28 19:58

partner   ~22654

Denis, do you have a patch?

I can test in IE 6-9.
DenisChenu

DenisChenu

2012-11-29 11:17

developer   ~22675

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10548
DenisChenu

DenisChenu

2012-11-29 11:19

developer   ~22676

Tony, you can test and make some other modification on GIT version.
Tested on IE8 too ;)
DenisChenu

DenisChenu

2012-11-29 11:22

developer   ~22677

Import a test file with array filtering and condition on other
DenisChenu

DenisChenu

2012-11-29 13:47

developer   ~22701

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=10562
c_schmitz

c_schmitz

2012-12-04 13:16

administrator   ~22867

LimeSurvey 2.0+ build 121204 released.

Related Changesets

LimeSurvey: master 7487cf7b

2012-11-29 10:16:02

DenisChenu

Details Diff 		Fixed issue 06960: Unchecking of "other" option in multiple choice questions impossible if text box empty
Dev: return false on click, but put error on text input and focus in
Dev: Add inline visibility:hidden style for user without javascript, remove it in javascript
Dev: can be put in external js file, but use .live or .delegate to have it before document.loading		 Affected Issues
06960
mod - application/helpers/qanda_helper.php Diff File

LimeSurvey: 2.1 bab910d8

2012-11-29 11:25:49

DenisChenu

Details Diff 		Fixed issue 06960: Unchecking of "other" option in multiple choice questions impossible if text box empty
Dev: return false on click, but put error on text input and focus in
Dev: Add inline visibility:hidden style for user without javascript, remove it in javascript
Dev: can be put in external js file, but use .live or .delegate to have it before document.loading		 Affected Issues
06960
mod - application/modules/CheckQuestion.php Diff File

Issue History

Date Modified Username Field Change
2012-11-26 15:55 Mexxi New Issue
2012-11-26 15:55 Mexxi File Added: limesurvey_unchecking_bug.lss
2012-11-26 18:26 Mexxi Note Added: 22547
2012-11-27 09:32 DenisChenu Note Added: 22599
2012-11-27 09:32 DenisChenu Relationship added related to 06924
2012-11-27 14:34 DenisChenu Assigned To => DenisChenu
2012-11-27 14:34 DenisChenu Status new => assigned
2012-11-28 12:54 tpartner Note Added: 22618
2012-11-28 14:35 DenisChenu Note Added: 22622
2012-11-28 19:58 tpartner Note Added: 22654
2012-11-28 20:40 tpartner Issue Monitored: tpartner
2012-11-29 11:17 DenisChenu Changeset attached => LimeSurvey master 7487cf7b
2012-11-29 11:17 DenisChenu Note Added: 22675
2012-11-29 11:17 DenisChenu Resolution open => fixed
2012-11-29 11:19 DenisChenu Note Added: 22676
2012-11-29 11:22 DenisChenu File Added: limesurvey_survey_multichecktesting.lss
2012-11-29 11:22 DenisChenu Note Added: 22677
2012-11-29 12:30 DenisChenu Status assigned => resolved
2012-11-29 12:30 DenisChenu Fixed in Version => 2.00+
2012-11-29 13:47 DenisChenu Changeset attached => LimeSurvey 2.1 bab910d8
2012-11-29 13:47 DenisChenu Note Added: 22701
2012-12-04 13:16 c_schmitz Note Added: 22867
2012-12-04 13:16 c_schmitz Status resolved => closed
2021-08-02 18:14 guest Bug heat 8 => 10