View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
09847Bug reportsOtherpublic2015-12-08 17:19
Reporterhhug Assigned Toc_schmitz  
PrioritynormalSeveritypartial_block 
Status closedResolutionfixed 
Product Version2.06+ 
Fixed in Version2.06+ 
Summary09847: Non integer numerical input is saved as rounded integer to the database
Description

Real numerical input to a simple numerical question, with setting integer only = no, is written as rounded integer to the database: 1,49 is saved as 1; 3,79 is saved as 4 etc.

Steps To Reproduce

See attached lss-file.

TagsNo tags attached.
Attached Files
Bug heat6
Complete LimeSurvey version number (& build)150825
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionMySQL Version 5.5.38-1
Server OS (if known)Linux
Webserver software & version (if known)Apache
PHP Version5.3.29

Relationships

child of 09852 closedDenisChenu DB error when trying to activate survey (only PostgresQL) 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-08-27 16:11

developer   ~33022

Last edited: 2015-08-27 16:14

Bug in db
MysqlSchema->getColumnType(DECIMAL(10,30)) return DECIMAL only.

It must be return $baseType.$param , no ?

sammousa

sammousa

2015-08-28 09:04

reporter   ~33024

Yes, shnoulle did you fix that?

DenisChenu

DenisChenu

2015-08-28 09:09

developer   ~33025

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15814

DenisChenu

DenisChenu

2015-08-28 09:34

developer   ~33026

Fixed for table creation, 3.0 need to be done. What for old table DB update ... ?

DenisChenu

DenisChenu

2015-08-29 09:41

developer   ~33031

@Carsten : give it to you to control if mssql need a fix too. I think yes but unsure.
For 3.0 : i think i fix it with adding a default to DECIMAL.

DenisChenu

DenisChenu

2015-08-29 14:24

developer   ~33036

Last edited: 2015-08-29 14:38

<s>Just for information : Yii::app()->db->schema->getColumnType("decimal not null"); goes to a memory error</s>

<s>Same for Yii::app()->db->schema->getColumnType("string ");</s>

I'm a silly idiot .... Call self and not parent ....

DenisChenu

DenisChenu

2015-09-01 16:02

developer   ~33056

Fix committed to develop branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=15856

DenisChenu

DenisChenu

2015-09-03 18:08

developer   ~33058

@c_schmitz : i can't test with mssql ? Fixed with pg and my.

I think same patch can be applied with msSQL but really unsure.

c_schmitz

c_schmitz

2015-12-08 17:19

administrator   ~33765

Works fine for me with MSSQL

Related Changesets

LimeSurvey: master 334366c3

2015-08-28 07:07:52

DenisChenu

Details Diff
Fixed issue 09847: Non integer numerical input is saved as rounded integer to the database
Dev: decimal(30,10) is found at DECIMAL for Yii, no params
Dev: Same for PGsql
Dev: @todo : test with MsSQL
Dev: Survey table creation is broken since ?
Affected Issues
09847
mod - application/core/db/MysqlSchema.php Diff File
mod - application/core/db/PgsqlSchema.php Diff File

LimeSurvey: master 77e5aec5

2015-08-28 07:30:09

DenisChenu

Details Diff
Dev: 334366c38c0bbc711bd8147e7b65264a1b7052cc Child
Dev: potential issue with something like DECIMAL (30,10) not null
Affected Issues
09847
mod - application/core/db/MysqlSchema.php Diff File
mod - application/core/db/PgsqlSchema.php Diff File

LimeSurvey: master 93f50c27

2015-08-29 12:59:04

DenisChenu

Details Diff
Fixed issue 09852: DB error when trying to activate survey (only PostgresQL)
Dev: 334366c38c0bbc711bd8147e7b65264a1b7052cc child ( 09847 fix )
Dev: more test ... word can have space .. (here character varying (255))
Affected Issues
09847, 09852
mod - application/core/db/MysqlSchema.php Diff File
mod - application/core/db/PgsqlSchema.php Diff File

LimeSurvey: develop 3b16afca

2015-09-01 14:02:26

DenisChenu

Details Diff
Fixed issue 09847: Non integer numerical input is saved as rounded integer to the database
Dev: decimal(30,10) is found at DECIMAL for Yii, no params
Dev: Same for PGsql
Dev: @todo : test with MsSQL
Dev: fix childrens too
Dev: @sammousa : please do some test ;)
Affected Issues
09847
mod - application/core/db/PgsqlSchema.php Diff File
mod - application/core/db/SmartColumnTypeTrait.php Diff File

Issue History

Date Modified Username Field Change
2015-08-27 15:04 hhug New Issue
2015-08-27 15:04 hhug File Added: limesurvey_survey_186175.lss
2015-08-27 15:51 DenisChenu Assigned To => DenisChenu
2015-08-27 15:51 DenisChenu Status new => confirmed
2015-08-27 16:11 DenisChenu Note Added: 33022
2015-08-27 16:11 DenisChenu Assigned To DenisChenu => sammousa
2015-08-27 16:11 DenisChenu Status confirmed => assigned
2015-08-27 16:14 DenisChenu Note Edited: 33022
2015-08-27 16:14 DenisChenu Note Edited: 33022
2015-08-28 09:04 sammousa Assigned To sammousa => DenisChenu
2015-08-28 09:04 sammousa Note Added: 33024
2015-08-28 09:09 DenisChenu Changeset attached => LimeSurvey master 334366c3
2015-08-28 09:09 DenisChenu Note Added: 33025
2015-08-28 09:09 DenisChenu Resolution open => fixed
2015-08-28 09:32 DenisChenu Changeset attached => LimeSurvey master 77e5aec5
2015-08-28 09:34 DenisChenu Note Added: 33026
2015-08-29 09:40 DenisChenu Assigned To DenisChenu => c_schmitz
2015-08-29 09:41 DenisChenu Note Added: 33031
2015-08-29 11:57 DenisChenu Relationship added child of 09852
2015-08-29 14:24 DenisChenu Note Added: 33036
2015-08-29 14:26 DenisChenu Note Edited: 33036
2015-08-29 14:38 DenisChenu Note Edited: 33036
2015-08-29 15:01 DenisChenu Changeset attached => LimeSurvey master 93f50c27
2015-09-01 16:02 DenisChenu Changeset attached => LimeSurvey develop 3b16afca
2015-09-01 16:02 DenisChenu Note Added: 33056
2015-09-01 16:02 DenisChenu Assigned To c_schmitz => DenisChenu
2015-09-03 18:07 DenisChenu Assigned To DenisChenu => c_schmitz
2015-09-03 18:08 DenisChenu Note Added: 33058
2015-12-08 17:19 c_schmitz Note Added: 33765
2015-12-08 17:19 c_schmitz Status assigned => closed
2015-12-08 17:19 c_schmitz Fixed in Version => 2.06+