View Issue Details

IDProjectCategoryView StatusLast Update
09767Development Otherpublic2016-06-04 14:25
ReporterDenisChenuAssigned To 
PrioritynormalSeverityminor 
Status newResolutionopen 
Product Version2.06 
Target VersionFixed in Version 
Summary09767: Remove cancelBubbleThis function
Description

All checkbox have cancelBubbleThis function.
This break a lot of own javascript :

  • Using .on("click","input:checkbox") don't work
  • Using .on("click",".checkbox-item",function(){ console.log($(this).find(":checkbox").is(":checked"); } can return false information.
Additional Information

Think it was added a long time ago for td click but function was updated now.
https://github.com/LimeSurvey/LimeSurvey/blob/master/scripts/survey_runtime.js#L378

TagsNo tags attached.

Activities

DenisChenu

DenisChenu

2015-07-08 18:04

developer   ~32657

@Tony : do you remind when / why this old function was added ?
Do you think we can remove it ?

tpartner

tpartner

2015-07-09 15:01

developer   ~32664

Hi Denis. I have no idea when or why that was added. I don't see any problem with removing it now.

DenisChenu

DenisChenu

2015-07-09 16:06

developer   ~32665

Last edited: 2015-07-09 16:07

View 2 revisions

Tony : do you have an IE8 for testing purpose ?
I can remove it, send you a link to test ?

And: do you have too some difficulty with checkbox managing with jquery ?

tpartner

tpartner

2015-07-09 17:35

developer   ~32666

Yes, I have a native IE8 installation.

I normally use something like this for checkboxes:

$('input:checkbox').on('change', function(e) {
console.log($(this).prop('checked'));
});

DenisChenu

DenisChenu

2015-07-09 18:07

developer   ~32667

And it work ? change and not click ... Rigth , the best ...

Issue History

Date Modified Username Field Change
2015-07-08 18:03 DenisChenu New Issue
2015-07-08 18:04 DenisChenu Note Added: 32657
2015-07-08 18:04 DenisChenu Assigned To => tpartner
2015-07-08 18:04 DenisChenu Status new => feedback
2015-07-09 15:01 tpartner Note Added: 32664
2015-07-09 15:01 tpartner Assigned To tpartner => DenisChenu
2015-07-09 15:01 tpartner Status feedback => assigned
2015-07-09 16:06 DenisChenu Note Added: 32665
2015-07-09 16:07 DenisChenu Note Edited: 32665 View Revisions
2015-07-09 17:35 tpartner Note Added: 32666
2015-07-09 18:07 DenisChenu Note Added: 32667
2016-05-31 10:34 DenisChenu Assigned To DenisChenu =>
2016-06-04 14:25 DenisChenu Status assigned => new