View Issue Details

IDProjectCategoryView StatusLast Update
09704Development Pluginspublic2015-07-01 13:07
ReporterDenisChenu Assigned To 
PrioritynormalSeverityminor 
Status newResolutionopen 
Product Version3.x 
Summary09704: Using same "widget" for plugin and core.
DescriptionI think it's best to use same system for Core and for Plugins.

Reason for this:
- Fix a bug for core => no need to find if we need to fix it for plugin settings
- The HTML shown for plugin is exactly the same than plugin. No need to manage different css for one and another one.
- Adding a new widget in core => plugin can directly use this new widget.
- Improve settingWidget for plugin <=> improve core settings

But Sam have another idea. Then let's talk.
https://github.com/LimeSurvey/LimeSurvey/commit/1456edfbfdac2c1c938cb00769c40cb0ac2c9deb#commitcomment-11784771
Additional InformationIf core need "active form" then allow plugin to use active form too, and update https://github.com/LimeSurvey/LimeSurvey/tree/master/application/extensions/SettingsWidget to use activeForm if settings give a form.
TagsNo tags attached.

Relationships

related to 09697 new Big "checkbox" list OR multiple select 

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-06-30 16:36

developer   ~32579

PS: Authentification is the first screen seen by user, and see select2, after simple dropdown except where it use settingsWidget.

I think it's seems strange for user.

Alternative is to try to have same "presentation" for Core GUI and Plugin GUI, but here : 2 times work.
sammousa

sammousa

2015-07-01 12:03

reporter   ~32591

I think for core forms we should use whatever the framework provides, giving us maximum flexibility.

For now the plugin side should stay the same and settingswidget is more or less a form builder that takes configuration and renders a form using Html helper functions.
DenisChenu

DenisChenu

2015-07-01 13:03

developer   ~32592

Last edited: 2015-07-01 13:07

View 2 revisions

Then moving settingsWidget part to using same "HTML" than Core form ?

And for select2 : Not needed in plugin settinngs, can help on some core form control ... etc ...
And for HTML : settingsWidget use same HTML editor than core ?

Issue History

Date Modified Username Field Change
2015-06-21 19:41 DenisChenu New Issue
2015-06-22 10:30 DenisChenu Relationship added related to 09697
2015-06-23 14:34 DenisChenu Description Updated View Revisions
2015-06-30 16:36 DenisChenu Note Added: 32579
2015-07-01 12:03 sammousa Note Added: 32591
2015-07-01 13:03 DenisChenu Note Added: 32592
2015-07-01 13:07 DenisChenu Note Edited: 32592 View Revisions