View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
09555Bug reportsResponse browsingpublic2015-03-05 18:362015-05-07 14:54
ReporterDenisChenu Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.06+ 
Target Version2.06+Fixed in Version2.06+ 
Summary09555: Hiding columns in browse response can break Javascript
Description

Hidding some column in browse response can broke Javascript in another survey

Steps To Reproduce

Get a big survey with lot of column
Hide some column in this survey in browse
Get a litlle survey with less response
Wait for the jqgrid ....

Look at console
TypeError: colModels[i] is undefined
http://206.sondages.pro/scripts/admin/listresponse.js
Line 51

Additional Information

Using on cookie for all survey seems bad, removing the cookie['detailedresponsecolumns']

Fix the issue .....

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)150305
I will donate to the project if issue is resolved
BrowserFireFox 36 (Linux)
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

Relationship GraphDependency Graph
child of 09545 closedc_schmitz Review Upload question type 

Users monitoring this issue

There are no users monitoring this issue.

Activities

c_schmitz

c_schmitz

2015-04-29 14:50

administrator   ~32071

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15121
c_schmitz

c_schmitz

2015-04-29 15:01

administrator   ~32072

Last edited: 2015-04-29 16:01

Hello Tony,

I need your JS-Fu here. The PHP part works fine - however after having hidden all columns (except for the standard ones), leaving the browse responses screen and entering it again the 'select columns button' is not clickable.
I am pretty sure the ColModel is properly loaded, so maybe it is a bug in jqGrid?
DenisChenu

DenisChenu

2015-04-30 12:43

developer   ~32079

Last edited: 2015-04-30 12:44

Hi c_schmitz : i try to reproduce:
however after having hidden all columns (except for the standard ones), leaving the browse responses screen and entering it again the 'select columns button' is not clickable.

But i can't disable all column : one is always selected.

But here : css issue if the table is to "tight" : the next/previous button goes in the first part.

#pager_center is up #pager_left . Surely can be fixed with some css. I have a look.

PS: removing the "forced" width on #pager_left fix the issue. Have to find the jqgrid way ....
tpartner

tpartner

2015-04-30 12:59

partner   ~32080

I have no idea what Denis said so I'm going to hand it to him :)
DenisChenu

DenisChenu

2015-04-30 14:05

developer   ~32081

http://www.trirand.com/blog/?page_id=393/feature-request/feature-set-table-pager-width#p16924
DenisChenu

DenisChenu

2015-04-30 14:10

developer   ~32082

Fix committed to 2.06 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15123
c_schmitz

c_schmitz

2015-05-07 14:54

administrator   ~32110

Releasing 2.06RC1

Related Changesets

LimeSurvey: 2.06 ce6a8eea

2015-04-29 12:42:40

c_schmitz

Details Diff 		Fixed issue 09555: Hiding columns in browse response can break Javascript
Dev Hidden columns are now saved in the survey session		 Affected Issues
09555
mod - application/controllers/admin/responses.php Diff File
mod - application/views/admin/responses/listResponses_view.php Diff File
mod - scripts/admin/listresponse.js Diff File

LimeSurvey: 2.06 2df4d47c

2015-04-30 12:10:14

DenisChenu

Details Diff 		Dev: fixed issue 09555: pager_center can overlap pager_left Affected Issues
09555
mod - styles/adminstyle.css Diff File

Issue History

Date Modified Username Field Change
2015-03-05 18:36 DenisChenu New Issue
2015-03-05 18:36 DenisChenu Project Development => Bug reports
2015-03-05 18:37 DenisChenu Relationship added child of 09545
2015-03-05 18:37 DenisChenu LimeSurvey build number OR git commit ID => 150305
2015-03-05 18:37 DenisChenu Browser => FireFox 36 (Linux)
2015-03-05 18:37 DenisChenu Database & DB-Version => not relevant
2015-03-05 18:37 DenisChenu Operating System (Server) => not relevant
2015-03-05 18:37 DenisChenu Webserver software & version => not relevant
2015-03-05 18:37 DenisChenu PHP Version => not relevant
2015-03-05 18:37 DenisChenu Summary Javascript in browse response can broke => Hiding columns in browse response can broke Javascript
2015-04-29 14:40 c_schmitz Assigned To => c_schmitz
2015-04-29 14:40 c_schmitz Status new => assigned
2015-04-29 14:50 c_schmitz Changeset attached => LimeSurvey 2.06 ce6a8eea
2015-04-29 14:50 c_schmitz Note Added: 32071
2015-04-29 14:50 c_schmitz Resolution open => fixed
2015-04-29 14:50 c_schmitz Status assigned => resolved
2015-04-29 14:50 c_schmitz Fixed in Version => 2.06+
2015-04-29 14:50 c_schmitz Summary Hiding columns in browse response can broke Javascript => Hiding columns in browse response can break Javascript
2015-04-29 14:59 c_schmitz Assigned To c_schmitz => tpartner
2015-04-29 14:59 c_schmitz Status resolved => assigned
2015-04-29 15:01 c_schmitz Note Added: 32072
2015-04-29 16:01 c_schmitz Note Edited: 32072
2015-04-30 12:43 DenisChenu Note Added: 32079
2015-04-30 12:44 DenisChenu Note Edited: 32079
2015-04-30 12:59 tpartner Note Added: 32080
2015-04-30 13:00 tpartner Assigned To tpartner => DenisChenu
2015-04-30 14:05 DenisChenu Note Added: 32081
2015-04-30 14:10 DenisChenu Changeset attached => LimeSurvey 2.06 2df4d47c
2015-04-30 14:10 DenisChenu Note Added: 32082
2015-04-30 14:14 DenisChenu Status assigned => resolved
2015-04-30 14:14 DenisChenu Assigned To DenisChenu => c_schmitz
2015-05-07 14:54 c_schmitz Note Added: 32110
2015-05-07 14:54 c_schmitz Status resolved => closed