View Issue Details

This bug affects 1 person(s).
 2
IDProjectCategoryView StatusLast Update
09537Bug reportsPluginspublic2015-04-15 16:23
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.06+ 
Fixed in Version2.06alpha 
Summary09537: Plugin manager : legend without fieldset
Description

HTML produced by plugin manager use legend but no fieldset.

Steps To Reproduce

Just have a look at HTML produced and
http://www.w3.org/wiki/HTML/Elements/legend

Additional Information

I think we need a real for with all neded fieldset and legend.

With form:
<form><fieldset>
The settings
</fieldset></form>

Without form
<fieldset>
The settings
</fieldset>

Just replacing div by fieldset (and allways add fieldset)

TagsNo tags attached.
Bug heat2
Complete LimeSurvey version number (& build)140221
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 09509 closedsammousa Bug reports [debug == 2] Crash at admin login when LDAP plugin enabled 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-02-27 10:12

developer   ~31726

Last edited: 2015-02-27 10:12

I think we must have a ability to have this too:

<fieldset>
<legend>Group one of settings</legend>

  • setting 1
  • setting 2
    </fieldset>
    <fieldset>
    <legend>Group two of settings</legend>
  • setting 3
  • setting 4
    </fieldset>

And more
<fieldset>
<legend>Group one of settings</legend>

  • setting 1
  • setting 2
  • <fieldset>
  • <legend>SUB Group one of settings</legend>
    • setting 3.1
    • setting 3.3
  • </fieldset>
  • setting 4
    </fieldset>
DenisChenu

DenisChenu

2015-03-04 12:14

developer   ~31759

Can wait a new build or 2.07

DenisChenu

DenisChenu

2015-04-02 08:52

developer   ~31940

Fixed here :https://github.com/LimeSurvey/LimeSurvey/pull/301

Always add fieldset an ul : It's a list of settings. Not sure to insert buttons in field ?

Related Changesets

LimeSurvey: 2.06 550b5ca7

2015-04-15 14:22:29

DenisChenu

Details Diff
Merge pull request #301 from Shnoulle/206_reviewsettingsHTML

Dev: review HTML for SettingWidget (todo for ls3)
Affected Issues
09537
mod - application/extensions/SettingsWidget/SettingsWidget.php Diff File
mod - application/extensions/SettingsWidget/assets/settingswidget.css Diff File
mod - application/views/admin/survey/subview/tabGeneralEditSurvey_view.php Diff File
mod - application/views/admin/survey/subview/tabPresentation_view.php Diff File

Issue History

Date Modified Username Field Change
2015-02-21 16:21 DenisChenu New Issue
2015-02-21 16:23 DenisChenu Target Version => 2.06+
2015-02-22 14:29 DenisChenu Relationship added related to 09509
2015-02-27 10:12 DenisChenu Note Added: 31726
2015-02-27 10:12 DenisChenu Note Edited: 31726
2015-03-04 12:14 DenisChenu Target Version 2.06+ =>
2015-03-04 12:14 DenisChenu Note Added: 31759
2015-04-02 08:52 DenisChenu Note Added: 31940
2015-04-15 16:23 DenisChenu Changeset attached => LimeSurvey 2.06 550b5ca7
2015-04-15 16:23 DenisChenu Status new => closed
2015-04-15 16:23 DenisChenu Assigned To => DenisChenu
2015-04-15 16:23 DenisChenu Resolution open => fixed
2015-04-15 16:23 DenisChenu Fixed in Version => 2.06alpha