08509: Expression manager inserting <span> elements incorrectly

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

08509	Bug reports	Survey taking	public	2014-01-05 21:29	2014-01-09 23:31

Reporter	tpartner	Assigned To	c_schmitz
Priority	high	Severity	partial_block
Status	closed	Resolution	fixed
Product Version	2.05+
Target Version	2.05+	Fixed in Version	2.05+

Summary	08509: Expression manager inserting <span> elements incorrectly
Description	When running a survey in "all-in-one", mode values that are piped into the end message and into the end URL are wrapped in span elements. If the piped value is used in a parameter or attribute it breaks the URL or attribute (see attached screenshot).
Steps To Reproduce	Create a survey (attached) Run in "all-in-one" mode Add an equation question Pipe an expression manager value into the end message or end URL something like "http://somedomain.com/index.php?a={equation1.value}"
Additional Information	Not sure what the fix is but I suspect it is because $staticReplacement returns false at line 1903 of em_core_helper.php. In my opinion, this should always be true in end messages, end URLs and emails.
Tags	No tags attached.
Attached Files	limesurvey_survey_338692(1).lss (14,014 bytes) spans_1.png (27,005 bytes) spans_1.png (27,005 bytes)

Bug heat	6
Complete LimeSurvey version number (& build)	33fd96904bc223545e1b8fc7f857
I will donate to the project if issue is resolved	No
Browser	N/A
Database type & version	N/A
Server OS (if known)	N/A
Webserver software & version (if known)	N/A
PHP Version	N/A

User List	There are no users monitoring this issue.

tpartner 2014-01-05 21:39 partner ~27720	See discussion in the forum - http://www.limesurvey.org/en/forum/can-i-do-this-with-limesurvey/95479-unnecessary-span-in-the-end-message-box#103100,

TMSWhite 2014-01-08 05:19 reporter ~27750	Tony- Yes, ensuring that $staticReplacement returns true in end messages, end URLs and emails should do the trick.

tpartner 2014-01-08 12:43 partner ~27762	Great, thanks for the confirmation Tom.

tpartner 2014-01-08 13:02 partner ~27763	Carsten,I'm not sure where is the best place to detect the replacement use-case and set this var. Can I hand this off to you? (or Sam?)

c_schmitz 2014-01-09 11:16 administrator ~27785	Looks like I fixed this in the past for 2.0 but forgot to port the fix. The fix applied to 2.05 is also more complete.

c_schmitz 2014-01-09 11:17 administrator ~27786	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13663

c_schmitz 2014-01-09 23:31 administrator ~27800	2.05+ build 140109 released

LimeSurvey: master 0730c831 2014-01-09 10:17:59 c_schmitz Details Diff	Fixed issue 08509: INSERTANS SPAN problem in end URL/page when using then all-in-one page presentation setting	Affected Issues 08509
	mod - application/helpers/SurveyRuntimeHelper.php	Diff File
	mod - application/helpers/replacements_helper.php	Diff File

Date Modified	Username	Field	Change
2014-01-05 21:29	tpartner	New Issue
2014-01-05 21:29	tpartner	File Added: limesurvey_survey_338692(1).lss
2014-01-05 21:32	tpartner	Description Updated
2014-01-05 21:33	tpartner	File Added: spans_1.png
2014-01-05 21:39	tpartner	Note Added: 27720
2014-01-08 05:19	TMSWhite	Note Added: 27750
2014-01-08 12:43	tpartner	Note Added: 27762
2014-01-08 13:01	tpartner	Assigned To	=> c_schmitz
2014-01-08 13:01	tpartner	Status	new => assigned
2014-01-08 13:02	tpartner	Note Added: 27763
2014-01-09 11:15	c_schmitz	Relationship added	duplicate of 07923
2014-01-09 11:16	c_schmitz	Note Added: 27785
2014-01-09 11:16	c_schmitz	Status	assigned => resolved
2014-01-09 11:16	c_schmitz	Fixed in Version	=> 2.05+
2014-01-09 11:16	c_schmitz	Resolution	open => fixed
2014-01-09 11:17	c_schmitz	Changeset attached	=> LimeSurvey master 0730c831
2014-01-09 11:17	c_schmitz	Note Added: 27786
2014-01-09 23:31	c_schmitz	Note Added: 27800
2014-01-09 23:31	c_schmitz	Status	resolved => closed