View Issue Details

IDProjectCategoryView StatusLast Update
08466Bug reports[All Projects] Survey designpublic2014-01-16 16:45
ReporterDenisChenuAssigned Tomdekker 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Target VersionFixed in Version2.05+ 
Summary08466: CSS/HTML issue with Plugin/settings
DescriptionIf plugin use input[text] css and HTML seems OK, but broke if use checkbox or select.

See screen shot with one checkbox and one select.
Steps To ReproduceInstall Shnoulle/LS-recomputeExpression from Github and go to config. Or do a setting with 2 checkbox.
Additional InformationActually HTML is
<label><input>

Maybe we can use li or dl/dt to have same system like other form.
OR :
Maybe we can remove the width:40%;display:inline-block and use bootstrap system (checkbox included in label, control-group etc ...)
TagsNo tags attached.
Complete LimeSurvey version number (& build)131218
I will donate to the project if issue is resolvedNo
BrowserFF22
Database & DB-Versionnot relevant
Operating System (Server)not relevant
Webserver software & versionnot relevant
PHP Versionnot relevant

Relationships

related to 08306 new Development  HTML in admin are really hard to style 

Activities

DenisChenu

2013-12-18 17:32

developer  

c_schmitz

2014-01-14 12:06

administrator   ~27847

Can you provide a test plugin demonstrating the issue, please?

DenisChenu

2014-01-14 12:20

developer   ~27848

https://github.com/Shnoulle/LS-recomputeExpression

mdekker

2014-01-15 09:22

developer   ~27871

Hey Denis, didn't see this plugin before but (just by reading) it sounds really helpful! I think it should at least be added to the available extensions and maybe even added to core as to me not being able to recalc is a dealbreaker for serious score calculation.

mdekker

2014-01-15 09:30

developer  

menno_plugin_settings.jpg (23,749 bytes)
menno_plugin_settings.jpg (23,749 bytes)

mdekker

2014-01-15 09:31

developer   ~27872

In my install (on chrome) it looks ok, maybe a browser incompatibility?

DenisChenu

2014-01-15 10:11

developer   ~27875

@mdekker : NO, it's not really ready : it use a lot of hack and actionRecompute() use a lot of complete LS rewriting : it's not clean. You're rigth : this need to be in https://www.limesurvey.org/en/extensions but i work on another website for 'extend and plugin' presentation. I don't like to use external service for this (git.sondages.pro).

For chrome : near same but different in blue or grenn (see attached screen).

The problem is here : https://github.com/LimeSurvey/LimeSurvey/blob/master/styles/configure.css : I think this part and HTML can/must be clean without any template. We have width: 40% for label.

Maybe we can use bootstrap here, but then input[text] is underneath/below label.

mdekker

2014-01-15 11:26

developer   ~27876

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13689

mdekker

2014-01-15 11:34

developer   ~27878

Tried to quickfix the look of the plugins / pluginsettings to be more like the other pages. Feel free to do other improvements. I also thought of removing the config.css and to put it somewhere else as it is another request adding overhead. But since i don't have time to check i left it like this.

DenisChenu

2014-01-15 12:02

developer   ~27879

Hi @mdekker, yes it's better now, more like other.

Leave future for 08306 ? (and close this one).

c_schmitz

2014-01-15 12:11

administrator   ~27880

Looks fine to me. Thank you, Menno!

c_schmitz

2014-01-16 16:45

administrator   ~27909

2.05+ Build 140116 released

Related Changesets

LimeSurvey: master 2a5afb38

2014-01-15 09:32:54

mdekker

Details Diff
dev: added admin footer to plugin layout (as a widget)
add - application/extensions/AdminFooter/AdminFooter.php Diff File
add - application/extensions/AdminFooter/views/footer.php Diff File
mod - application/views/layouts/main.php Diff File

LimeSurvey: master 29dfd571

2014-01-15 10:06:57

mdekker

Details Diff
dev: made plugins / pluginsettings use the same rendering using bootstrap in the right order
mod - application/controllers/PluginsController.php Diff File
mod - styles/configure.css Diff File

LimeSurvey: master 792a8655

2014-01-15 10:26:27

mdekker

Details Diff
Fixed 08466: CSS/HTML issue with Plugin/settings
mod - application/extensions/SettingsWidget/SettingsWidget.php Diff File
mod - application/extensions/SettingsWidget/assets/settingswidget.css Diff File
mod - styles/configure.css Diff File

Issue History

Date Modified Username Field Change
2013-12-18 17:32 DenisChenu New Issue
2013-12-18 17:32 DenisChenu File Added: Capture du 2013-12-18 17:32:47.png
2014-01-14 12:06 c_schmitz Note Added: 27847
2014-01-14 12:20 DenisChenu Note Added: 27848
2014-01-15 09:22 mdekker Note Added: 27871
2014-01-15 09:30 mdekker File Added: menno_plugin_settings.jpg
2014-01-15 09:31 mdekker Note Added: 27872
2014-01-15 10:11 DenisChenu Note Added: 27875
2014-01-15 10:12 DenisChenu Relationship added related to 08306
2014-01-15 11:26 mdekker Changeset attached => LimeSurvey master 792a8655
2014-01-15 11:26 mdekker Note Added: 27876
2014-01-15 11:26 mdekker Assigned To => mdekker
2014-01-15 11:26 mdekker Resolution open => fixed
2014-01-15 11:34 mdekker Note Added: 27878
2014-01-15 11:46 mdekker Changeset attached => LimeSurvey master 29dfd571
2014-01-15 11:46 mdekker Changeset attached => LimeSurvey master 2a5afb38
2014-01-15 12:02 DenisChenu Note Added: 27879
2014-01-15 12:11 c_schmitz Note Added: 27880
2014-01-15 12:11 c_schmitz Status new => resolved
2014-01-15 12:11 c_schmitz Fixed in Version => 2.05+
2014-01-16 16:45 c_schmitz Note Added: 27909
2014-01-16 16:45 c_schmitz Status resolved => closed