View Issue Details

Jump to NotesJump to History
IDProjectCategoryView StatusDate SubmittedLast Update
07692Development Survey editingpublic2013-03-20 15:052015-06-16 14:56
ReporterDenisChenu Assigned ToDenisChenu  
PrioritylowSeverityminor 
Status closedResolutionno change required 
Product Version2.05 
Target Version2.1 
Summary07692: Removing uneeded sid and gid from admin link
DescriptionActually, the link to view a question is something like that:

admin/survey/sa/view/surveyid/87262/gid/5/qid/16

Changing the gid (or the sid) break HTML in 2.0 and show bad information on 205
Additional InformationIn 200: Trying to get property of non-object because qid searching with gid (or sid).

We can remove sid if we have gid and gid if we have qid.
In Survey_Common_Action.php :
in private function _addPseudoParams($params)

if (qid){gid=questions.gid}
if (gid){sid=questions.sid}

(somethink like that)

TagsNo tags attached.

Relationships

Relationship GraphDependency Graph
has duplicate 07129 closedDenisChenu Good question id, but page break 

Activities

DenisChenu

DenisChenu

2013-03-20 15:05

developer   ~24812

Carsten: assign it to you, if OK i take it.
sammousa

sammousa

2013-03-20 15:18

reporter   ~24813

While I agree that this is ugly at the moment,
I suggest we keep this stuff as is for now. In 2.1 all these urls will change anyway which means any changes we make here are useless in the long term.
DenisChenu

DenisChenu

2013-03-20 16:53

developer   ~24816

Yes,

Don't use link but fox gid and sid now .
DenisChenu

DenisChenu

2015-06-16 14:56

developer   ~32385

System are updated in ls3

Issue History

Date Modified Username Field Change
2013-03-20 15:05 DenisChenu New Issue
2013-03-20 15:05 DenisChenu Assigned To => c_schmitz
2013-03-20 15:05 DenisChenu Status new => assigned
2013-03-20 15:05 DenisChenu Note Added: 24812
2013-03-20 15:17 DenisChenu Assigned To c_schmitz => DenisChenu
2013-03-20 15:18 sammousa Note Added: 24813
2013-03-20 16:53 DenisChenu Note Added: 24816
2013-03-20 16:53 DenisChenu Target Version => 2.1
2014-10-26 12:33 DenisChenu Relationship added has duplicate 07129
2015-06-16 14:56 DenisChenu Note Added: 32385
2015-06-16 14:56 DenisChenu Status assigned => closed
2015-06-16 14:56 DenisChenu Resolution open => no change required
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing