View Issue Details

IDProjectCategoryView StatusLast Update
06887Development [All Projects] Import/Exportpublic2015-08-21 15:51
ReporterDenisChenuAssigned Tomdekker 
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version 
Target VersionFixed in Version2.1 
Summary06887: Unable to import lss files from 1.92
Description

When trying to import an lss files: error is shown:
PHP notice
Trying to get property of non-object $languagecode=Survey::model()->findByPk($surveyid)->language;

Steps To Reproduce

Try to import included lss files.

Additional Information

It's OK with 2.0, files is from 1.92

TagsNo tags attached.

Activities

DenisChenu

DenisChenu

2012-11-16 10:24

developer  

limesurvey_survey_85678.lss (386,217 bytes)
mdekker

mdekker

2012-11-16 10:50

reporter   ~22256

I put my fixes in 2.1 but found another issue. I think line 3657 should be $insertdata like in master but not sure. Probably something you did so leaving it to you.

/mgz/survey/test/ls21/application/helpers/admin/import_helper.php(3658)

3646 $insertdata['qid']=$aQIDReplacements[$oldqid];
3647 switchMSSQLIdentityInsert('questions',true);
3648
3649 }
3650 if (isset($insertdata['type'])){
3651 $insertdata['tid'] = Question_types::model()->findByAttributes(array('legacy' => $insertdata['type']))->getAttribute('tid');
3652 //unset($insertdata['type']); //AJSL
3653 } else {
3654 $insertdata['tid'] = Question_types::model()->findByAttributes(array('class' => $insertdata['class']))->getAttribute('tid');
3655 unset($insertdata['class']);
3656 }
3657 if ($xssfilter)
3658 XSSFilterArray($insertdata);
3659 $newqid = Questions::model()->insertRecords($insertdata) or safeDie($clang->gT("Error").": Failed to insert data [4]<br />");
3660 if (!isset($aQIDReplacements[$oldqid]))

mdekker

mdekker

2012-11-16 11:44

reporter   ~22258

Fix committed to 2.1 branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&amp;id=10330

mdekker

mdekker

2012-11-16 11:46

reporter   ~22259

Could you verify the last patch is like it should be with the filters?

DenisChenu

DenisChenu

2012-11-16 11:51

developer   ~22260

I review the filter for 21, but actually :
it's in /application/modules/CheckQuestion.php(431)

Ajs ?

DenisChenu

DenisChenu

2012-11-16 11:52

developer   ~22261

This one is resolved : not same error : another bug ;)

Related Changesets

LimeSurvey: 2.1 c07a4dba

2012-11-16 09:39:02

mdekker

Details Diff
dev: ported pending patches from master to 2.1 Affected Issues
06887
mod - application/controllers/InstallerController.php Diff File
mod - application/controllers/admin/surveyadmin.php Diff File
mod - application/core/LSYii_Application.php Diff File
mod - application/models/Survey.php Diff File

LimeSurvey: 2.1 4faf6d9d

2012-11-16 10:42:53

mdekker

Details Diff
fixed 06887: Unable to import lss files in 2.1
dev: Schnoulle could you verify this is correct?
Affected Issues
06887
mod - application/helpers/admin/import_helper.php Diff File

Issue History

Date Modified Username Field Change
2012-11-16 10:24 DenisChenu New Issue
2012-11-16 10:24 DenisChenu File Added: limesurvey_survey_85678.lss
2012-11-16 10:50 mdekker Note Added: 22256
2012-11-16 10:52 c_schmitz Project Bug reports => Development
2012-11-16 11:41 mdekker Changeset attached => LimeSurvey 2.1 c07a4dba
2012-11-16 11:44 mdekker Changeset attached => LimeSurvey 2.1 4faf6d9d
2012-11-16 11:44 mdekker Note Added: 22258
2012-11-16 11:44 mdekker Assigned To => mdekker
2012-11-16 11:44 mdekker Resolution open => fixed
2012-11-16 11:46 mdekker Note Added: 22259
2012-11-16 11:46 mdekker Assigned To mdekker => DenisChenu
2012-11-16 11:46 mdekker Status new => feedback
2012-11-16 11:51 DenisChenu Note Added: 22260
2012-11-16 11:51 DenisChenu Status feedback => assigned
2012-11-16 11:52 DenisChenu Note Added: 22261
2012-11-16 11:52 DenisChenu Assigned To DenisChenu => mdekker
2012-11-16 11:52 DenisChenu Status assigned => resolved
2012-11-16 11:52 DenisChenu Fixed in Version => 2.1
2015-08-21 15:51 c_schmitz Status resolved => closed