View Issue Details

IDProjectCategoryView StatusLast Update
06783Development [All Projects] Survey takingpublic2018-12-18 15:21
ReporterNortonTAssigned To 
PrioritylowSeveritytweak 
Status closedResolutionfixed 
Product Version 
Target Version2.1Fixed in Version2.5x 
Summary06783: GCI: Deprecated <center> tag used to align button on print answers page
Description

Deprecated <center> tag used to align the "PDF export" button on print answers page, therefore it's position cannot be controlled using css in a template.

In order to fix I'd propose changing L130 of PrintanswersController.php from:

$printoutput .= "<form action='".Yii::app()->getController()->createUrl('printanswers/view/surveyid/'.$surveyid.'/printableexport/pdf')."' method='post'>\n<center><input type='submit' value='".$clang->gT("PDF export")."'id=\"exportbutton\"/><input type='hidden' name='printableexport' /></center></form>";

To:

$printoutput .= "<form action='".Yii::app()->getController()->createUrl('printanswers/view/surveyid/'.$surveyid.'/printableexport/pdf')."' method='post'>\n<input type='submit' value='".$clang->gT("PDF export")."'id=\"exportbutton\"/ style='text-align:center;'><input type='hidden' name='printableexport' /></form>";

TagsNo tags attached.

Activities

NortonT

NortonT

2012-10-26 15:05

reporter   ~21711

Apologies I copied my correction wrongly, it should be:

$printoutput .= "<form action='".Yii::app()->getController()->createUrl('printanswers/view/surveyid/'.$surveyid.'/printableexport/pdf')."' method='post' style='text-align:center'>\n<input type='submit' value='".$clang->gT("PDF export")."'id=\"exportbutton\"/><input type='hidden' name='printableexport' /></form>";

With style='text-align:center' applied to the <form> element not the <input> element

DenisChenu

DenisChenu

2012-10-26 18:31

developer   ~21722

Hello,

Not style='text-align:center' BUT a class. (not clas="center", becaus you can want this on right. Use class to identify item, not to put css information.

For exemple, never use class="red", but class="error" ;)

Issue History

Date Modified Username Field Change
2012-10-26 15:01 NortonT New Issue
2012-10-26 15:05 NortonT Note Added: 21711
2012-10-26 16:56 c_schmitz Project Bug reports => Development
2012-10-26 17:03 c_schmitz Product Version 2.00+ =>
2012-10-26 17:03 c_schmitz Summary Deprecated <center> tag used to align button on print answers page => GCI: Deprecated <center> tag used to align button on print answers page
2012-10-26 17:04 c_schmitz Target Version => 2.1
2012-10-26 18:31 DenisChenu Note Added: 21722
2018-12-18 15:21 DenisChenu Status new => closed
2018-12-18 15:21 DenisChenu Resolution open => fixed
2018-12-18 15:21 DenisChenu Fixed in Version => 2.5x