View Issue Details
| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 06763 | Bug reports | Other | public | 2012-10-24 09:09 | 2026-11-19 22:24 |
| Reporter | c_schmitz | Assigned To | |||
| Priority | normal | Severity | minor | ||
| Status | closed | Resolution | fixed | ||
| Summary | 06763: Question attributes are not part of the question objects yet | ||||
| Description | All question attributes need to be moved to their respective question types objects - as far as I can see they currently still reside in common_helpers.php . Also for the purpose of issue 06716 an additional inputtype needs to be added | ||||
| Tags | No tags attached. | ||||
| Bug heat | 4 | ||||
| Complete LimeSurvey version number (& build) | |||||
| I will donate to the project if issue is resolved | |||||
| Browser | |||||
| Database type & version | |||||
| Server OS (if known) | |||||
| Webserver software & version (if known) | |||||
| PHP Version | |||||
| Git branch / Pull Request URL | |||||
| related to | 06716 | closed | question view screen does not syntax-highlight any advanced question options |
|
Each class has a list of its attributes returned by availableAttributes(). Specific attribute values are returned by getAttributeValues() which is inherited from QuestionModule. I don't understand what the issue is. |
|
|
The issue is that only the attribute names are there - the whole definition should be moved the particular question object (and only the question attributes that matter for that question type, of course) Because what if I want to create a new attribute for a question type? There is currently no way of doing that without adding it to the core. So, the function questionAttributes in common_helper should not exist anymore. |
|
|
Fair enough. I'll need to think about the proper implementation of this for a bit though because I don't want to duplicate the definition in each file. |
|
|
But... yes, I agree with you in practice. |
|
|
I guess there is no way around duplicating the definition in each file ;). |
|
|
Fix me! ;) |
|
|
In LimeSurvey 7 question attributes are no longer defined centrally in common_helper: every question type and question theme declares its own attributes in its config.xml, and attributes can be flagged as expressions so they are syntax-highlighted in the question summary. Closing as fixed. |
|
| Date Modified | Username | Field | Change |
|---|---|---|---|
| 2012-10-24 09:09 | c_schmitz | New Issue | |
| 2012-10-24 09:09 | c_schmitz | Status | new => assigned |
| 2012-10-24 09:09 | c_schmitz | Assigned To | => user16774 |
| 2012-10-24 09:10 | c_schmitz | Relationship added | related to 06716 |
| 2012-10-26 16:18 |
|
Note Added: 21714 | |
| 2012-10-26 17:21 | c_schmitz | Note Added: 21719 | |
| 2012-10-26 17:22 | c_schmitz | Note Edited: 21719 | |
| 2012-10-26 17:23 | c_schmitz | Note Edited: 21719 | |
| 2012-10-26 17:23 | c_schmitz | Note Edited: 21719 | |
| 2012-10-26 17:34 |
|
Note Added: 21720 | |
| 2012-10-26 17:34 |
|
Note Added: 21721 | |
| 2012-10-26 21:41 | c_schmitz | Note Added: 21723 | |
| 2012-11-26 22:25 | c_schmitz | Note Added: 22560 | |
| 2021-12-30 12:00 | galads | Status | assigned => acknowledged |
| 2026-11-19 22:24 | c_schmitz | Note Added: 87749 | |
| 2026-11-19 22:24 | c_schmitz | Status | acknowledged => closed |
| 2026-11-19 22:24 | c_schmitz | Resolution | open => fixed |