View Issue Details

IDProjectCategoryView StatusLast Update
06763Development Otherpublic2012-11-26 22:25
Reporterc_schmitzAssigned Touser16774 
PrioritynormalSeverityminor 
Status assignedResolutionopen 
Product Version2.1 
Target Version2.1Fixed in Version 
Summary06763: Question attributes are not part of the question objects yet
Description

All question attributes need to be moved to their respective question types objects - as far as I can see they currently still reside in common_helpers.php .

Also for the purpose of issue 06716 an additional inputtype needs to be added
that marks an attribute as an expression so that is properly highlighted when shown in the interface.

TagsNo tags attached.

Relationships

related to 06716 acknowledgeduser16774 question view screen does not syntax-highlight any advanced question options 

Activities

user16774

2012-10-26 16:18

  ~21714

Each class has a list of its attributes returned by availableAttributes(). Specific attribute values are returned by getAttributeValues() which is inherited from QuestionModule.

I don't understand what the issue is.

c_schmitz

c_schmitz

2012-10-26 17:21

administrator   ~21719

Last edited: 2012-10-26 17:23

View 4 revisions

The issue is that only the attribute names are there - the whole definition should be moved the particular question object (and only the question attributes that matter for that question type, of course)

Because what if I want to create a new attribute for a question type? There is currently no way of doing that without adding it to the core.

So, the function questionAttributes in common_helper should not exist anymore.

user16774

2012-10-26 17:34

  ~21720

Fair enough. I'll need to think about the proper implementation of this for a bit though because I don't want to duplicate the definition in each file.

user16774

2012-10-26 17:34

  ~21721

But... yes, I agree with you in practice.

c_schmitz

c_schmitz

2012-10-26 21:41

administrator   ~21723

I guess there is no way around duplicating the definition in each file ;).

c_schmitz

c_schmitz

2012-11-26 22:25

administrator   ~22560

Fix me! ;)

Issue History

Date Modified Username Field Change
2012-10-24 09:09 c_schmitz New Issue
2012-10-24 09:09 c_schmitz Status new => assigned
2012-10-24 09:09 c_schmitz Assigned To => user16774
2012-10-24 09:10 c_schmitz Relationship added related to 06716
2012-10-26 16:18 user16774 Note Added: 21714
2012-10-26 17:21 c_schmitz Note Added: 21719
2012-10-26 17:22 c_schmitz Note Edited: 21719 View Revisions
2012-10-26 17:23 c_schmitz Note Edited: 21719 View Revisions
2012-10-26 17:23 c_schmitz Note Edited: 21719 View Revisions
2012-10-26 17:34 user16774 Note Added: 21720
2012-10-26 17:34 user16774 Note Added: 21721
2012-10-26 21:41 c_schmitz Note Added: 21723
2012-11-26 22:25 c_schmitz Note Added: 22560